From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED20C4363A for ; Tue, 27 Oct 2020 19:48:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77B0B2074B for ; Tue, 27 Oct 2020 19:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603828126; bh=EoKaV0LObB+LCs3KUN9FklYBIFfuTgY+FAEpljpePoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ug901onZnlBsi2NtK+nAbFhuTI6/Z9wiXchb0CiXDBXh5xctc140A7MVv2k0vrRVZ MB3Tc3AY/+tKufjRUhRp5+0E8SAJtxNCuSSVQHijkvPRqYis9Fl9RzBZKt13XzyLGn z1xlh6IgJ/uyuVN8LSlhzo0grsF5hqSOV0WfYYlM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1830529AbgJ0Tsk convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2020 15:48:40 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40162 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1830518AbgJ0Tsj (ORCPT ); Tue, 27 Oct 2020 15:48:39 -0400 Received: by mail-ed1-f67.google.com with SMTP id p93so2704752edd.7; Tue, 27 Oct 2020 12:48:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=DCnp21W838z3J54dqoT+LPZURnglQ0VUhiX4g0DgzEM=; b=t6BUAd/p6xwdy6r6cAW1AjllXbBOFhn/BnO5pUxZ1kEnSTJAXkJVU61whMB6qBxRTD yITiHFXnaHwSqcymOJxNywv1YJ5JcEV/aAp5XhHogrnNmKGxqQNIB6qihPPoCX8PRsOI OAxPvJFr5bDMqqU+hJobkc8Dzb1HhxIzWbgyrd51kHv2HR2u05EwPl+bi3tPH7ThU4oj rWrhyrVYrQvEyE9OMTP0ovTp3ZUQhZ4DOev8Dkxb2i3fHhJeXXRpKKV6M6KowJZIg28W Jgm9C/lzpfcrGWwSBnIrzt/PnWA18NdIy8QSL9vn9acEGQqu5mH7+pbWEyVYf7PrUazx w01Q== X-Gm-Message-State: AOAM5336xRqrJxnkNPctZ40cCDUM0KTCxuB0IrsFRVRRLhobPOCZxwB5 N2i+EcWzoVpC57auddFu7n0= X-Google-Smtp-Source: ABdhPJyGc94tfyRFl9VLzlaneyVsIYgUVM3YkjJxfOPWRF2V8kbYt5rWKEKhzQ7H5M62+MCIviirCw== X-Received: by 2002:a50:e447:: with SMTP id e7mr4040757edm.263.1603828117108; Tue, 27 Oct 2020 12:48:37 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id ss7sm1615086ejb.28.2020.10.27.12.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 12:48:35 -0700 (PDT) Date: Tue, 27 Oct 2020 20:48:33 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property Message-ID: <20201027194833.GE140636@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-14-digetx@gmail.com> <20201027102506.GB17089@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Oct 27, 2020 at 10:19:28PM +0300, Dmitry Osipenko wrote: > 27.10.2020 13:25, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:56AM +0300, Dmitry Osipenko wrote: > >> External memory controller is interconnected with memory controller and > >> with external memory. Document new interconnect property which turns > >> External Memory Controller into interconnect provider. > >> > >> Signed-off-by: Dmitry Osipenko > >> --- > >> .../bindings/memory-controllers/nvidia,tegra124-emc.yaml | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > >> index 278549f9e051..ac00832ceac1 100644 > >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml > >> @@ -29,6 +29,9 @@ properties: > >> items: > >> - const: emc > >> > >> + "#interconnect-cells": > >> + const: 0 > >> + > >> nvidia,memory-controller: > >> $ref: /schemas/types.yaml#/definitions/phandle > >> description: > >> @@ -327,6 +330,7 @@ required: > >> - clocks > >> - clock-names > >> - nvidia,memory-controller > >> + - "#interconnect-cells" > > > > Another required property, what about all existing users of this binding? > > EMC/devfreq drivers check presence of the new properties and ask users > to upgrade the DT. The kernel will continue to work fine using older > DTBs, but devfreq driver won't load. If the devfreq was working fine before (with these older DTBs and older kernel) then you break the feature. If devfreq was not working or was not stable enough, then nothing is broken so such change is accepted. Which one is then? > > >> additionalProperties: false > >> > >> @@ -345,6 +349,7 @@ examples: > >> > >> #iommu-cells = <1>; > >> #reset-cells = <1>; > >> + #interconnect-cells = <1>; > > > > You meant '0'? > > '1' is for the "mc" node in the example (not "emc" node). > > Anyways, I'll move this hunk to the previous patch in order to fix the > kernel bot warning. Right, thanks. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60841C55178 for ; Tue, 27 Oct 2020 19:48:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E66BC2074B for ; Tue, 27 Oct 2020 19:48:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E66BC2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 320556EC2D; Tue, 27 Oct 2020 19:48:39 +0000 (UTC) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79D196EC2D for ; Tue, 27 Oct 2020 19:48:38 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id o18so2720259edq.4 for ; Tue, 27 Oct 2020 12:48:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=DCnp21W838z3J54dqoT+LPZURnglQ0VUhiX4g0DgzEM=; b=plMlC+t2zXpjNHdDfklukPJD1+vZFcJXYwhlpWgsEdeluTi3iq+SVr4TMNYo1oB5e4 0i1WiFjRAT60Y1L/E44/xzupmxX7ALO2/Kwu+DuJrQRnNsPspVMVJcfmY2FtEjSebur6 XQHVUHV8gxSD9o9RVUewnof2Ry7M0Z8LWX97B4ylG7ATaPsE1EabcNHCTvmRi2H0ld0/ 2W9nFtiNii6Zym8S/ijXayGB2CSxIVgfCTsoZmrbpQLOApZBDLzzayv0QQGmGfXcpAmp SJIoQ6q2tczmxWRG4HTTHS9Xbuicz8WgqC8XiA+6HR7G7OJsfSMEVxMsG6fuyjalm2JR xY9g== X-Gm-Message-State: AOAM530aHKfTsc304DxUosM20d5Amr9USdqI00QFhb+YDGK1VmOr7Qkr ZH1GyJOKDbU+5p8QSKLlSMs= X-Google-Smtp-Source: ABdhPJyGc94tfyRFl9VLzlaneyVsIYgUVM3YkjJxfOPWRF2V8kbYt5rWKEKhzQ7H5M62+MCIviirCw== X-Received: by 2002:a50:e447:: with SMTP id e7mr4040757edm.263.1603828117108; Tue, 27 Oct 2020 12:48:37 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id ss7sm1615086ejb.28.2020.10.27.12.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 12:48:35 -0700 (PDT) Date: Tue, 27 Oct 2020 20:48:33 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property Message-ID: <20201027194833.GE140636@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-14-digetx@gmail.com> <20201027102506.GB17089@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBPY3QgMjcsIDIwMjAgYXQgMTA6MTk6MjhQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI3LjEwLjIwMjAgMTM6MjUsIEtyenlzenRvZiBLb3psb3dza2kg0L/QuNGI0LXR gjoKPiA+IE9uIE1vbiwgT2N0IDI2LCAyMDIwIGF0IDAxOjE2OjU2QU0gKzAzMDAsIERtaXRyeSBP c2lwZW5rbyB3cm90ZToKPiA+PiBFeHRlcm5hbCBtZW1vcnkgY29udHJvbGxlciBpcyBpbnRlcmNv bm5lY3RlZCB3aXRoIG1lbW9yeSBjb250cm9sbGVyIGFuZAo+ID4+IHdpdGggZXh0ZXJuYWwgbWVt b3J5LiBEb2N1bWVudCBuZXcgaW50ZXJjb25uZWN0IHByb3BlcnR5IHdoaWNoIHR1cm5zCj4gPj4g RXh0ZXJuYWwgTWVtb3J5IENvbnRyb2xsZXIgaW50byBpbnRlcmNvbm5lY3QgcHJvdmlkZXIuCj4g Pj4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgT3NpcGVua28gPGRpZ2V0eEBnbWFpbC5jb20+ Cj4gPj4gLS0tCj4gPj4gIC4uLi9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRl Z3JhMTI0LWVtYy55YW1sICAgfCA3ICsrKysrKysKPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5z ZXJ0aW9ucygrKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMTI0LWVtYy55YW1sIGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21lbW9yeS1jb250cm9sbGVycy9udmlk aWEsdGVncmExMjQtZW1jLnlhbWwKPiA+PiBpbmRleCAyNzg1NDlmOWUwNTEuLmFjMDA4MzJjZWFj MSAxMDA2NDQKPiA+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVt b3J5LWNvbnRyb2xsZXJzL252aWRpYSx0ZWdyYTEyNC1lbWMueWFtbAo+ID4+ICsrKyBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRl Z3JhMTI0LWVtYy55YW1sCj4gPj4gQEAgLTI5LDYgKzI5LDkgQEAgcHJvcGVydGllczoKPiA+PiAg ICAgIGl0ZW1zOgo+ID4+ICAgICAgICAtIGNvbnN0OiBlbWMKPiA+PiAgCj4gPj4gKyAgIiNpbnRl cmNvbm5lY3QtY2VsbHMiOgo+ID4+ICsgICAgY29uc3Q6IDAKPiA+PiArCj4gPj4gICAgbnZpZGlh LG1lbW9yeS1jb250cm9sbGVyOgo+ID4+ICAgICAgJHJlZjogL3NjaGVtYXMvdHlwZXMueWFtbCMv ZGVmaW5pdGlvbnMvcGhhbmRsZQo+ID4+ICAgICAgZGVzY3JpcHRpb246Cj4gPj4gQEAgLTMyNyw2 ICszMzAsNyBAQCByZXF1aXJlZDoKPiA+PiAgICAtIGNsb2Nrcwo+ID4+ICAgIC0gY2xvY2stbmFt ZXMKPiA+PiAgICAtIG52aWRpYSxtZW1vcnktY29udHJvbGxlcgo+ID4+ICsgIC0gIiNpbnRlcmNv bm5lY3QtY2VsbHMiCj4gPiAKPiA+IEFub3RoZXIgcmVxdWlyZWQgcHJvcGVydHksIHdoYXQgYWJv dXQgYWxsIGV4aXN0aW5nIHVzZXJzIG9mIHRoaXMgYmluZGluZz8KPiAKPiBFTUMvZGV2ZnJlcSBk cml2ZXJzIGNoZWNrIHByZXNlbmNlIG9mIHRoZSBuZXcgcHJvcGVydGllcyBhbmQgYXNrIHVzZXJz Cj4gdG8gdXBncmFkZSB0aGUgRFQuIFRoZSBrZXJuZWwgd2lsbCBjb250aW51ZSB0byB3b3JrIGZp bmUgdXNpbmcgb2xkZXIKPiBEVEJzLCBidXQgZGV2ZnJlcSBkcml2ZXIgd29uJ3QgbG9hZC4KCklm IHRoZSBkZXZmcmVxIHdhcyB3b3JraW5nIGZpbmUgYmVmb3JlICh3aXRoIHRoZXNlIG9sZGVyIERU QnMgYW5kIG9sZGVyCmtlcm5lbCkgdGhlbiB5b3UgYnJlYWsgdGhlIGZlYXR1cmUuCgpJZiBkZXZm cmVxIHdhcyBub3Qgd29ya2luZyBvciB3YXMgbm90IHN0YWJsZSBlbm91Z2gsIHRoZW4gbm90aGlu ZyBpcwpicm9rZW4gc28gc3VjaCBjaGFuZ2UgaXMgYWNjZXB0ZWQuCgpXaGljaCBvbmUgaXMgdGhl bj8KCj4gCj4gPj4gIGFkZGl0aW9uYWxQcm9wZXJ0aWVzOiBmYWxzZQo+ID4+ICAKPiA+PiBAQCAt MzQ1LDYgKzM0OSw3IEBAIGV4YW1wbGVzOgo+ID4+ICAKPiA+PiAgICAgICAgICAjaW9tbXUtY2Vs bHMgPSA8MT47Cj4gPj4gICAgICAgICAgI3Jlc2V0LWNlbGxzID0gPDE+Owo+ID4+ICsgICAgICAg ICNpbnRlcmNvbm5lY3QtY2VsbHMgPSA8MT47Cj4gPiAKPiA+IFlvdSBtZWFudCAnMCc/Cj4gCj4g JzEnIGlzIGZvciB0aGUgIm1jIiBub2RlIGluIHRoZSBleGFtcGxlIChub3QgImVtYyIgbm9kZSku Cj4gCj4gQW55d2F5cywgSSdsbCBtb3ZlIHRoaXMgaHVuayB0byB0aGUgcHJldmlvdXMgcGF0Y2gg aW4gb3JkZXIgdG8gZml4IHRoZQo+IGtlcm5lbCBib3Qgd2FybmluZy4KClJpZ2h0LCB0aGFua3Mu CgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==