From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD80C4363A for ; Tue, 27 Oct 2020 20:25:21 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB9902072D for ; Tue, 27 Oct 2020 20:25:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB9902072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-A-Ztbe54OI2KhoyFwP9nhw-1; Tue, 27 Oct 2020 16:25:17 -0400 X-MC-Unique: A-Ztbe54OI2KhoyFwP9nhw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 038DE57207; Tue, 27 Oct 2020 20:25:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFD1A5C1DC; Tue, 27 Oct 2020 20:25:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 58110CF59; Tue, 27 Oct 2020 20:25:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09RK4p1m016773 for ; Tue, 27 Oct 2020 16:04:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id A1F3A110DBFD; Tue, 27 Oct 2020 20:04:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E2731000DAB for ; Tue, 27 Oct 2020 20:04:49 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3D243811E76 for ; Tue, 27 Oct 2020 20:04:49 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-7098ERHSPDm2AAWa6RdUbg-1; Tue, 27 Oct 2020 16:04:44 -0400 X-MC-Unique: 7098ERHSPDm2AAWa6RdUbg-1 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 965AF2222C; Tue, 27 Oct 2020 20:04:42 +0000 (UTC) Date: Tue, 27 Oct 2020 13:04:41 -0700 From: Eric Biggers To: Satya Tangirala Message-ID: <20201027200441.GA2416412@gmail.com> References: <20201015214632.41951-1-satyat@google.com> <20201015214632.41951-2-satyat@google.com> MIME-Version: 1.0 In-Reply-To: <20201015214632.41951-2-satyat@google.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Mike Snitzer , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Alasdair Kergon Subject: Re: [dm-devel] [PATCH v2 1/4] block: keyslot-manager: Introduce passthrough keyslot manager X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Oct 15, 2020 at 09:46:29PM +0000, Satya Tangirala wrote: > +/** > + * blk_ksm_init_passthrough() - Init a passthrough keyslot manager > + * @ksm: The keyslot manager to init > + * > + * Initialize a passthrough keyslot manager. > + * Called by e.g. storage drivers to set up a keyslot manager in their > + * request_queue, when the storage driver wants to manage its keys by itself. > + * This is useful for inline encryption hardware that doesn't have the concept > + * of keyslots, and for layered devices. > + * > + * See blk_ksm_init() for more details about the parameters. > + */ > +void blk_ksm_init_passthrough(struct blk_keyslot_manager *ksm) > +{ > + memset(ksm, 0, sizeof(*ksm)); > + init_rwsem(&ksm->lock); > +} > +EXPORT_SYMBOL_GPL(blk_ksm_init_passthrough); The last paragraph of the comment ("See blk_ksm_init() for more details about the parameters.") isn't useful and should be removed. Otherwise this patch looks fine. You can add: Reviewed-by: Eric Biggers - Eric -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E00C4363A for ; Tue, 27 Oct 2020 20:05:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4A0C2225E for ; Tue, 27 Oct 2020 20:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603829120; bh=f+2hjx0YuqPqtRa+YtUvmPaLqiGcwczmgW7+ZwGJdrY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=E+uSN67bBTyrjA6h2RBFP5M0ZLMuLeBD9D2ZtCVnPJbGzVpIdNkvyuQuIzqL0O98s RMuTk4XEHwjkqyFVSbVK1WTESNnaTsugKaJO2UrVzEb91CjI8HTkNwhhQzdA78dBqZ Fn3FjF7GMu6S/Y/UIT1PsC7+DH8cXmuzKGPuYVzo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1830812AbgJ0UEt (ORCPT ); Tue, 27 Oct 2020 16:04:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:44124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1830753AbgJ0UEn (ORCPT ); Tue, 27 Oct 2020 16:04:43 -0400 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 965AF2222C; Tue, 27 Oct 2020 20:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603829082; bh=f+2hjx0YuqPqtRa+YtUvmPaLqiGcwczmgW7+ZwGJdrY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NU0KV8zW5ixCAu+sNYnAH6LjIGq57HEQiDTruW66p/XuJi+agDC0uCFDvRfJGKuwm xBuME07GZ1sMYD+XuQolKP8fi43DApYhwyL1CkpUO4+qEn/BfIRoJwr6NgLf7A1/ox DQ345kGma6N7sYoDvZ7S2Ja1xdpf6xh/XgY7UWag= Date: Tue, 27 Oct 2020 13:04:41 -0700 From: Eric Biggers To: Satya Tangirala Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, Jens Axboe , Alasdair Kergon , Mike Snitzer Subject: Re: [PATCH v2 1/4] block: keyslot-manager: Introduce passthrough keyslot manager Message-ID: <20201027200441.GA2416412@gmail.com> References: <20201015214632.41951-1-satyat@google.com> <20201015214632.41951-2-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201015214632.41951-2-satyat@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Oct 15, 2020 at 09:46:29PM +0000, Satya Tangirala wrote: > +/** > + * blk_ksm_init_passthrough() - Init a passthrough keyslot manager > + * @ksm: The keyslot manager to init > + * > + * Initialize a passthrough keyslot manager. > + * Called by e.g. storage drivers to set up a keyslot manager in their > + * request_queue, when the storage driver wants to manage its keys by itself. > + * This is useful for inline encryption hardware that doesn't have the concept > + * of keyslots, and for layered devices. > + * > + * See blk_ksm_init() for more details about the parameters. > + */ > +void blk_ksm_init_passthrough(struct blk_keyslot_manager *ksm) > +{ > + memset(ksm, 0, sizeof(*ksm)); > + init_rwsem(&ksm->lock); > +} > +EXPORT_SYMBOL_GPL(blk_ksm_init_passthrough); The last paragraph of the comment ("See blk_ksm_init() for more details about the parameters.") isn't useful and should be removed. Otherwise this patch looks fine. You can add: Reviewed-by: Eric Biggers - Eric