* [PATCH] char: ipmi: remove unneeded break
@ 2020-10-19 19:48 trix
2020-10-27 21:09 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-19 19:48 UTC (permalink / raw)
To: minyard; +Cc: openipmi-developer, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/char/ipmi/ipmi_devintf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
index f7b1c004a12b..3dd1d5abb298 100644
--- a/drivers/char/ipmi/ipmi_devintf.c
+++ b/drivers/char/ipmi/ipmi_devintf.c
@@ -490,7 +490,6 @@ static long ipmi_ioctl(struct file *file,
}
return ipmi_set_my_address(priv->user, val.channel, val.value);
- break;
}
case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD:
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] char: ipmi: remove unneeded break
2020-10-19 19:48 [PATCH] char: ipmi: remove unneeded break trix
@ 2020-10-27 21:09 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2020-10-27 21:09 UTC (permalink / raw)
To: trix; +Cc: openipmi-developer, linux-kernel
On Mon, Oct 19, 2020 at 12:48:05PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
Ok, it's in my next tree.
Thanks,
-corey
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/char/ipmi/ipmi_devintf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index f7b1c004a12b..3dd1d5abb298 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -490,7 +490,6 @@ static long ipmi_ioctl(struct file *file,
> }
>
> return ipmi_set_my_address(priv->user, val.channel, val.value);
> - break;
> }
>
> case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD:
> --
> 2.18.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-19 19:48 [PATCH] char: ipmi: remove unneeded break trix
2020-10-27 21:09 ` Corey Minyard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.