Re: [RFC PATCH kernel 1/2] irq: Add reference counting to IRQ mappings

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3468 bytes --]

Hi Alexey,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on powerpc/next]
[also build test ERROR on tip/irq/core v5.10-rc1 next-20201027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alexey-Kardashevskiy/irq-Add-reference-counting-to-IRQ-mappings/20201027-170907
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: s390-zfcpdump_defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/63684bd94a7e53ec13917e2a23d55ce572bf2878
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexey-Kardashevskiy/irq-Add-reference-counting-to-IRQ-mappings/20201027-170907
        git checkout 63684bd94a7e53ec13917e2a23d55ce572bf2878
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/irq/irqdesc.c: In function 'irq_kobj_release':
>> kernel/irq/irqdesc.c:431:7: error: implicit declaration of function 'irq_domain_is_hierarchy' [-Werror=implicit-function-declaration]
     431 |   if (irq_domain_is_hierarchy(domain)) {
         |       ^~~~~~~~~~~~~~~~~~~~~~~
>> kernel/irq/irqdesc.c:432:4: error: implicit declaration of function 'irq_domain_free_irqs'; did you mean 'irq_domain_activate_irq'? [-Werror=implicit-function-declaration]
     432 |    irq_domain_free_irqs(virq, 1);
         |    ^~~~~~~~~~~~~~~~~~~~
         |    irq_domain_activate_irq
>> kernel/irq/irqdesc.c:434:4: error: implicit declaration of function 'irq_domain_disassociate' [-Werror=implicit-function-declaration]
     434 |    irq_domain_disassociate(domain, virq);
         |    ^~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/irq_domain_is_hierarchy +431 kernel/irq/irqdesc.c

   421	
   422	static void delayed_free_desc(struct rcu_head *rhp);
   423	static void irq_kobj_release(struct kobject *kobj)
   424	{
   425		struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
   426		struct irq_domain *domain;
   427		unsigned int virq = desc->irq_data.irq;
   428	
   429		domain = desc->irq_data.domain;
   430		if (domain) {
 > 431			if (irq_domain_is_hierarchy(domain)) {
 > 432				irq_domain_free_irqs(virq, 1);
   433			} else {
 > 434				irq_domain_disassociate(domain, virq);
   435				irq_free_desc(virq);
   436			}
   437		}
   438	
   439		/*
   440		 * We free the descriptor, masks and stat fields via RCU. That
   441		 * allows demultiplex interrupts to do rcu based management of
   442		 * the child interrupts.
   443		 * This also allows us to use rcu in kstat_irqs_usr().
   444		 */
   445		call_rcu(&desc->rcu, delayed_free_desc);
   446	}
   447	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 7974 bytes --]