From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D0BC55179 for ; Wed, 28 Oct 2020 21:59:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A69424724 for ; Wed, 28 Oct 2020 21:59:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728567AbgJ1V7M (ORCPT ); Wed, 28 Oct 2020 17:59:12 -0400 Received: from mail.nic.cz ([217.31.204.67]:41696 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728675AbgJ1V7L (ORCPT ); Wed, 28 Oct 2020 17:59:11 -0400 Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id 64B27140757; Wed, 28 Oct 2020 03:03:10 +0100 (CET) Date: Wed, 28 Oct 2020 03:03:04 +0100 From: Marek Behun To: Pavana Sharma Cc: f.fainelli@gmail.com, andrew@lunn.ch, davem@davemloft.net, gregkh@linuxfoundation.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vivien.didelot@gmail.com Subject: Re: [PATCH v5 3/3] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell Message-ID: <20201028030304.2ba00b2d@nic.cz> In-Reply-To: References: X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavana, please add me to Cc for this. Does USXGMII mode work? There are some erratas for for 10gb serdes mode. Also you should split this patch. The code that refactores the serdes_get_lane methods should be in a separate patch. I have a device with this switch and also a SFP module which can operate with USXGMII. I would like to get USXGMII mode to work before this support is added, if possible. For some reason though I was unable to get it to work, I will have to look at those erratas. Marek