Re: [PATCH 1/3] locking/rwlocks: Add contention detection for rwlocks

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3727 bytes --]

Hi Ben,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master linus/master linux/master v5.10-rc1 next-20201027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ben-Gardon/locking-rwlocks-Add-contention-detection-for-rwlocks/20201028-005208
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git feff2e65efd8d84cf831668e182b2ce73c604bbb
config: arm64-randconfig-r021-20201027 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project f2c25c70791de95d2466e09b5b58fc37f6ccd7a4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/0cb6f36b82a21b6ce261382a68e09b1b4614a2ed
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ben-Gardon/locking-rwlocks-Add-contention-detection-for-rwlocks/20201028-005208
        git checkout 0cb6f36b82a21b6ce261382a68e09b1b4614a2ed
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/arm64/kernel/asm-offsets.c:10:
   In file included from include/linux/arm_sdei.h:8:
   In file included from include/acpi/ghes.h:5:
   In file included from include/acpi/apei.h:9:
   In file included from include/linux/acpi.h:13:
   In file included from include/linux/irqdomain.h:35:
   In file included from include/linux/of.h:17:
   In file included from include/linux/kobject.h:20:
   In file included from include/linux/sysfs.h:16:
   In file included from include/linux/kernfs.h:13:
   In file included from include/linux/idr.h:15:
   In file included from include/linux/radix-tree.h:16:
   In file included from include/linux/spinlock.h:90:
   In file included from arch/arm64/include/asm/spinlock.h:8:
   In file included from ./arch/arm64/include/generated/asm/qrwlock.h:1:
>> include/asm-generic/qrwlock.h:126:9: error: implicit declaration of function 'arch_spin_is_locked' [-Werror,-Wimplicit-function-declaration]
           return arch_spin_is_locked(&lock->wait_lock);
                  ^
   1 error generated.
   make[2]: *** [scripts/Makefile.build:117: arch/arm64/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1203: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:185: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +/arch_spin_is_locked +126 include/asm-generic/qrwlock.h

   118	
   119	/**
   120	 * queued_rwlock_is_contended - check if the lock is contended
   121	 * @lock : Pointer to queue rwlock structure
   122	 * Return: 1 if lock contended, 0 otherwise
   123	 */
   124	static inline int queued_rwlock_is_contended(struct qrwlock *lock)
   125	{
 > 126		return arch_spin_is_locked(&lock->wait_lock);
   127	}
   128	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41262 bytes --]