From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C72C388F7 for ; Wed, 28 Oct 2020 15:58:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EFBF247D2 for ; Wed, 28 Oct 2020 15:58:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1IsZ3jtG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="V3f74CcI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EFBF247D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IHyihecBt1o0Io4YJ+ZU++jbL9ILsboJj9pqQbiA7Ks=; b=1IsZ3jtGW9w0NuwVEE0//8NVL p2KT3h80S+Ik2kIkkp7JopdXWVA531zLFrlPG3oNcDCjUELhjYJjww+I91av7yT+dMbDC5Z0iQN0C qEwXuhY1YfrM6Z7lEfYpTfPSmgeGtAFv0eObhEZRbarScxKf7vhgyQSsPYImEI75zlOhhJk7acogo s7JpGeV0jtaWAYrAoqXRplSScxV75D1GVN5+9n+OmsMVaxldN+RHszy3E2tfyTo4qL6NertihxZpE z8lVMrU7VLJ4IFYEqg/O8zEyPiAzuIG4Cu31Wtr/iuW+FP1jn3l6mzdyV/35terzshfaP3Cif5yjb CiUU9GfIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXnoH-0005Xb-V5; Wed, 28 Oct 2020 15:56:25 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXnoF-0005Wm-QC for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 15:56:24 +0000 Received: by mail-pf1-x442.google.com with SMTP id 126so3179399pfu.4 for ; Wed, 28 Oct 2020 08:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pPyCWYqSq10HPDJgG/yQJCOua1Y0E94TczuQjJMOcxw=; b=V3f74CcIc4vKjt0JrJjVvd9is6ZyWapQAv57WpaoYryPqra/VqALBMvWt4OXtYYw2H C98YTYW9iAb8rzYBYttXxXHvkSg0MbeNBRAgZkDwVANdmIjol3ocMMxXkOQhMCMQXWPy vsrRz7MyMl2ms72nGZHpsJGLeJ9S2ePGfuKpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pPyCWYqSq10HPDJgG/yQJCOua1Y0E94TczuQjJMOcxw=; b=lJIhLj3ZnQ9BG5mSlh0+BdjJtJ4dfQLHXGIAAvQp5sm/hlClcIVKbTHlI7gzn4exGG voIr06jVTJaWvAx5PjPbBMoe5XWuLtdL7DTqX7i3F7ubMNVPY1g35Qgk/OV1RF4Hfie3 KMtr80b8juhZ4JCLd4YgZ/tyfk13kBP3dLD2ZWJav9FAOi3ym+Cb+2oB673yqaMNDnE7 jKn2bteK8qbNieFwttVFfnOI+RK2xTPqxcA5Cnapx+c6Q7XeoBs3x4bCP+O0f/tFSUVN ciKK042Hi+rvBcsBGA0TT+xq7JhZACmvCtIstR8M6ox/rLIO6XgAzV9nwSc/oyUl3E/0 b+wQ== X-Gm-Message-State: AOAM532w77UqGK0+ejxnpprIT8MCRr7naQHY/VwnmienXqrzOqs4X0IE On8Lw24CxxYL4F+QWP/d1N75mw== X-Google-Smtp-Source: ABdhPJzqq3AKUc9/G4Q52QqJVT+mLQ/cAOTbFYasCv0MCFpcreSAyiZZL36tDPoYZ6Ey0YHSAAu9gA== X-Received: by 2002:a63:5006:: with SMTP id e6mr48289pgb.338.1603900580078; Wed, 28 Oct 2020 08:56:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u4sm5753005pgu.35.2020.10.28.08.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 08:56:17 -0700 (PDT) Date: Wed, 28 Oct 2020 08:56:14 -0700 From: Kees Cook To: Ard Biesheuvel Subject: Re: [PATCH] arm64: vmlinux.lds: account for spurious empty .igot.plt sections Message-ID: <202010280855.DE2EFB5DD@keescook> References: <20201028133332.5571-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201028133332.5571-1-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_115623_873654_147C0177 X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, Nick Desaulniers , Geert Uytterhoeven , Jessica Yu , will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 28, 2020 at 02:33:32PM +0100, Ard Biesheuvel wrote: > Now that we started making the linker warn about orphan sections > (input sections that are not explicitly consumed by an output section), > some configurations produce the following warning: > > aarch64-linux-gnu-ld: warning: orphan section `.igot.plt' from > `arch/arm64/kernel/head.o' being placed in section `.igot.plt' > > It could be any file that triggers this - head.o is simply the first > input file in the link - and the resulting .igot.plt section never > actually appears in vmlinux as it turns out to be empty. > > So let's add .igot.plt to our collection of input sections to disregard > unless they are empty. typo: "non-empty"? > Cc: Jessica Yu > Cc: Kees Cook > Cc: Geert Uytterhoeven > Cc: Nick Desaulniers > Signed-off-by: Ard Biesheuvel Thanks! Any idea what causes this? Reviewed-by: Kees Cook Though I think Will already snagged the patch :) -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel