From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM Date: Wed, 28 Oct 2020 13:16:31 +0200 Message-ID: <20201028111631.GF1428094@kernel.org> References: <20201027112955.14157-1-rppt@kernel.org> <20201027112955.14157-12-rppt@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6whDlm42N3pELagMmdULzK2aTuiW2rxkqhHMxZjugg8=; b=AEjIEZSGRXvppWxnzwx4aKnro qV6tvZGHfstMKDMjFQTQroCUybLvGKdVWOsA80cWPS9w3vKjF/R9p1I9MyCIcvEdfWm0TKbO6aPqm szynrlDWstLZlOSefkWBY5gvtCC3XROu4262vRrtckMjVNfCr3m9DIDWFQcOCi051/dO6IaIMQM98 3NBx4hj8jGSTVwoMFNw5QMhK1QjmvfS73AGdFgSj7WavuvT7wfxufAzdJfcgsG4Q65UCFeEUqCtY8 fJBFFOtWHhP0j0YE/RCfeIr6xhkefgaVilG4K4CS12Eleq9+encjlnlbi//vOrstN96lJ/tXqxqdo Z/lQph6aQ==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603883801; bh=3DtSsbNWZaTf7v/7udK+AIDJ92sxyETNXeC2IzpbaLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nNqIykwPXzPeiPb6AYNYHQQXiJyXiYtwLr73B//voWR8TZa6Eb5++4CieyFXxEh1h 1/1jSd7uHggtcYYQ6K5jPMWeaE8D3Si3dAD3bEDewru+HlpqXxaIyeUj0n/GkzF1sK d2ZhRYNYGHxIcFCusFeRPJXtjEnybkIYxxUOxr+4= Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane-mx.org@lists.infradead.org To: Geert Uytterhoeven Cc: "linux-ia64@vger.kernel.org" , "open list:DOCUMENTATION" , Catalin Marinas , Linux MM , Will Deacon , Greg Ungerer , Jonathan Corbet , Meelis Roos , Russell King , Mike Rapoport , Matt Turner , arcml , Alexey Dobriyan , linux-m68k , John Paul Adrian Glaubitz , Linux ARM , Michael Schmitz , Tony Luck , Vineet Gupta , Linux Kernel Mailing List , alpha , Linux Hi Geert, On Wed, Oct 28, 2020 at 10:25:49AM +0100, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: > > From: Mike Rapoport > > > > The pg_data_t node structures and their initialization currently depends on > > !CONFIG_SINGLE_MEMORY_CHUNK. Since they are required only for DISCONTIGMEM > > make this dependency explicit and replace usage of > > CONFIG_SINGLE_MEMORY_CHUNK with CONFIG_DISCONTIGMEM where appropriate. > > > > The CONFIG_SINGLE_MEMORY_CHUNK was implicitly disabled on the ColdFire MMU > > variant, although it always presumed a single memory bank. As there is no > > actual need for DISCONTIGMEM in this case, make sure that ColdFire MMU > > systems set CONFIG_SINGLE_MEMORY_CHUNK to 'y'. > > > > Signed-off-by: Mike Rapoport > > Thanks for your patch! > > > --- > > arch/m68k/Kconfig.cpu | 6 +++--- > > arch/m68k/include/asm/page_mm.h | 2 +- > > arch/m68k/mm/init.c | 4 ++-- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > Is there any specific reason you didn't convert the checks for > CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c In arch/m68k/kernel/setup_mm.c the CONFIG_SINGLE_MEMORY_CHUNK is needed for the case when a system has two banks, the kernel is loaded into the second bank and so the first bank cannot be used as normal memory. It does not matter what memory model will be used in this case. > and arch/m68k/include/asm/virtconvert.h? I remember I had build errors and troubles with include file dependencies if I changed it there, but I might be mistaken. I'll recheck again. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F69C56201 for ; Thu, 29 Oct 2020 00:56:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF4C420724 for ; Thu, 29 Oct 2020 00:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603933005; bh=3DtSsbNWZaTf7v/7udK+AIDJ92sxyETNXeC2IzpbaLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mHrZn2fQoO0rD9TsB00rMlLqaLSIuleh4d12TTZKHgtNIoDP83NiyLL0nurALgeJs kMIWgopxHuzZNB9sL3oUCtvv0RioFq0DL0x6t7LHfI1k+WbXKhcM2Q1p1vqavyQDfH Gmt7nIk+A1tn+HxfXa/hGu3C9ZI+y3ZjPOgIAOgw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391011AbgJ2A4W (ORCPT ); Wed, 28 Oct 2020 20:56:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:60524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731618AbgJ1WRg (ORCPT ); Wed, 28 Oct 2020 18:17:36 -0400 Received: from kernel.org (unknown [87.70.96.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7666B246B2; Wed, 28 Oct 2020 11:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603883801; bh=3DtSsbNWZaTf7v/7udK+AIDJ92sxyETNXeC2IzpbaLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nNqIykwPXzPeiPb6AYNYHQQXiJyXiYtwLr73B//voWR8TZa6Eb5++4CieyFXxEh1h 1/1jSd7uHggtcYYQ6K5jPMWeaE8D3Si3dAD3bEDewru+HlpqXxaIyeUj0n/GkzF1sK d2ZhRYNYGHxIcFCusFeRPJXtjEnybkIYxxUOxr+4= Date: Wed, 28 Oct 2020 13:16:31 +0200 From: Mike Rapoport To: Geert Uytterhoeven Cc: Andrew Morton , Alexey Dobriyan , Catalin Marinas , Greg Ungerer , John Paul Adrian Glaubitz , Jonathan Corbet , Matt Turner , Meelis Roos , Michael Schmitz , Mike Rapoport , Russell King , Tony Luck , Vineet Gupta , Will Deacon , alpha , Linux ARM , "open list:DOCUMENTATION" , Linux FS Devel , "linux-ia64@vger.kernel.org" , Linux Kernel Mailing List , linux-m68k , Linux MM , arcml Subject: Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM Message-ID: <20201028111631.GF1428094@kernel.org> References: <20201027112955.14157-1-rppt@kernel.org> <20201027112955.14157-12-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Geert, On Wed, Oct 28, 2020 at 10:25:49AM +0100, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: > > From: Mike Rapoport > > > > The pg_data_t node structures and their initialization currently depends on > > !CONFIG_SINGLE_MEMORY_CHUNK. Since they are required only for DISCONTIGMEM > > make this dependency explicit and replace usage of > > CONFIG_SINGLE_MEMORY_CHUNK with CONFIG_DISCONTIGMEM where appropriate. > > > > The CONFIG_SINGLE_MEMORY_CHUNK was implicitly disabled on the ColdFire MMU > > variant, although it always presumed a single memory bank. As there is no > > actual need for DISCONTIGMEM in this case, make sure that ColdFire MMU > > systems set CONFIG_SINGLE_MEMORY_CHUNK to 'y'. > > > > Signed-off-by: Mike Rapoport > > Thanks for your patch! > > > --- > > arch/m68k/Kconfig.cpu | 6 +++--- > > arch/m68k/include/asm/page_mm.h | 2 +- > > arch/m68k/mm/init.c | 4 ++-- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > Is there any specific reason you didn't convert the checks for > CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c In arch/m68k/kernel/setup_mm.c the CONFIG_SINGLE_MEMORY_CHUNK is needed for the case when a system has two banks, the kernel is loaded into the second bank and so the first bank cannot be used as normal memory. It does not matter what memory model will be used in this case. > and arch/m68k/include/asm/virtconvert.h? I remember I had build errors and troubles with include file dependencies if I changed it there, but I might be mistaken. I'll recheck again. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Wed, 28 Oct 2020 11:16:31 +0000 Subject: Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM Message-Id: <20201028111631.GF1428094@kernel.org> List-Id: References: <20201027112955.14157-1-rppt@kernel.org> <20201027112955.14157-12-rppt@kernel.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Andrew Morton , Alexey Dobriyan , Catalin Marinas , Greg Ungerer , John Paul Adrian Glaubitz , Jonathan Corbet , Matt Turner , Meelis Roos , Michael Schmitz , Mike Rapoport , Russell King , Tony Luck , Vineet Gupta , Will Deacon , alpha , Linux ARM , "open list:DOCUMENTATION" , Linux FS Devel , "linux-ia64@vger.kernel.org" , Linux Kernel Mailing List , linux-m68k , Linux MM , arcml Hi Geert, On Wed, Oct 28, 2020 at 10:25:49AM +0100, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: > > From: Mike Rapoport > > > > The pg_data_t node structures and their initialization currently depends on > > !CONFIG_SINGLE_MEMORY_CHUNK. Since they are required only for DISCONTIGMEM > > make this dependency explicit and replace usage of > > CONFIG_SINGLE_MEMORY_CHUNK with CONFIG_DISCONTIGMEM where appropriate. > > > > The CONFIG_SINGLE_MEMORY_CHUNK was implicitly disabled on the ColdFire MMU > > variant, although it always presumed a single memory bank. As there is no > > actual need for DISCONTIGMEM in this case, make sure that ColdFire MMU > > systems set CONFIG_SINGLE_MEMORY_CHUNK to 'y'. > > > > Signed-off-by: Mike Rapoport > > Thanks for your patch! > > > --- > > arch/m68k/Kconfig.cpu | 6 +++--- > > arch/m68k/include/asm/page_mm.h | 2 +- > > arch/m68k/mm/init.c | 4 ++-- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > Is there any specific reason you didn't convert the checks for > CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c In arch/m68k/kernel/setup_mm.c the CONFIG_SINGLE_MEMORY_CHUNK is needed for the case when a system has two banks, the kernel is loaded into the second bank and so the first bank cannot be used as normal memory. It does not matter what memory model will be used in this case. > and arch/m68k/include/asm/virtconvert.h? I remember I had build errors and troubles with include file dependencies if I changed it there, but I might be mistaken. I'll recheck again. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24C9C388F7 for ; Wed, 28 Oct 2020 11:16:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 070F6246B4 for ; Wed, 28 Oct 2020 11:16:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lzjfjFL6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nNqIykwP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 070F6246B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wuGbXhKudDaJsrbb5OfyzfFf9Uv6qBhp4UQVjNFlwYE=; b=lzjfjFL62mkAsGJmnfWh4VYgv Cx56M3qYKLSRGwVLKLBJpdpi/Jxds1pmb+dLoR39S1667uDdq+0GDcyyyV3QzweGfzfP86dmx6qxv 4Fwyw7lz3I5lZEzhzNMr8K7YXoVEurWlICIMZ95caASuSaOnAveolhMmYRHAqfkriiqx1jafv5tt4 6zWhVLsp/4Q8nlsSURo2WNwFS9XsWqIHUVklIw10yopH+NRNoUAk/0OoJPMRVvZffoO54tfGg0nOh I5x5/ubWvjFvztqPfiHX7NMKZoZr6YosBuYhWKmPsuxm0T3qfpr9xYvEBUm/L2KX0ayE6pRz+5QYb EIQlSIiEw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXjRi-0005uZ-Os; Wed, 28 Oct 2020 11:16:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXjRc-0005sU-FN; Wed, 28 Oct 2020 11:16:45 +0000 Received: from kernel.org (unknown [87.70.96.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7666B246B2; Wed, 28 Oct 2020 11:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603883801; bh=3DtSsbNWZaTf7v/7udK+AIDJ92sxyETNXeC2IzpbaLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nNqIykwPXzPeiPb6AYNYHQQXiJyXiYtwLr73B//voWR8TZa6Eb5++4CieyFXxEh1h 1/1jSd7uHggtcYYQ6K5jPMWeaE8D3Si3dAD3bEDewru+HlpqXxaIyeUj0n/GkzF1sK d2ZhRYNYGHxIcFCusFeRPJXtjEnybkIYxxUOxr+4= Date: Wed, 28 Oct 2020 13:16:31 +0200 From: Mike Rapoport To: Geert Uytterhoeven Subject: Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM Message-ID: <20201028111631.GF1428094@kernel.org> References: <20201027112955.14157-1-rppt@kernel.org> <20201027112955.14157-12-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_071644_753443_BB3AC1C2 X-CRM114-Status: GOOD ( 29.29 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , "open list:DOCUMENTATION" , Catalin Marinas , Linux MM , Will Deacon , Greg Ungerer , Jonathan Corbet , Meelis Roos , Russell King , Mike Rapoport , Matt Turner , arcml , Alexey Dobriyan , linux-m68k , John Paul Adrian Glaubitz , Linux ARM , Michael Schmitz , Tony Luck , Vineet Gupta , Linux Kernel Mailing List , alpha , Linux FS Devel , Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org Hi Geert, On Wed, Oct 28, 2020 at 10:25:49AM +0100, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: > > From: Mike Rapoport > > > > The pg_data_t node structures and their initialization currently depends on > > !CONFIG_SINGLE_MEMORY_CHUNK. Since they are required only for DISCONTIGMEM > > make this dependency explicit and replace usage of > > CONFIG_SINGLE_MEMORY_CHUNK with CONFIG_DISCONTIGMEM where appropriate. > > > > The CONFIG_SINGLE_MEMORY_CHUNK was implicitly disabled on the ColdFire MMU > > variant, although it always presumed a single memory bank. As there is no > > actual need for DISCONTIGMEM in this case, make sure that ColdFire MMU > > systems set CONFIG_SINGLE_MEMORY_CHUNK to 'y'. > > > > Signed-off-by: Mike Rapoport > > Thanks for your patch! > > > --- > > arch/m68k/Kconfig.cpu | 6 +++--- > > arch/m68k/include/asm/page_mm.h | 2 +- > > arch/m68k/mm/init.c | 4 ++-- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > Is there any specific reason you didn't convert the checks for > CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c In arch/m68k/kernel/setup_mm.c the CONFIG_SINGLE_MEMORY_CHUNK is needed for the case when a system has two banks, the kernel is loaded into the second bank and so the first bank cannot be used as normal memory. It does not matter what memory model will be used in this case. > and arch/m68k/include/asm/virtconvert.h? I remember I had build errors and troubles with include file dependencies if I changed it there, but I might be mistaken. I'll recheck again. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6322EC4363A for ; Wed, 28 Oct 2020 11:17:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA665246B4 for ; Wed, 28 Oct 2020 11:17:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AEjIEZSG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nNqIykwP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA665246B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6whDlm42N3pELagMmdULzK2aTuiW2rxkqhHMxZjugg8=; b=AEjIEZSGRXvppWxnzwx4aKnro qV6tvZGHfstMKDMjFQTQroCUybLvGKdVWOsA80cWPS9w3vKjF/R9p1I9MyCIcvEdfWm0TKbO6aPqm szynrlDWstLZlOSefkWBY5gvtCC3XROu4262vRrtckMjVNfCr3m9DIDWFQcOCi051/dO6IaIMQM98 3NBx4hj8jGSTVwoMFNw5QMhK1QjmvfS73AGdFgSj7WavuvT7wfxufAzdJfcgsG4Q65UCFeEUqCtY8 fJBFFOtWHhP0j0YE/RCfeIr6xhkefgaVilG4K4CS12Eleq9+encjlnlbi//vOrstN96lJ/tXqxqdo Z/lQph6aQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXjRg-0005u3-IK; Wed, 28 Oct 2020 11:16:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXjRc-0005sU-FN; Wed, 28 Oct 2020 11:16:45 +0000 Received: from kernel.org (unknown [87.70.96.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7666B246B2; Wed, 28 Oct 2020 11:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603883801; bh=3DtSsbNWZaTf7v/7udK+AIDJ92sxyETNXeC2IzpbaLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nNqIykwPXzPeiPb6AYNYHQQXiJyXiYtwLr73B//voWR8TZa6Eb5++4CieyFXxEh1h 1/1jSd7uHggtcYYQ6K5jPMWeaE8D3Si3dAD3bEDewru+HlpqXxaIyeUj0n/GkzF1sK d2ZhRYNYGHxIcFCusFeRPJXtjEnybkIYxxUOxr+4= Date: Wed, 28 Oct 2020 13:16:31 +0200 From: Mike Rapoport To: Geert Uytterhoeven Subject: Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM Message-ID: <20201028111631.GF1428094@kernel.org> References: <20201027112955.14157-1-rppt@kernel.org> <20201027112955.14157-12-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_071644_753443_BB3AC1C2 X-CRM114-Status: GOOD ( 29.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , "open list:DOCUMENTATION" , Catalin Marinas , Linux MM , Will Deacon , Greg Ungerer , Jonathan Corbet , Meelis Roos , Russell King , Mike Rapoport , Matt Turner , arcml , Alexey Dobriyan , linux-m68k , John Paul Adrian Glaubitz , Linux ARM , Michael Schmitz , Tony Luck , Vineet Gupta , Linux Kernel Mailing List , alpha , Linux FS Devel , Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, On Wed, Oct 28, 2020 at 10:25:49AM +0100, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: > > From: Mike Rapoport > > > > The pg_data_t node structures and their initialization currently depends on > > !CONFIG_SINGLE_MEMORY_CHUNK. Since they are required only for DISCONTIGMEM > > make this dependency explicit and replace usage of > > CONFIG_SINGLE_MEMORY_CHUNK with CONFIG_DISCONTIGMEM where appropriate. > > > > The CONFIG_SINGLE_MEMORY_CHUNK was implicitly disabled on the ColdFire MMU > > variant, although it always presumed a single memory bank. As there is no > > actual need for DISCONTIGMEM in this case, make sure that ColdFire MMU > > systems set CONFIG_SINGLE_MEMORY_CHUNK to 'y'. > > > > Signed-off-by: Mike Rapoport > > Thanks for your patch! > > > --- > > arch/m68k/Kconfig.cpu | 6 +++--- > > arch/m68k/include/asm/page_mm.h | 2 +- > > arch/m68k/mm/init.c | 4 ++-- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > Is there any specific reason you didn't convert the checks for > CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c In arch/m68k/kernel/setup_mm.c the CONFIG_SINGLE_MEMORY_CHUNK is needed for the case when a system has two banks, the kernel is loaded into the second bank and so the first bank cannot be used as normal memory. It does not matter what memory model will be used in this case. > and arch/m68k/include/asm/virtconvert.h? I remember I had build errors and troubles with include file dependencies if I changed it there, but I might be mistaken. I'll recheck again. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel