From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07470C388F7 for ; Wed, 28 Oct 2020 14:24:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CB1E24770 for ; Wed, 28 Oct 2020 14:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WNqXSlJq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CB1E24770 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9S8u8vkg/kbjaNt5er8iMTCqjxrbABPuPbezG8ogIuU=; b=WNqXSlJqGBfUtsTXsnROw9IXu kE0oeQn1vD/hxWPLnt3bS9lOX9vbkEHWyE5uXtSpJdQ4+OHWjKA6XgLbuskeSupyKMywmBZB0/zj8 8OyiEdkhMNoQjxu0xAaWWHoVgefV+vaYzSfbD/737NlsN2CancgEjUoHRV2RhFSFhgm3LvAfFmMdl xj1h7A2pAcIwUbh5EmU10bygBerJQqqjMxbExb+/HNu9SPo/Qom2z853cp4/GNx2igel01KI/PsjS r1I6pZW1NQe6T2B7E8kyfab0MiO+v0n1g8kQlXOOHzQyRSnyZDREJoA6pbKosBsQhrC8aDSqXG3rc LyDgrTfKw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXmM4-00032n-Ey; Wed, 28 Oct 2020 14:23:12 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXmM0-00032L-Uv for linux-mtd@lists.infradead.org; Wed, 28 Oct 2020 14:23:10 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C3CD91BF20B; Wed, 28 Oct 2020 14:23:04 +0000 (UTC) Date: Wed, 28 Oct 2020 15:23:02 +0100 From: Miquel Raynal To: Praveenkumar I Subject: Re: [PATCH] mtd: rawnand: qcom: Fix DMA sync on FLASH_STATUS register read Message-ID: <20201028152302.2f830077@xps13> In-Reply-To: <24a781a3-488c-b638-1b92-0f279807446f@codeaurora.org> References: <1602230872-25616-1-git-send-email-ipkumar@codeaurora.org> <20201028110835.2f319c0a@xps13> <24a781a3-488c-b638-1b92-0f279807446f@codeaurora.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_102309_107257_F07678D0 X-CRM114-Status: GOOD ( 21.27 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kathirav@codeaurora.org, vigneshr@ti.com, richard@nod.at, linux-kernel@vger.kernel.org, stable@vger.kernel.org, peter.ujfalusi@ti.com, boris.brezillon@collabora.com, linux-mtd@lists.infradead.org, sivaprak@codeaurora.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpQcmF2ZWVua3VtYXIgSSA8aXBrdW1hckBjb2RlYXVyb3JhLm9yZz4gd3JvdGUgb24g V2VkLCAyOCBPY3QgMjAyMAoxOTo0ODozNCArMDUzMDoKCj4gSGkgTWlxdWVsLAo+IAo+IFBsZWFz ZSBmaW5kIHRoZSBpbmxpbmUgcmVwbHkuCj4gCj4gVGhhbmtzLAo+IFByYXZlZW5rdW1hciBJCj4g Cj4gCj4gT24gMTAvMjgvMjAyMCAzOjM4IFBNLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ID4gSGVs bG8sCj4gPgo+ID4gUHJhdmVlbmt1bWFyIEkgPGlwa3VtYXJAY29kZWF1cm9yYS5vcmc+IHdyb3Rl IG9uIEZyaSwgIDkgT2N0IDIwMjAKPiA+IDEzOjM3OjUyICswNTMwOgo+ID4gIAo+ID4+IEFmdGVy IGVhY2ggY29kZXdvcmQgTkFORF9GTEFTSF9TVEFUVVMgaXMgcmVhZCBmb3IgcG9zc2libGUgb3Bl cmF0aW9uYWwKPiA+PiBmYWlsdXJlcy4gQnV0IHRoZXJlIGlzIG5vIERNQSBzeW5jIGZvciBDUFUg b3BlcmF0aW9uIGJlZm9yZSByZWFkaW5nIGl0Cj4gPj4gYW5kIHRoaXMgbGVhZHMgdG8gaW5jb3Jy ZWN0IG9yIG9sZGVyIGNvcHkgb2YgRE1BIGJ1ZmZlciBpbiByZWdfcmVhZF9idWYuCj4gPj4KPiA+ PiBUaGlzIHBhdGNoIGFkZHMgdGhlIERNQSBzeW5jIG9uIHJlZ19yZWFkX2J1ZiBmb3IgQ1BVIGJl Zm9yZSByZWFkaW5nIGl0Lgo+ID4+Cj4gPj4gRml4ZXM6IDViYzM2YjJiZjZlMiAoIm10ZDogcmF3 bmFuZDogcWNvbTogY2hlY2sgZm9yIG9wZXJhdGlvbiBlcnJvcnMgaW4gY2FzZSBvZiByYXcgcmVh ZCIpICAKPiA+IEkgZ3Vlc3MgdGhpcyBkZXNlcnZlcyBhIHByb3BlciBDYzogc3RhYmxlIHRhZz8g IAo+ID4gICAgPj4gWWVzLiBJIHdpbGwgc2VuZCBhIFYyIFBhdGNoIHdpdGggc3RhYmxlIHRhZyBp biBDYyAgCgpUaGF0J3MgZmluZSBmb3IgdGhpcyBvbmUsIEknbGwgYWRkIGl0IG15c2VsZi4KCj4g Pj4gU2lnbmVkLW9mZi1ieTogUHJhdmVlbmt1bWFyIEkgPGlwa3VtYXJAY29kZWF1cm9yYS5vcmc+ ICAKPiA+IEkgdGhpbmsgeW91ciBmdWxsIG5hbWUgaXMgcmVxdWlyZWQgaW4gdGhlIFNvQiBsaW5l IChzaG91bGQgbWF0Y2ggdGhlCj4gPiBhdXRob3JzaGlwKS4gIAo+ID4gICAgID4+ICJQcmF2ZWVu a3VtYXIgSSIgaXMgbXkgZnVsbCBuYW1lIGFuZCBpdCBpcyBzYW1lIGFzIHRoZSBhdXRob3JzaGlw LiAgCgpPaywgc29ycnkgZm9yIHRoZSBjb25mdXNpb24uCgo+ID4gT3RoZXJ3aXNlIGxvb2tzIGdv b2QgdG8gbWUuCj4gPiAgCj4gPj4gLS0tCj4gPj4gICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9xY29t X25hbmRjLmMgfCAyICsrCj4gPj4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4g Pj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvcWNvbV9uYW5kYy5jIGIv ZHJpdmVycy9tdGQvbmFuZC9yYXcvcWNvbV9uYW5kYy5jCj4gPj4gaW5kZXggYmQ3YTcyNTE0Mjli Li41YmI4NWYxYmE4NGMgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvcWNv bV9uYW5kYy5jCj4gPj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvcWNvbV9uYW5kYy5jCj4g Pj4gQEAgLTE1NzAsNiArMTU3MCw4IEBAIHN0YXRpYyBpbnQgY2hlY2tfZmxhc2hfZXJyb3JzKHN0 cnVjdCBxY29tX25hbmRfaG9zdCAqaG9zdCwgaW50IGN3X2NudCkKPiA+PiAgIAlzdHJ1Y3QgcWNv bV9uYW5kX2NvbnRyb2xsZXIgKm5hbmRjID0gZ2V0X3Fjb21fbmFuZF9jb250cm9sbGVyKGNoaXAp Owo+ID4+ICAgCWludCBpOyAgCj4gPj4gICA+PiArCW5hbmRjX3JlYWRfYnVmZmVyX3N5bmMobmFu ZGMsIHRydWUpOyAgCj4gPj4gKwo+ID4+ICAgCWZvciAoaSA9IDA7IGkgPCBjd19jbnQ7IGkrKykg ewo+ID4+ICAgCQl1MzIgZmxhc2ggPSBsZTMyX3RvX2NwdShuYW5kYy0+cmVnX3JlYWRfYnVmW2ld KTsgIAo+ID4+ICAgPiBUaGFua3MsICAKPiA+IE1pcXXDqGwgIAo+IAoKQ2hlZXJzLApNaXF1w6hs CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A0BEC56202 for ; Wed, 28 Oct 2020 21:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F71C24680 for ; Wed, 28 Oct 2020 21:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727338AbgJ1VlW convert rfc822-to-8bit (ORCPT ); Wed, 28 Oct 2020 17:41:22 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:46390 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727270AbgJ1VlD (ORCPT ); Wed, 28 Oct 2020 17:41:03 -0400 Received: from relay8-d.mail.gandi.net (unknown [217.70.183.201]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 9964B3A5CD2; Wed, 28 Oct 2020 14:23:27 +0000 (UTC) X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C3CD91BF20B; Wed, 28 Oct 2020 14:23:04 +0000 (UTC) Date: Wed, 28 Oct 2020 15:23:02 +0100 From: Miquel Raynal To: Praveenkumar I Cc: richard@nod.at, vigneshr@ti.com, sivaprak@codeaurora.org, peter.ujfalusi@ti.com, boris.brezillon@collabora.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, kathirav@codeaurora.org Subject: Re: [PATCH] mtd: rawnand: qcom: Fix DMA sync on FLASH_STATUS register read Message-ID: <20201028152302.2f830077@xps13> In-Reply-To: <24a781a3-488c-b638-1b92-0f279807446f@codeaurora.org> References: <1602230872-25616-1-git-send-email-ipkumar@codeaurora.org> <20201028110835.2f319c0a@xps13> <24a781a3-488c-b638-1b92-0f279807446f@codeaurora.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Praveenkumar I wrote on Wed, 28 Oct 2020 19:48:34 +0530: > Hi Miquel, > > Please find the inline reply. > > Thanks, > Praveenkumar I > > > On 10/28/2020 3:38 PM, Miquel Raynal wrote: > > Hello, > > > > Praveenkumar I wrote on Fri, 9 Oct 2020 > > 13:37:52 +0530: > > > >> After each codeword NAND_FLASH_STATUS is read for possible operational > >> failures. But there is no DMA sync for CPU operation before reading it > >> and this leads to incorrect or older copy of DMA buffer in reg_read_buf. > >> > >> This patch adds the DMA sync on reg_read_buf for CPU before reading it. > >> > >> Fixes: 5bc36b2bf6e2 ("mtd: rawnand: qcom: check for operation errors in case of raw read") > > I guess this deserves a proper Cc: stable tag? > > >> Yes. I will send a V2 Patch with stable tag in Cc That's fine for this one, I'll add it myself. > >> Signed-off-by: Praveenkumar I > > I think your full name is required in the SoB line (should match the > > authorship). > > >> "Praveenkumar I" is my full name and it is same as the authorship. Ok, sorry for the confusion. > > Otherwise looks good to me. > > > >> --- > >> drivers/mtd/nand/raw/qcom_nandc.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c > >> index bd7a7251429b..5bb85f1ba84c 100644 > >> --- a/drivers/mtd/nand/raw/qcom_nandc.c > >> +++ b/drivers/mtd/nand/raw/qcom_nandc.c > >> @@ -1570,6 +1570,8 @@ static int check_flash_errors(struct qcom_nand_host *host, int cw_cnt) > >> struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip); > >> int i; > >> >> + nandc_read_buffer_sync(nandc, true); > >> + > >> for (i = 0; i < cw_cnt; i++) { > >> u32 flash = le32_to_cpu(nandc->reg_read_buf[i]); > >> > Thanks, > > Miquèl > Cheers, Miquèl