From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DAAC55179 for ; Wed, 28 Oct 2020 22:41:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C02A208FE for ; Wed, 28 Oct 2020 22:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603924872; bh=XIEK/YlIEkhPPCZ0rUMBwvX3G7nZ6I4b2SL5W2aFfRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=f6QEB3TSkv6Hc9ApSxmc3iseZHPmtP7ZlyE0q27TkbRbqMJl8uQzhf4Y9rfrEdiVL yNM+7V/hZmXHaVh0lj+AiG38+CbUjr2IavhElEcLy5c5387XW0El25s5C4O1wcl3uZ 98NMx9WLyX8n+kyixPgrO5jxa4JOBdpzMYuGsYUM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389013AbgJ1WkZ (ORCPT ); Wed, 28 Oct 2020 18:40:25 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:37475 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388994AbgJ1Wjr (ORCPT ); Wed, 28 Oct 2020 18:39:47 -0400 Received: by mail-ot1-f65.google.com with SMTP id m22so659757ots.4; Wed, 28 Oct 2020 15:39:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=o6EwXQBfcMS/8hppO1O8Dg2kVJUq26B2UJyAmaDjbzk=; b=sRd22aRNw6zB6w/gluvROBwovTKpgYdsfCTCx/XJI8t+aLYXKHUchELoq+O5iqicEx B3lmmug5j/oQmHOgyR+4/EAJjkhmfhdIMsHp/6Qi3oLmGBh0ojWzA3YKviFFAP1a04v/ 7rcLJC8RsnISJzeCghZWLhB6iAzqprh88lNEBiTyxQ2chWIZJgVP/zpT1eeDuZ70wxVQ PtqDbYH8RcPaka8eqeLXYF2b5q6k6q/KDgAlJa7nG5dZClgq8jO33lxe7JJmwdRG3wnr A+t4Rfe1J9ufjzfYulrUN6Af1R28k+a4OKB8df/QWV20Bgjgov+LG6Y7+nZGdt9cPqOU P5+g== X-Gm-Message-State: AOAM533DGIIz9S5G7j0mqgcBQf66m5C+K1SShYVUAgq+UgoRMcEWrQj8 1GVLhzFl7nEc44X3mom8m36PEMobvw== X-Google-Smtp-Source: ABdhPJwj/TyDdKmqYTN4xYvs7B9zlCOZD1OUjrbHekbCo/ATjXWibtj5dLIGJwVVW7gCH9am8fXsDQ== X-Received: by 2002:a4a:ea4b:: with SMTP id j11mr6145795ooe.56.1603898585153; Wed, 28 Oct 2020 08:23:05 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id c20sm2076568otm.49.2020.10.28.08.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 08:23:04 -0700 (PDT) Received: (nullmailer pid 4050074 invoked by uid 1000); Wed, 28 Oct 2020 15:23:03 -0000 Date: Wed, 28 Oct 2020 10:23:03 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Georgi Djakov , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property Message-ID: <20201028152303.GA4041470@bogus> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-5-digetx@gmail.com> <20201027085417.GD4244@kozik-lap> <54191034-dcb9-7cab-333b-5bb2553f0ed1@gmail.com> <20201027193039.GA140636@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201027193039.GA140636@kozik-lap> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Oct 27, 2020 at 08:30:39PM +0100, Krzysztof Kozlowski wrote: > On Tue, Oct 27, 2020 at 10:17:19PM +0300, Dmitry Osipenko wrote: > > 27.10.2020 11:54, Krzysztof Kozlowski пишет: > > > On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: > > >> Tegra20 External Memory Controller talks to DRAM chips and it needs to be > > >> reprogrammed when memory frequency changes. Tegra Memory Controller sits > > >> behind EMC and these controllers are tightly coupled. This patch adds the > > >> new phandle property which allows to properly express connection of EMC > > >> and MC hardware in a device-tree, it also put the Tegra20 EMC binding on > > >> par with Tegra30+ EMC bindings, which is handy to have. > > >> > > >> Signed-off-by: Dmitry Osipenko > > >> --- > > >> .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 ++ > > >> 1 file changed, 2 insertions(+) > > >> > > >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > > >> index 567cffd37f3f..1b0d4417aad8 100644 > > >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > > >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > > >> @@ -12,6 +12,7 @@ Properties: > > >> irrespective of ram-code configuration. > > >> - interrupts : Should contain EMC General interrupt. > > >> - clocks : Should contain EMC clock. > > >> +- nvidia,memory-controller : Phandle of the Memory Controller node. > > > > > > It looks like you adding a required property which is an ABI break. > > The T20 EMC driver is unused so far in upstream and it will become used > > only once this series is applied. Hence it's fine to change the ABI. > > The ABI is not about upstream, but downstream. "If it's not upstream, it doesn't exist." Though we do have to account for out of tree users where the DT is not in tree, but upstream drivers are used. Downstream as in vendor kernels typically has loads of other crap. > There are no other > upstreams using this ABI. Unless you have in mind that existing T20 EMC > driver was a noop, doing absolutely nothing, therefore there is no > breakage of any other users? ABI breaks are ultimately up to the platform maintainers to decide. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14468C388F7 for ; Wed, 28 Oct 2020 15:23:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4CEF247C3 for ; Wed, 28 Oct 2020 15:23:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4CEF247C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AD5D6E57E; Wed, 28 Oct 2020 15:23:09 +0000 (UTC) Received: from mail-oo1-f68.google.com (mail-oo1-f68.google.com [209.85.161.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AC1D6E58E for ; Wed, 28 Oct 2020 15:23:07 +0000 (UTC) Received: by mail-oo1-f68.google.com with SMTP id u5so1255441oot.0 for ; Wed, 28 Oct 2020 08:23:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=o6EwXQBfcMS/8hppO1O8Dg2kVJUq26B2UJyAmaDjbzk=; b=eIIvmliaHj7x2E1KM1F8FxqACpPDjhNeGq+Ub3EppKxmCVStO0uIWtVdfnhiOUl8vL PKicw+s/VFcOGqB9ANyQdyjDfvh9OccFvWDuZVDZD+3sgUvHq/XZ7lF3IafPaGIv9Zid trEwEXrimzlyAfiZ9DqXazJVknMcVR6SoRWnDoHzzQM3jD9CPmHG+dl2Njqnc+xbgbYj 2ZobFDtqEEHzTukmDKFtMebqvYPVcRNouR+XNx7LNeZfeHM4UXEXkhStRLFuaKlsnYvb oqf8+CGK6N5TAcJzg0COaegM3rqRs8E/WePe9ghhMPSlj5JluvepXclJMCGcYYCZHCvv alVg== X-Gm-Message-State: AOAM532RhR5AoroecKrX0gO+LOF7B0G0tE/10O055dcyQU9A+fl1bgpc N9RApLWMIRULlwOV8pGDDg== X-Google-Smtp-Source: ABdhPJwj/TyDdKmqYTN4xYvs7B9zlCOZD1OUjrbHekbCo/ATjXWibtj5dLIGJwVVW7gCH9am8fXsDQ== X-Received: by 2002:a4a:ea4b:: with SMTP id j11mr6145795ooe.56.1603898585153; Wed, 28 Oct 2020 08:23:05 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id c20sm2076568otm.49.2020.10.28.08.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 08:23:04 -0700 (PDT) Received: (nullmailer pid 4050074 invoked by uid 1000); Wed, 28 Oct 2020 15:23:03 -0000 Date: Wed, 28 Oct 2020 10:23:03 -0500 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property Message-ID: <20201028152303.GA4041470@bogus> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-5-digetx@gmail.com> <20201027085417.GD4244@kozik-lap> <54191034-dcb9-7cab-333b-5bb2553f0ed1@gmail.com> <20201027193039.GA140636@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201027193039.GA140636@kozik-lap> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Dmitry Osipenko , Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBPY3QgMjcsIDIwMjAgYXQgMDg6MzA6MzlQTSArMDEwMCwgS3J6eXN6dG9mIEtvemxv d3NraSB3cm90ZToKPiBPbiBUdWUsIE9jdCAyNywgMjAyMCBhdCAxMDoxNzoxOVBNICswMzAwLCBE bWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gPiAyNy4xMC4yMDIwIDExOjU0LCBLcnp5c3p0b2YgS296 bG93c2tpINC/0LjRiNC10YI6Cj4gPiA+IE9uIE1vbiwgT2N0IDI2LCAyMDIwIGF0IDAxOjE2OjQ3 QU0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+ID4+IFRlZ3JhMjAgRXh0ZXJuYWwg TWVtb3J5IENvbnRyb2xsZXIgdGFsa3MgdG8gRFJBTSBjaGlwcyBhbmQgaXQgbmVlZHMgdG8gYmUK PiA+ID4+IHJlcHJvZ3JhbW1lZCB3aGVuIG1lbW9yeSBmcmVxdWVuY3kgY2hhbmdlcy4gVGVncmEg TWVtb3J5IENvbnRyb2xsZXIgc2l0cwo+ID4gPj4gYmVoaW5kIEVNQyBhbmQgdGhlc2UgY29udHJv bGxlcnMgYXJlIHRpZ2h0bHkgY291cGxlZC4gVGhpcyBwYXRjaCBhZGRzIHRoZQo+ID4gPj4gbmV3 IHBoYW5kbGUgcHJvcGVydHkgd2hpY2ggYWxsb3dzIHRvIHByb3Blcmx5IGV4cHJlc3MgY29ubmVj dGlvbiBvZiBFTUMKPiA+ID4+IGFuZCBNQyBoYXJkd2FyZSBpbiBhIGRldmljZS10cmVlLCBpdCBh bHNvIHB1dCB0aGUgVGVncmEyMCBFTUMgYmluZGluZyBvbgo+ID4gPj4gcGFyIHdpdGggVGVncmEz MCsgRU1DIGJpbmRpbmdzLCB3aGljaCBpcyBoYW5keSB0byBoYXZlLgo+ID4gPj4KPiA+ID4+IFNp Z25lZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPiA+ID4+IC0t LQo+ID4gPj4gIC4uLi9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMjAt ZW1jLnR4dCAgICAgICAgICB8IDIgKysKPiA+ID4+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRp b25zKCspCj4gPiA+Pgo+ID4gPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMjAtZW1jLnR4dCBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlh LHRlZ3JhMjAtZW1jLnR4dAo+ID4gPj4gaW5kZXggNTY3Y2ZmZDM3ZjNmLi4xYjBkNDQxN2FhZDgg MTAwNjQ0Cj4gPiA+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVt b3J5LWNvbnRyb2xsZXJzL252aWRpYSx0ZWdyYTIwLWVtYy50eHQKPiA+ID4+ICsrKyBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRl Z3JhMjAtZW1jLnR4dAo+ID4gPj4gQEAgLTEyLDYgKzEyLDcgQEAgUHJvcGVydGllczoKPiA+ID4+ ICAgIGlycmVzcGVjdGl2ZSBvZiByYW0tY29kZSBjb25maWd1cmF0aW9uLgo+ID4gPj4gIC0gaW50 ZXJydXB0cyA6IFNob3VsZCBjb250YWluIEVNQyBHZW5lcmFsIGludGVycnVwdC4KPiA+ID4+ICAt IGNsb2NrcyA6IFNob3VsZCBjb250YWluIEVNQyBjbG9jay4KPiA+ID4+ICstIG52aWRpYSxtZW1v cnktY29udHJvbGxlciA6IFBoYW5kbGUgb2YgdGhlIE1lbW9yeSBDb250cm9sbGVyIG5vZGUuCj4g PiA+IAo+ID4gPiBJdCBsb29rcyBsaWtlIHlvdSBhZGRpbmcgYSByZXF1aXJlZCBwcm9wZXJ0eSB3 aGljaCBpcyBhbiBBQkkgYnJlYWsuCj4gPiBUaGUgVDIwIEVNQyBkcml2ZXIgaXMgdW51c2VkIHNv IGZhciBpbiB1cHN0cmVhbSBhbmQgaXQgd2lsbCBiZWNvbWUgdXNlZAo+ID4gb25seSBvbmNlIHRo aXMgc2VyaWVzIGlzIGFwcGxpZWQuIEhlbmNlIGl0J3MgZmluZSB0byBjaGFuZ2UgdGhlIEFCSS4K PiAKPiBUaGUgQUJJIGlzIG5vdCBhYm91dCB1cHN0cmVhbSwgYnV0IGRvd25zdHJlYW0uIAoKIklm IGl0J3Mgbm90IHVwc3RyZWFtLCBpdCBkb2Vzbid0IGV4aXN0LiIKClRob3VnaCB3ZSBkbyBoYXZl IHRvIGFjY291bnQgZm9yIG91dCBvZiB0cmVlIHVzZXJzIHdoZXJlIHRoZSBEVCBpcyBub3QgCmlu IHRyZWUsIGJ1dCB1cHN0cmVhbSBkcml2ZXJzIGFyZSB1c2VkLiBEb3duc3RyZWFtIGFzIGluIHZl bmRvciBrZXJuZWxzIAp0eXBpY2FsbHkgaGFzIGxvYWRzIG9mIG90aGVyIGNyYXAuCgo+IFRoZXJl IGFyZSBubyBvdGhlcgo+IHVwc3RyZWFtcyB1c2luZyB0aGlzIEFCSS4gVW5sZXNzIHlvdSBoYXZl IGluIG1pbmQgdGhhdCBleGlzdGluZyBUMjAgRU1DCj4gZHJpdmVyIHdhcyBhIG5vb3AsIGRvaW5n IGFic29sdXRlbHkgbm90aGluZywgdGhlcmVmb3JlIHRoZXJlIGlzIG5vCj4gYnJlYWthZ2Ugb2Yg YW55IG90aGVyIHVzZXJzPwoKQUJJIGJyZWFrcyBhcmUgdWx0aW1hdGVseSB1cCB0byB0aGUgcGxh dGZvcm0gbWFpbnRhaW5lcnMgdG8gZGVjaWRlLgoKUm9iCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=