All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: <sagi@grimberg.me>, <krishna2@chelsio.com>,
	<linux-rdma@vger.kernel.org>, <dledford@redhat.com>,
	<oren@nvidia.com>, <maxg@mellanox.com>
Subject: Re: [PATCH v2 1/1] IB/isert: add module param to set sg_tablesize for IO cmd
Date: Wed, 28 Oct 2020 13:12:54 -0300	[thread overview]
Message-ID: <20201028161254.GA2437800@nvidia.com> (raw)
In-Reply-To: <20201019094628.17202-1-mgurtovoy@nvidia.com>

On Mon, Oct 19, 2020 at 12:46:28PM +0300, Max Gurtovoy wrote:
> Currently, iser target support max IO size of 16MiB by default. For some
> adapters, allocating this amount of resources might reduce the total
> number of possible connections that can be created. For those adapters,
> it's preferred to reduce the max IO size to be able to create more
> connections. Since there is no handshake procedure for max IO size in
> iser protocol, set the default max IO size to 1MiB and add a module
> parameter for enabling the option to control it for suitable adapters.
> 
> Fixes: 317000b926b0 ("IB/isert: allocate RW ctxs according to max IO size")
> Reported-by: Krishnamraju Eraparaju <krishna2@chelsio.com>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> 
> changes from v1:
>  - added "Fixes" line (Sagi)
>  - renamed ISCSI_ISER_SG_TABLESIZE to ISCSI_ISER_DEF_SG_TABLESIZE (Sagi)
>  - added "Reviewed-by" signature
> 
> ---
>  drivers/infiniband/ulp/isert/ib_isert.c | 27 ++++++++++++++++++++++++-
>  drivers/infiniband/ulp/isert/ib_isert.h |  6 ++++++
>  2 files changed, 32 insertions(+), 1 deletion(-)

Applied to for-next, thanks

Jason

      reply	other threads:[~2020-10-28 22:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19  9:46 [PATCH v2 1/1] IB/isert: add module param to set sg_tablesize for IO cmd Max Gurtovoy
2020-10-28 16:12 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201028161254.GA2437800@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=dledford@redhat.com \
    --cc=krishna2@chelsio.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maxg@mellanox.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=oren@nvidia.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.