From: Pavel Machek <pavel@ucw.cz>
To: Jiri Kosina <jikos@kernel.org>
Cc: dmitry.torokhov@gmail.com, vojtech@suse.cz,
linux-input@vger.kernel.org,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Proper support for Saitek X36F joystick
Date: Wed, 28 Oct 2020 17:26:21 +0100 [thread overview]
Message-ID: <20201028162621.GA18184@amd> (raw)
In-Reply-To: <20201027210732.GA4479@amd>
[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]
Hi!
> > > This is from 4.19, but I doubt this changed recently.
> > >
> > > Saitek X36F+X35T combination is detected like this... in short one
> > > hat, no switches, and lot of buttons.
> > >
> > > In reality, combination has 4 four-way switches (hats?), 2 slider
> > > switches (three positions) and lot less buttons. Sliders and 3 of 4
> > > hats are detected as groups of buttons. Last hat is strange, I can't
> > > see anything that corresponds to it on evtest, and as long as it is
> > > pushed in any direction, all the other events stop. (It is also one
> > > I'd like to use).
> > >
> > > What needs to be done to get more useful mapping for userspace?
> >
> > It wouldn't be the first device produced by Saitek that has completely
> > bogus report descriptor.
> >
> > The most straightforward way would be to let hid-saitek module claim the
> > device, and fix the report descriptor (saitek_report_fixup()) before it's
> > passed to hid parser so that it actually describes the events produced.
> >
> > You can either patch individual bytes (that's what saitek_report_fixup()
> > is currently doing for another device), or replace the whole descriptor
> > completely (see e.g. hid-kye for inspiration how this is done).
>
> Thank you... replacing whole descriptors is rather easy.
>
> Coming up with descriptors that works ... not so :-(. I can replace
> descriptor with equivalent one, but things get horribly confused as
> soon as I really try to change anything.
So no, I can't even replace it with equivalent one. Perhaps hrdc got
decompilation wrong, or I'm doing something else wrong.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-10-28 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 12:42 Proper support for Saitek X36F joystick Pavel Machek
2020-10-27 19:10 ` Jiri Kosina
2020-10-27 21:07 ` Pavel Machek
2020-10-28 16:26 ` Pavel Machek [this message]
2020-10-28 16:29 ` Jiri Kosina
2020-10-28 17:32 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028162621.GA18184@amd \
--to=pavel@ucw.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.