From: "Denys Dmytriyenko" <denys@ti.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: Gowtham Tammana <g-tammana@ti.com>, <meta-ti@yoctoproject.org>
Subject: Re: [meta-ti][dunfell/master][PATCH v2] ti-img-rogue-driver: pull general toolchain support
Date: Wed, 28 Oct 2020 13:59:39 -0400 [thread overview]
Message-ID: <20201028175939.GZ19741@beryl> (raw)
In-Reply-To: <562ed28b-b53a-c87f-3c8e-359aa8adbfa4@ti.com>
On Wed, Oct 28, 2020 at 12:54:02PM -0500, Dan Murphy wrote:
> Gowtham
>
> On 10/28/20 12:36 PM, Gowtham Tammana wrote:
> >The patch for supporting the general toolchain is pulled into the repo.
> >Removing it here from the recipe.
> >
> >Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> >---
> >v2: fix email in signoff
> >
> > .../0001-km-support-general-toolchain.patch | 56 -------------------
>
> Did you use "git rm" to remove the file? This looks weird that the file
> changed then got deleted
>
> Generally we should just see
>
> delete mode 100644 recipes-bsp/powervr-drivers/ti-img-rogue-driver/0001-km-support-general-toolchain.patch
Seems fine to me - 56 lines removed.
The other change is for the recipe to remove the extra patch from SRC_URI...
--
Denys
next prev parent reply other threads:[~2020-10-28 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 17:36 [meta-ti][dunfell/master][PATCH v2] ti-img-rogue-driver: pull general toolchain support Gowtham Tammana
2020-10-28 17:54 ` Dan Murphy
2020-10-28 17:59 ` Denys Dmytriyenko [this message]
2020-10-28 18:02 ` Gowtham Tammana
2020-10-28 18:05 ` Dan Murphy
2020-10-28 18:07 ` Gowtham Tammana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028175939.GZ19741@beryl \
--to=denys@ti.com \
--cc=dmurphy@ti.com \
--cc=g-tammana@ti.com \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.