From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4FEC4363A for ; Wed, 28 Oct 2020 22:09:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E24732474F for ; Wed, 28 Oct 2020 22:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603922974; bh=Mn006CKi7+bFI8aRSWwvXjzvohwC3AzTprOAI+qvE4o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qnTHawihAsjW1KwNtGggFBkxOf6sa0bZ+aB7V5SyUR/Ya28XCWPKZVyYJArYM0Kzw FjARgGuI7Qb4Sothv10ZPqSmF6PUoZ42Gec7jsgpSVvPEz3dYQkVn+GifUJi8oPpOt Of9p7Q3x85Pg8rK2O6BD7LFANHiKI3KknvNUp8ws= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730334AbgJ1WJc convert rfc822-to-8bit (ORCPT ); Wed, 28 Oct 2020 18:09:32 -0400 Received: from mail-lf1-f50.google.com ([209.85.167.50]:32804 "EHLO mail-lf1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728604AbgJ1WJ3 (ORCPT ); Wed, 28 Oct 2020 18:09:29 -0400 Received: by mail-lf1-f50.google.com with SMTP id l2so814986lfk.0; Wed, 28 Oct 2020 15:09:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vP95c5G5AiWt8jFAMoFHGwxXSql0kCQrJ9xpkPgq6gg=; b=HUEdEcL9oWOFN5GZBxdIaZuS75HZc1SpYh+XPYjnnLFtT7U0bcCPzpa2vlhwDxDdgk yvYmhzdZIGzCPDQKugnJKn3R6erxAIXZYB6L5asjmhG+CNN3o8TOjW+DK110SCBYvO94 Thd+bpYWL74XjThcUosC0busfnRzkPQC+MmY97PSEALfA758uf2gLrKzegXjCSZbvZKL NI2/QBv5TVO2dB3fn0j8dZuoTkBLj5rE1VI1e3Kf6UDmj3dBUyhbM8JfOl3jY7YWVotv SI9tuug6nOZPt+NM8OhLG6cVNwMHV452ldJaNOcksWdHTvSwVTS1VZInkVyrTQI8AkIy P2Gg== X-Gm-Message-State: AOAM5334bepW508TC6pThlk8737l4d4hm0IKTe5aplq3YlflMwF8IDXg FOMUWXzU1pDtlsM3JnuAXfN8th22ngJeOQ== X-Google-Smtp-Source: ABdhPJyHdwuuiwRcW53qYzu6ELBzFaASak8bZZ7cUJm7qaJ+2lCiPhJEUbxJ3cDKZqX83Q9tfRG3aQ== X-Received: by 2002:a05:6402:134c:: with SMTP id y12mr460552edw.344.1603913305471; Wed, 28 Oct 2020 12:28:25 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id p1sm261722ejd.33.2020.10.28.12.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 12:28:23 -0700 (PDT) Date: Wed, 28 Oct 2020 20:28:21 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 41/52] memory: tegra124-emc: Use devm_platform_ioremap_resource() Message-ID: <20201028192821.GB170285@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-42-digetx@gmail.com> <20201027102707.GC17089@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Oct 27, 2020 at 11:30:31PM +0300, Dmitry Osipenko wrote: > 27.10.2020 13:27, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:17:24AM +0300, Dmitry Osipenko wrote: > >> Use devm_platform_ioremap_resource() helper which makes code a bit > >> cleaner. > > > > Such cleanups (and few other in this patchset) should be at beginning of > > patchset or even as part of a separate one. I think there is not much > > stopping anyone from applying these... except that you put them in the > > middle of big dependency. > > Some of these cleanup patches can't be applied separately without a need > to make a rebase. I think it should be more preferred to have all the > patches within a single series. > > I'll try to reorder the patches in v7 if this will ease the review, thanks. If feasible, that would be good. Thanks. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E0DC4363A for ; Wed, 28 Oct 2020 19:28:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4874F247FE for ; Wed, 28 Oct 2020 19:28:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4874F247FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AC9D6E323; Wed, 28 Oct 2020 19:28:28 +0000 (UTC) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id D64406E323 for ; Wed, 28 Oct 2020 19:28:26 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id x1so703098eds.1 for ; Wed, 28 Oct 2020 12:28:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vP95c5G5AiWt8jFAMoFHGwxXSql0kCQrJ9xpkPgq6gg=; b=Q/87pBiI4fpZqtIU5Q3RaA7rlBe+NAEt8rKRTvJmOfKNis0D7iiHdJiuaE6HSrPb5S fLQqr+AoEdk8rb4rBnPQnR9/61WzRRZH+wB/rmHXHghfx+UZO2VwsUOmuqtkMU6W1Bpo +Z3o+o8qPbFO+ExTeF6bGFMMhANBCHs0wAdqTCYhdtwXEfTQ3X+CUWGiJvyPDMZfsgwj xejl28XY4WGF7rZqSbxo3JhJTwqb9fGtVYM5fUmjpQdATL98+p/On5VgdnRMxNSJEv2C oXbFGU+lZMubxsOeh2bEEvS9TodJjJtZSzv1rIgMapPlXNfSGEfqcP4WZV3Ax8W9srDq kU4w== X-Gm-Message-State: AOAM53233msnryRi/pGy5n9Rh9lpuXztyYVATMeMKXqi1PdJ8hc4We7u HEXS0iCDrusKhb64xIFiohw= X-Google-Smtp-Source: ABdhPJyHdwuuiwRcW53qYzu6ELBzFaASak8bZZ7cUJm7qaJ+2lCiPhJEUbxJ3cDKZqX83Q9tfRG3aQ== X-Received: by 2002:a05:6402:134c:: with SMTP id y12mr460552edw.344.1603913305471; Wed, 28 Oct 2020 12:28:25 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id p1sm261722ejd.33.2020.10.28.12.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 12:28:23 -0700 (PDT) Date: Wed, 28 Oct 2020 20:28:21 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 41/52] memory: tegra124-emc: Use devm_platform_ioremap_resource() Message-ID: <20201028192821.GB170285@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-42-digetx@gmail.com> <20201027102707.GC17089@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBPY3QgMjcsIDIwMjAgYXQgMTE6MzA6MzFQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI3LjEwLjIwMjAgMTM6MjcsIEtyenlzenRvZiBLb3psb3dza2kg0L/QuNGI0LXR gjoKPiA+IE9uIE1vbiwgT2N0IDI2LCAyMDIwIGF0IDAxOjE3OjI0QU0gKzAzMDAsIERtaXRyeSBP c2lwZW5rbyB3cm90ZToKPiA+PiBVc2UgZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKCkg aGVscGVyIHdoaWNoIG1ha2VzIGNvZGUgYSBiaXQKPiA+PiBjbGVhbmVyLgo+ID4gCj4gPiBTdWNo IGNsZWFudXBzIChhbmQgZmV3IG90aGVyIGluIHRoaXMgcGF0Y2hzZXQpIHNob3VsZCBiZSBhdCBi ZWdpbm5pbmcgb2YKPiA+IHBhdGNoc2V0IG9yIGV2ZW4gYXMgcGFydCBvZiBhIHNlcGFyYXRlIG9u ZS4gIEkgdGhpbmsgdGhlcmUgaXMgbm90IG11Y2gKPiA+IHN0b3BwaW5nIGFueW9uZSBmcm9tIGFw cGx5aW5nIHRoZXNlLi4uIGV4Y2VwdCB0aGF0IHlvdSBwdXQgdGhlbSBpbiB0aGUKPiA+IG1pZGRs ZSBvZiBiaWcgZGVwZW5kZW5jeS4KPiAKPiBTb21lIG9mIHRoZXNlIGNsZWFudXAgcGF0Y2hlcyBj YW4ndCBiZSBhcHBsaWVkIHNlcGFyYXRlbHkgd2l0aG91dCBhIG5lZWQKPiB0byBtYWtlIGEgcmVi YXNlLiBJIHRoaW5rIGl0IHNob3VsZCBiZSBtb3JlIHByZWZlcnJlZCB0byBoYXZlIGFsbCB0aGUK PiBwYXRjaGVzIHdpdGhpbiBhIHNpbmdsZSBzZXJpZXMuCj4gCj4gSSdsbCB0cnkgdG8gcmVvcmRl ciB0aGUgcGF0Y2hlcyBpbiB2NyBpZiB0aGlzIHdpbGwgZWFzZSB0aGUgcmV2aWV3LCB0aGFua3Mu CgpJZiBmZWFzaWJsZSwgdGhhdCB3b3VsZCBiZSBnb29kLiBUaGFua3MuCgpCZXN0IHJlZ2FyZHMs CktyenlzenRvZgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==