From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Felipe Balbi <balbi@kernel.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCHv2 1/3] software node: Power management operations for software nodes
Date: Thu, 29 Oct 2020 14:17:51 +0200 [thread overview]
Message-ID: <20201029121751.GK4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201029115113.GA2288851@kuha.fi.intel.com>
On Thu, Oct 29, 2020 at 01:51:13PM +0200, Heikki Krogerus wrote:
> On Thu, Oct 29, 2020 at 01:13:03PM +0200, Sakari Ailus wrote:
> > These functions are doing pretty much the same thing but with different
> > parameters. How about implementing a macro or a few, which would take all
> > the parameters as arguments and return the function to call? A few variants
> > may be needed. Individual functions performing different tasks would become
> > very simple.
>
> I would prefer to do that as the second step, if you guys don't mind.
> I think this was already talked about, but maybe only internally.
> Those macros should then be used also in other places where the same
> steps are being executed, for example in drivers/base/power/domain.c.
I agree.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-29 12:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 10:59 [PATCHv2 0/3] PM operations for software nodes Heikki Krogerus
2020-10-29 10:59 ` [PATCHv2 1/3] software node: Power management " Heikki Krogerus
2020-10-29 11:13 ` Sakari Ailus
2020-10-29 11:51 ` Heikki Krogerus
2020-10-29 12:17 ` Andy Shevchenko [this message]
2020-10-29 13:01 ` Sakari Ailus
2020-10-29 17:10 ` Rafael J. Wysocki
2020-10-30 10:27 ` Heikki Krogerus
2022-03-25 16:42 ` Lukas Wunner
2022-03-28 8:15 ` Heikki Krogerus
2020-10-29 10:59 ` [PATCHv2 2/3] software node: Introduce device_add_software_node() Heikki Krogerus
2020-10-29 10:59 ` [PATCHv2 3/3] usb: dwc3: pci: Register a software node for the dwc3 platform device Heikki Krogerus
2020-10-29 12:18 ` [PATCHv2 0/3] PM operations for software nodes Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029121751.GK4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.