From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 4/5] net: phy: marvell10g: change MACTYPE if underlying MAC does not support it
Date: Thu, 29 Oct 2020 13:21:57 +0000 [thread overview]
Message-ID: <20201029132157.GT1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201028221427.22968-5-kabel@kernel.org>
On Wed, Oct 28, 2020 at 11:14:26PM +0100, Marek Behún wrote:
> RollBall SFPs contain a Marvell 88X3310 PHY, but by default the MACTYPE
> is set to 10GBASE-R with Rate Matching.
>
> Some devices (for example those based on Armada 38x) only support up to
> 2500base-x SerDes modes.
>
> Change the PHY's MACTYPE to 4 (which means changing between 10gbase-r,
> 5gbase-r, 2500base-x ans SGMII depending on copper speed) if this is the
> case (which is infered from phydev->interface).
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Russell King <rmk+kernel@armlinux.org.uk>
This'll do as a stop-gap until we have a better way to determine which
MACTYPE mode we should be using.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-10-29 13:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 22:14 [PATCH net-next 0/5] Support for RollBall 10G copper SFP modules Marek Behún
2020-10-28 22:14 ` [PATCH net-next 1/5] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall " Marek Behún
2020-10-29 12:41 ` Russell King - ARM Linux admin
2020-10-29 12:54 ` Andrew Lunn
2020-10-29 13:41 ` Russell King - ARM Linux admin
2020-10-29 22:53 ` Jakub Kicinski
2020-10-29 22:55 ` Marek Behún
2020-10-29 16:46 ` Marek Behún
2020-10-28 22:14 ` [PATCH net-next 2/5] net: phylink: allow attaching phy for SFP modules on 802.3z mode Marek Behún
2020-10-29 12:08 ` Russell King - ARM Linux admin
2020-10-28 22:14 ` [PATCH net-next 3/5] net: sfp: configure/destroy I2C mdiobus on transceiver plug/unplug Marek Behún
2020-10-29 13:21 ` Russell King - ARM Linux admin
2020-10-28 22:14 ` [PATCH net-next 4/5] net: phy: marvell10g: change MACTYPE if underlying MAC does not support it Marek Behún
2020-10-29 13:21 ` Russell King - ARM Linux admin [this message]
2020-10-28 22:14 ` [PATCH net-next 5/5] net: sfp: add support for multigig RollBall transceivers Marek Behún
2020-10-29 13:38 ` Russell King - ARM Linux admin
2020-10-29 16:49 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029132157.GT1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.