From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696EAC4363A for ; Thu, 29 Oct 2020 13:55:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F06062076A for ; Thu, 29 Oct 2020 13:55:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F06062076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E87FC6E8B3; Thu, 29 Oct 2020 13:55:41 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A44C6E8B3 for ; Thu, 29 Oct 2020 13:55:41 +0000 (UTC) IronPort-SDR: riKGOzQjMcu3CL2/HBNNM72ZyNeOfU6iH2UD5Dmme9QT002Sknh9wSC2o5i4FOnPZdoIjijKzV HX9a+HuE4WQA== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="147715012" X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="147715012" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 06:55:40 -0700 IronPort-SDR: Du3X9t6xagkPsN2/Sv5B+bivqyTTsCAT/vWsvdJNaQKJcrlFFNdLoVsoajmAGWIkci9JyN/rvt kne/E2suFL5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="350972042" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga008.jf.intel.com with SMTP; 29 Oct 2020 06:55:37 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 29 Oct 2020 15:55:37 +0200 Date: Thu, 29 Oct 2020 15:55:37 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH 2/2] drm/atomic: Pass the full state to CRTC atomic begin and flush Message-ID: <20201029135537.GB6112@intel.com> References: <20201028123222.1732139-1-maxime@cerno.tech> <20201028123222.1732139-2-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201028123222.1732139-2-maxime@cerno.tech> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Thomas Zimmermann Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 28, 2020 at 01:32:22PM +0100, Maxime Ripard wrote: > The current atomic helpers have either their object state being passed as > an argument or the full atomic state. > = > The former is the pattern that was done at first, before switching to the > latter for new hooks or when it was needed. > = > Let's start convert all the remaining helpers to provide a consistent > interface, starting with the CRTC's atomic_begin and atomic_flush. > = > The conversion was done using the coccinelle script below, built tested on > all the drivers and actually tested on vc4. > = > @@ -323,26 +323,27 @@ static void ingenic_drm_crtc_atomic_begin(struct dr= m_crtc *crtc, > } > = > static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc, > - struct drm_crtc_state *oldstate) > + struct drm_atomic_state *state) > { > struct ingenic_drm *priv =3D drm_crtc_get_priv(crtc); > - struct drm_crtc_state *state =3D crtc->state; > - struct drm_pending_vblank_event *event =3D state->event; > + struct drm_crtc_state *crtc_state =3D crtc->state; Looks like quite a few places could use a followup to switch to get_{old,new}_crtc_state(). Patch lgtm Reviewed-by: Ville Syrj=E4l=E4 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel