From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Greg Kurz <groug@kaod.org>
Subject: Re: [PULL 00/13] 9p queue 2020-10-23
Date: Thu, 29 Oct 2020 15:04:03 +0000 [thread overview]
Message-ID: <20201029150403.GF27369@redhat.com> (raw)
In-Reply-To: <CAFEAcA9KYtb7tFp5tnPGMiYg0gpurao7GbcU_ND934tvFiU-aw@mail.gmail.com>
On Thu, Oct 29, 2020 at 02:52:16PM +0000, Peter Maydell wrote:
> On Thu, 29 Oct 2020 at 14:31, Christian Schoenebeck
> <qemu_oss@crudebyte.com> wrote:
> >
> > On Donnerstag, 29. Oktober 2020 15:15:19 CET Peter Maydell wrote:
> > > On Thu, 29 Oct 2020 at 14:06, Christian Schoenebeck
> > >
> > > <qemu_oss@crudebyte.com> wrote:
> > > > Ok, I'll use mkdtemp() instead, that avoids other potential parallel
> > > > config
> > > > colissions that I may not have considered yet.
> > > >
> > > > The original motivation against mkdtemp() was that /tmp is isually a
> > > > ramfs,
> > > > hence very limited regarding large file tests. But that's not an issue
> > > > right now.
> > >
> > > How large is "large" here ?
>
> > E.g. ~10 GiB which might be a problem for cloud based CI platforms.
>
> Yeah, 10GB is too big by an order of magnitude for anything in the
> standard "make check" set. It could go in an optional "I'm the 9p
> maintainer and I want to run a wider set of tests" target though.
I think as a rough rule of thumb, tests should not create files
that are larger than the size of the QEMU build dir, and if it is
creating non-trivially sized files, then they should be created in
the build dir, not /tmp. This probably puts 1 GB as a upper bound
on size but bear in mind tests can run in parallel, so ideally biggest
file sizes should be more in the 100s of MB range
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-10-29 15:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 11:20 [PULL 00/13] 9p queue 2020-10-23 Christian Schoenebeck
2020-10-20 16:09 ` [PULL 01/13] tests/9pfs: Factor out do_version() helper Greg Kurz
2020-10-23 15:32 ` Greg Kurz
2020-10-23 15:40 ` Christian Schoenebeck
2020-10-20 16:09 ` [PULL 04/13] tests/9pfs: Turn fs_readdir_split() into a helper Greg Kurz
2020-10-20 16:09 ` [PULL 02/13] tests/9pfs: Set alloc in fs_create_dir() Greg Kurz
2020-10-20 16:09 ` [PULL 03/13] tests/9pfs: Factor out do_attach() helper Greg Kurz
2020-10-20 16:09 ` [PULL 05/13] tests/9pfs: Turn fs_mkdir() into a helper Greg Kurz
2020-10-21 12:06 ` [PULL 06/13] tests/9pfs: simplify do_mkdir() Christian Schoenebeck
2020-10-21 12:17 ` [PULL 07/13] tests/9pfs: add local Tunlinkat directory test Christian Schoenebeck
2020-10-21 12:25 ` [PULL 08/13] tests/9pfs: add local Tlcreate test Christian Schoenebeck
2020-10-21 12:28 ` [PULL 09/13] tests/9pfs: add local Tunlinkat file test Christian Schoenebeck
2020-10-21 12:33 ` [PULL 10/13] tests/9pfs: add local Tsymlink test Christian Schoenebeck
2020-10-21 12:36 ` [PULL 11/13] tests/9pfs: add local Tunlinkat symlink test Christian Schoenebeck
2020-10-21 12:51 ` [PULL 12/13] tests/9pfs: add local Tlink test Christian Schoenebeck
2020-10-21 12:55 ` [PULL 13/13] tests/9pfs: add local Tunlinkat hard link test Christian Schoenebeck
2020-10-26 10:33 ` [PULL 00/13] 9p queue 2020-10-23 Peter Maydell
2020-10-26 12:48 ` Christian Schoenebeck
2020-10-26 21:25 ` Greg Kurz
2020-10-27 9:06 ` Dr. David Alan Gilbert
2020-10-27 10:21 ` Christian Schoenebeck
2020-10-27 10:26 ` Dr. David Alan Gilbert
2020-10-27 15:44 ` Christian Schoenebeck
2020-10-29 13:20 ` Peter Maydell
2020-10-29 13:48 ` Christian Schoenebeck
2020-10-29 13:57 ` Peter Maydell
2020-10-29 14:06 ` Christian Schoenebeck
2020-10-29 14:15 ` Peter Maydell
2020-10-29 14:31 ` Christian Schoenebeck
2020-10-29 14:52 ` Peter Maydell
2020-10-29 15:04 ` Daniel P. Berrangé [this message]
2020-10-29 17:27 ` Christian Schoenebeck
2020-10-29 17:29 ` Daniel P. Berrangé
2020-10-29 14:11 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029150403.GF27369@redhat.com \
--to=berrange@redhat.com \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.