From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xenproject.org
Cc: Olaf Hering <olaf@aepfle.de>, Ian Jackson <iwj@xenproject.org>,
Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v1 03/23] tools: use xc_is_known_page_type
Date: Thu, 29 Oct 2020 18:19:43 +0100 [thread overview]
Message-ID: <20201029172004.17219-4-olaf@aepfle.de> (raw)
In-Reply-To: <20201029172004.17219-1-olaf@aepfle.de>
Verify pfn type on sending side, also verify incoming batch of pfns.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
tools/libs/guest/xg_sr_restore.c | 3 +--
tools/libs/guest/xg_sr_save.c | 6 ++++++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/libs/guest/xg_sr_restore.c b/tools/libs/guest/xg_sr_restore.c
index b57a787519..f1c3169229 100644
--- a/tools/libs/guest/xg_sr_restore.c
+++ b/tools/libs/guest/xg_sr_restore.c
@@ -406,8 +406,7 @@ static int handle_page_data(struct xc_sr_context *ctx, struct xc_sr_record *rec)
}
type = (pages->pfn[i] & PAGE_DATA_TYPE_MASK) >> 32;
- if ( ((type >> XEN_DOMCTL_PFINFO_LTAB_SHIFT) >= 5) &&
- ((type >> XEN_DOMCTL_PFINFO_LTAB_SHIFT) <= 8) )
+ if ( xc_is_known_page_type(type) == false )
{
ERROR("Invalid type %#"PRIx32" for pfn %#"PRIpfn" (index %u)",
type, pfn, i);
diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c
index 2ba7c3200c..044d0ae3aa 100644
--- a/tools/libs/guest/xg_sr_save.c
+++ b/tools/libs/guest/xg_sr_save.c
@@ -147,6 +147,12 @@ static int write_batch(struct xc_sr_context *ctx)
for ( i = 0; i < nr_pfns; ++i )
{
+ if ( xc_is_known_page_type(types[i]) == false )
+ {
+ ERROR("Wrong type %#"PRIpfn" for pfn %#"PRIpfn, types[i], mfns[i]);
+ goto err;
+ }
+
switch ( types[i] )
{
case XEN_DOMCTL_PFINFO_BROKEN:
next prev parent reply other threads:[~2020-10-29 17:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 17:19 [PATCH v1 00/23] reduce overhead during live migration Olaf Hering
2020-10-29 17:19 ` [PATCH v1 01/23] tools: add readv_exact to libxenctrl Olaf Hering
2020-10-29 17:19 ` [PATCH v1 02/23] tools: add xc_is_known_page_type " Olaf Hering
2020-10-29 17:19 ` Olaf Hering [this message]
2020-10-29 17:19 ` [PATCH v1 04/23] tools: unify type checking for data pfns in migration stream Olaf Hering
2020-10-29 17:19 ` [PATCH v1 05/23] tools: show migration transfer rate in send_dirty_pages Olaf Hering
2020-10-29 17:19 ` [PATCH v1 06/23] tools/guest: prepare to allocate arrays once Olaf Hering
2020-10-29 17:19 ` [PATCH v1 07/23] tools/guest: save: move batch_pfns Olaf Hering
2020-10-29 17:19 ` [PATCH v1 08/23] tools/guest: save: move mfns array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 09/23] tools/guest: save: move types array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 10/23] tools/guest: save: move errors array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 11/23] tools/guest: save: move iov array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 12/23] tools/guest: save: move rec_pfns array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 13/23] tools/guest: save: move guest_data array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 14/23] tools/guest: save: move local_pages array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 15/23] tools/guest: restore: move pfns array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 16/23] tools/guest: restore: move types array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 17/23] tools/guest: restore: move mfns array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 18/23] tools/guest: restore: move map_errs array Olaf Hering
2020-10-29 17:19 ` [PATCH v1 19/23] tools/guest: restore: move mfns array in populate_pfns Olaf Hering
2020-10-29 17:20 ` [PATCH v1 20/23] tools/guest: restore: move pfns " Olaf Hering
2020-10-29 17:20 ` [PATCH v1 21/23] tools/guest: restore: split record processing Olaf Hering
2020-10-29 17:20 ` [PATCH v1 22/23] tools/guest: restore: split handle_page_data Olaf Hering
2020-10-29 17:20 ` [PATCH v1 23/23] tools/guest: restore: write data directly into guest Olaf Hering
2020-11-23 16:00 ` [PATCH v1 00/23] reduce overhead during live migration Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029172004.17219-4-olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=anthony.perard@citrix.com \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.