From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs/122: embiggen struct xfs_agi size for inobtcount feature
Date: Thu, 29 Oct 2020 13:39:20 -0400 [thread overview]
Message-ID: <20201029173920.GB1660404@bfoster> (raw)
In-Reply-To: <160382542261.1203756.6377970904886103725.stgit@magnolia>
On Tue, Oct 27, 2020 at 12:03:42PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Make the expected AGI size larger for the inobtcount feature.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
It would be nice for the commit log to have a sentence or two about the
other changes as well, but either way:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> tests/xfs/010 | 3 ++-
> tests/xfs/030 | 2 ++
> tests/xfs/122.out | 2 +-
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
>
> diff --git a/tests/xfs/010 b/tests/xfs/010
> index 1f9bcdff..95cc2555 100755
> --- a/tests/xfs/010
> +++ b/tests/xfs/010
> @@ -113,7 +113,8 @@ _check_scratch_fs
> _corrupt_finobt_root $SCRATCH_DEV
>
> filter_finobt_repair() {
> - sed -e '/^agi has bad CRC/d' | \
> + sed -e '/^agi has bad CRC/d' \
> + -e '/^bad finobt block/d' | \
> _filter_repair_lostblocks
> }
>
> diff --git a/tests/xfs/030 b/tests/xfs/030
> index 04440f9c..906d9019 100755
> --- a/tests/xfs/030
> +++ b/tests/xfs/030
> @@ -44,6 +44,8 @@ _check_ag()
> -e '/^bad agbno AGBNO for refcntbt/d' \
> -e '/^agf has bad CRC/d' \
> -e '/^agi has bad CRC/d' \
> + -e '/^bad inobt block count/d' \
> + -e '/^bad finobt block count/d' \
> -e '/^Missing reverse-mapping record.*/d' \
> -e '/^bad levels LEVELS for [a-z]* root.*/d' \
> -e '/^unknown block state, ag AGNO, block.*/d'
> diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> index cfe09c6d..b0773756 100644
> --- a/tests/xfs/122.out
> +++ b/tests/xfs/122.out
> @@ -113,7 +113,7 @@ sizeof(struct xfs_scrub_metadata) = 64
> sizeof(struct xfs_unmount_log_format) = 8
> sizeof(xfs_agf_t) = 224
> sizeof(xfs_agfl_t) = 36
> -sizeof(xfs_agi_t) = 336
> +sizeof(xfs_agi_t) = 344
> sizeof(xfs_alloc_key_t) = 8
> sizeof(xfs_alloc_rec_incore_t) = 8
> sizeof(xfs_alloc_rec_t) = 8
>
next prev parent reply other threads:[~2020-10-29 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 19:03 [PATCH RFCv4 0/2] xfstests: add inode btree blocks counters to the AGI header Darrick J. Wong
2020-10-27 19:03 ` [PATCH 1/2] xfs/122: embiggen struct xfs_agi size for inobtcount feature Darrick J. Wong
2020-10-29 17:39 ` Brian Foster [this message]
2020-10-29 20:27 ` Darrick J. Wong
2020-10-27 19:03 ` [PATCH 2/2] xfs: test inobtcount upgrade Darrick J. Wong
2020-10-29 17:40 ` Brian Foster
2020-10-29 20:31 ` Darrick J. Wong
2020-11-18 16:44 ` Eric Sandeen
2020-11-20 1:53 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029173920.GB1660404@bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.