From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by arago-project.org (Postfix) with ESMTPS id 85365529C6 for ; Thu, 29 Oct 2020 19:45:57 +0000 (UTC) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09TJgo9g094723; Thu, 29 Oct 2020 14:42:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604000570; bh=Q+9EDVUxdxfo0PF309f7E2mesDftkSIz0mysTvMseZ8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=YjQaYgH9mpWKGxVos9feKNHrvr3xqEDP71ymwIP4bZnlSerJhSNVIof+pAtkHm5NA TO2imajugG8h2b1RhCYNpgxQdPYz/+Uub+CrzMrFb3NgjhihJATQPPzhcgCCul0tmc b2gLNV/OKtgZ+1y6Vw0r5QAiMR0GL0AeccgoTCTI= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09TJgoYh042935 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 29 Oct 2020 14:42:50 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 29 Oct 2020 14:42:50 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 29 Oct 2020 14:42:50 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09TJgol6050787; Thu, 29 Oct 2020 14:42:50 -0500 Date: Thu, 29 Oct 2020 15:42:50 -0400 From: Denys Dmytriyenko To: Dan Murphy Message-ID: <20201029194249.GO15849@beryl> References: <1603927657-53672-1-git-send-email-denis@denix.org> <20201029171541.GD15849@beryl> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org Subject: Re: [dunfell/master][PATCH v4] websocketd: Add new recipe X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 19:45:57 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Thu, Oct 29, 2020 at 02:38:34PM -0500, Dan Murphy wrote: > Denys > > On 10/29/20 12:15 PM, Denys Dmytriyenko wrote: > >On Thu, Oct 29, 2020 at 11:36:45AM -0500, Dan Murphy wrote: > >>Nikhil > >> > >>On 10/28/20 6:27 PM, Denys Dmytriyenko wrote: > >>>From: Nikhil Devshatwar > >>> > >>>websocketd is an application which allows to redirect output of > >>>command line applications via a websocket so that web pages can > >>>interact with them. > >>> > >>>This is very useful for visualizing statistics information on > >>>host machine browser. > >>> > >>>Signed-off-by: Nikhil Devshatwar > >>>Signed-off-by: Denys Dmytriyenko > >>>--- > >>>v4 - export http_proxy with explanation > >>> > >>> .../recipes-devtools/websocketd/websocketd_0.3.1.bb | 18 ++++++++++++++++++ > >>> 1 file changed, 18 insertions(+) > >>> create mode 100644 meta-arago-extras/recipes-devtools/websocketd/websocketd_0.3.1.bb > >>> > >>>diff --git a/meta-arago-extras/recipes-devtools/websocketd/websocketd_0.3.1.bb b/meta-arago-extras/recipes-devtools/websocketd/websocketd_0.3.1.bb > >>>new file mode 100644 > >>>index 0000000..d2f3387 > >>>--- /dev/null > >>>+++ b/meta-arago-extras/recipes-devtools/websocketd/websocketd_0.3.1.bb > >>>@@ -0,0 +1,18 @@ > >>>+SUMMARY = "Application for routing native applications via websockets" > >>>+HOMEPAGE = "http://websocketd.com/" > >>>+LICENSE = "BSD-2-Clause" > >>>+LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=a14d7befdbee1290ac5c472cd85d66f2" > >>>+ > >>>+inherit go-mod > >>>+ > >>>+GO_IMPORT = "github.com/joewalnes/websocketd" > >>>+ > >>>+SRC_URI = "git://${GO_IMPORT}" > >>>+SRCREV = "0440211d7862dc76b5f2499d7dfcd4ef6a9c2fa2" > >>>+ > >>>+# bitbake only exports proxy variables during fetching, but go handles > >>>+# module fetching on its own during compile and needs proxy settings > >>>+export http_proxy > >>>+ > >>>+# Development package contains all the examples in different languages > >>>+INSANE_SKIP_${PN}-dev = "file-rdeps" > >>This looks fine to me but I think we should add the version we are checking > >>out. > >> > >>I mean this repo has not been updated in years but we should add the version > >>so we know it is v0.3.1. > >SRCREV above corresponds to v0.3.1 tag. While you could use the tag directly, > >it's not recommended and it's better to use specific commit SHA directly in > >the recipes, even if it's the same as the tag. > > > >The only benefit of using the tag in SRCREV is developer convenience. > > > >There are several drawbacks though: > > > >* tag could move, so someone else using your recipe could get a completely > >different output, not what you expected or intended > > > >* tag needs to be resolved against the origin git server on every bitbake > >parse, regardless if you have local sources cached or stored on a mirror. > >That requires network connection, proxies setup, etc. for every time you > >run bitbake. And some customers require isolated no-network builds when all > >the sources are available locally > > > >* and from integration/release perspective there's less control of the build > >and results due to the above - images, packages, sstate could change. Not an > >issue for nightly builds, but could be a major issue for reproducible releases > > > No I was suggesting just adding > > PV = "v0.3.1" to the recipe. Still use the SHA but just document the version No, the filename already sets it to "0.3.1". -- Denys