From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3212AC4741F for ; Thu, 29 Oct 2020 21:06:43 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44D8F20790 for ; Thu, 29 Oct 2020 21:06:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44D8F20790 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tycho.pizza Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=containers-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 9A39E86BF3; Thu, 29 Oct 2020 21:06:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lnmfZflZySCh; Thu, 29 Oct 2020 21:06:39 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 2AA5686A6B; Thu, 29 Oct 2020 21:06:39 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1C4FDC0859; Thu, 29 Oct 2020 21:06:39 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 70898C0051 for ; Thu, 29 Oct 2020 21:06:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 42D8720466 for ; Thu, 29 Oct 2020 21:06:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 45Fr4EZHnYIY for ; Thu, 29 Oct 2020 21:06:35 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by silver.osuosl.org (Postfix) with ESMTPS id 6A9992045C for ; Thu, 29 Oct 2020 21:06:35 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 822B35807DF; Thu, 29 Oct 2020 17:06:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 29 Oct 2020 17:06:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho.pizza; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=fYIDdq21L3PNif5afbEUKONBxow yx9f6qw+sQaUQx0Y=; b=bGUYRyMUpthilA5bQ10aPU+KdYNie57r/5wBrgijABq s7aehhE86zzIn7RqEp0bZZtxXb1IdY13z3P0HsUCZBcQRwuTEYtrs/0amoA1NzDW v9oNCDlok1l91OtHOJfztlU57tX8WM/Ab9slbfpASGWFbLtWO9fBhg+gf41CIzJS 6/edNyCmFTtrigWwXUqC43SRNCgTTzSzqhGp3G1z7mAy2j44zhy8CdEePT9p0zOq OiRJbOWxtkTPdviEnyyUaO4jqOJyJp5dyDRVrVQAVFwa8GHs3CGMnNPWjjo51g1q vkDNarhpemR/y7Rm6T8c15bqJi3H6ZPybWdfL9oJjPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fYIDdq 21L3PNif5afbEUKONBxowyx9f6qw+sQaUQx0Y=; b=ANMYYU1hiB/GO9911ZFl+z XpknmkW+TvWcsslx+BfrP2kM7LffztVYc9tmktae7/SatO4YkhVbkkUfBylAba2A I2a2n2BbulsFMeAsw3WIZN57eLxTYwxBkl/wqQCvjdii2vV69IH3ivUFHOccZ9zE dzt1jXnMFhAA6r/ed21mimZYJz1+U51nuqzJXZlme0adofrtZYgTtKB6ltEiTD2t tsLwQ3YSVLXZfKlt50fkRenwFYdw86uCLRVPm+dpxWpF/jpgcPAzK4pm6K/F254N GuDopL1Eu6i9RT3D07xXogZgfBRi+ipoI/T07NmvM2a7QPR7gAlEGglcNfii9q8w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvhigthhho ucetnhguvghrshgvnhcuoehthigthhhosehthigthhhordhpihiiiigrqeenucggtffrrg htthgvrhhnpeegkeefjeegkedtjefgfeduleekueetjeeghffhuefgffefleehgeeifedv gfethfenucfkphepuddvkedruddtjedrvdeguddrudekieenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthigthhhosehthigthhhordhpihii iigr X-ME-Proxy: Received: from cisco (unknown [128.107.241.186]) by mail.messagingengine.com (Postfix) with ESMTPA id C96743280065; Thu, 29 Oct 2020 17:06:22 -0400 (EDT) Date: Thu, 29 Oct 2020 15:06:20 -0600 From: Tycho Andersen To: Christian Brauner Subject: Re: [PATCH 00/34] fs: idmapped mounts Message-ID: <20201029210620.GB135035@cisco> References: <20201029003252.2128653-1-christian.brauner@ubuntu.com> <20201029022733.GB306023@dread.disaster.area> <20201029161920.zp7p3335x3q2a36e@wittgenstein> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201029161920.zp7p3335x3q2a36e@wittgenstein> Cc: Andy Lutomirski , Dave Chinner , Mimi Zohar , David Howells , Andreas Dilger , Miklos Szeredi , smbarber@chromium.org, Christoph Hellwig , Casey Schaufler , linux-ext4@vger.kernel.org, Mrunal Patel , Kees Cook , Arnd Bergmann , Jann Horn , selinux@vger.kernel.org, Josh Triplett , Seth Forshee , Alexander Viro , Lennart Poettering , OGAWA Hirofumi , Geoffrey Thomas , James Bottomley , John Johansen , Theodore Tso , Dmitry Kasatkin , containers@lists.linux-foundation.org, Jonathan Corbet , linux-unionfs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, "Eric W. Biederman" , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alban Crequy , linux-integrity@vger.kernel.org, Stephen Smalley , Todd Kjos X-BeenThere: containers@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux Containers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: containers-bounces@lists.linux-foundation.org Sender: "Containers" On Thu, Oct 29, 2020 at 05:19:20PM +0100, Christian Brauner wrote: > This approach (always) seemed conceptually wrong to me. Like Tycho said > somewhere else this basically would act like a global variable which > isn't great. Elaborating on this a bit: the way Christian has organized this series (by adding a parameter to the various inode operations) forces people to make a choice about what user namespace to pass. They can of course make the wrong choice, but that will show up in a diff somewhere, and hopefully someone will notice. If we pass things via current-> somewhere, people could potentially avoid making this choice, and then we wind more of the kinds of bugs Eric is worried about elsewhere in the thread. While it does result in larger patches initally, requiring people to reason about it explicitly is the right move, IMO. Tycho _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/containers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA0EC2D0A3 for ; Thu, 29 Oct 2020 21:21:32 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C34C20791 for ; Thu, 29 Oct 2020 21:21:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C34C20791 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tycho.pizza Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-577-Zo8PYLVvP9Sfu-I7-AcMDg-1; Thu, 29 Oct 2020 17:21:28 -0400 X-MC-Unique: Zo8PYLVvP9Sfu-I7-AcMDg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D7441019628; Thu, 29 Oct 2020 21:21:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F77155761; Thu, 29 Oct 2020 21:21:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F202B181A06B; Thu, 29 Oct 2020 21:21:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09TL6cfa003789 for ; Thu, 29 Oct 2020 17:06:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 956D02166BD9; Thu, 29 Oct 2020 21:06:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F00D2157F45 for ; Thu, 29 Oct 2020 21:06:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3F66885829E for ; Thu, 29 Oct 2020 21:06:36 +0000 (UTC) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-UFmqhyVLPqKc_6-OIgdZCA-1; Thu, 29 Oct 2020 17:06:33 -0400 X-MC-Unique: UFmqhyVLPqKc_6-OIgdZCA-1 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 822B35807DF; Thu, 29 Oct 2020 17:06:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 29 Oct 2020 17:06:33 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvhigthhho ucetnhguvghrshgvnhcuoehthigthhhosehthigthhhordhpihiiiigrqeenucggtffrrg htthgvrhhnpeegkeefjeegkedtjefgfeduleekueetjeeghffhuefgffefleehgeeifedv gfethfenucfkphepuddvkedruddtjedrvdeguddrudekieenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthigthhhosehthigthhhordhpihii iigr X-ME-Proxy: Received: from cisco (unknown [128.107.241.186]) by mail.messagingengine.com (Postfix) with ESMTPA id C96743280065; Thu, 29 Oct 2020 17:06:22 -0400 (EDT) Date: Thu, 29 Oct 2020 15:06:20 -0600 From: Tycho Andersen To: Christian Brauner Subject: Re: [PATCH 00/34] fs: idmapped mounts Message-ID: <20201029210620.GB135035@cisco> References: <20201029003252.2128653-1-christian.brauner@ubuntu.com> <20201029022733.GB306023@dread.disaster.area> <20201029161920.zp7p3335x3q2a36e@wittgenstein> MIME-Version: 1.0 In-Reply-To: <20201029161920.zp7p3335x3q2a36e@wittgenstein> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Thu, 29 Oct 2020 17:21:09 -0400 Cc: Andy Lutomirski , Dave Chinner , Mimi Zohar , David Howells , Andreas Dilger , Miklos Szeredi , smbarber@chromium.org, Christoph Hellwig , linux-ext4@vger.kernel.org, Mrunal Patel , Arnd Bergmann , Jann Horn , selinux@vger.kernel.org, Josh Triplett , Seth Forshee , Alexander Viro , Lennart Poettering , OGAWA Hirofumi , Geoffrey Thomas , James Bottomley , John Johansen , Theodore Tso , Dmitry Kasatkin , containers@lists.linux-foundation.org, Jonathan Corbet , linux-unionfs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, "Eric W. Biederman" , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alban Crequy , linux-integrity@vger.kernel.org, Todd Kjos X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Oct 29, 2020 at 05:19:20PM +0100, Christian Brauner wrote: > This approach (always) seemed conceptually wrong to me. Like Tycho said > somewhere else this basically would act like a global variable which > isn't great. Elaborating on this a bit: the way Christian has organized this series (by adding a parameter to the various inode operations) forces people to make a choice about what user namespace to pass. They can of course make the wrong choice, but that will show up in a diff somewhere, and hopefully someone will notice. If we pass things via current-> somewhere, people could potentially avoid making this choice, and then we wind more of the kinds of bugs Eric is worried about elsewhere in the thread. While it does result in larger patches initally, requiring people to reason about it explicitly is the right move, IMO. Tycho -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit