From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 348F4C4363A for ; Fri, 30 Oct 2020 03:29:15 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87A1120720 for ; Fri, 30 Oct 2020 03:29:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87A1120720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=invisiblethingslab.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.15386.38367 (Exim 4.92) (envelope-from ) id 1kYL5l-0004gM-F6; Fri, 30 Oct 2020 03:28:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 15386.38367; Fri, 30 Oct 2020 03:28:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYL5l-0004gF-Bh; Fri, 30 Oct 2020 03:28:41 +0000 Received: by outflank-mailman (input) for mailman id 15386; Fri, 30 Oct 2020 03:28:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYL5j-0004gA-TA for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 03:28:40 +0000 Received: from out2-smtp.messagingengine.com (unknown [66.111.4.26]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d408ed9-47a9-4720-b2f9-0c90b863b4ad; Fri, 30 Oct 2020 03:28:38 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BDE9D5C0131; Thu, 29 Oct 2020 23:28:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 29 Oct 2020 23:28:38 -0400 Received: from mail-itl (ip5b40aa59.dynamic.kabel-deutschland.de [91.64.170.89]) by mail.messagingengine.com (Postfix) with ESMTPA id 0861A3280063; Thu, 29 Oct 2020 23:28:37 -0400 (EDT) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYL5j-0004gA-TA for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 03:28:40 +0000 X-Inumbo-ID: 1d408ed9-47a9-4720-b2f9-0c90b863b4ad Received: from out2-smtp.messagingengine.com (unknown [66.111.4.26]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d408ed9-47a9-4720-b2f9-0c90b863b4ad; Fri, 30 Oct 2020 03:28:38 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BDE9D5C0131; Thu, 29 Oct 2020 23:28:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 29 Oct 2020 23:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nldD6o fiqaXXlTDlB3bpDhEfk1kq2/CjjYuqgH3H7W4=; b=kxQO6WTrIWD++n8RmjVjQS pLDxSA3uO4ztQjA0DiMBI/AGWZ4cIdpzm5We7GacS468E5UazX2MpWsYOlbbsthf VMhDJf+TBrfTKSTJR958JnXcAo3+jMGxEQPRQvDja3H6jKMlewPiHB0ZvSdAikHA ZMTvEQobWwTVFFOM/HyHm3FGjnctk/PXkP2M4JzK/9K5k87vVJrFa/QvTniYCzFe ZxcqoyCMEntTbdtaf4j9NiZqkZ3616KXDh++5hJpo3+/9qyo2uSjX+vyYuRnuXLc /8kcUvI8WMd3ati3qTrB8i3x2YbPhBi9DbQXgxNWLe+K4CR6i0g6jhHkXaHSP2UQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleeggdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiuceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhih hnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgefhtdfhuddtjefgjeevhffh jeejtefgjeevgeeijeduhfdtteehieffvdettddvnecukfhppeeluddrieegrddujedtrd ekleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Received: from mail-itl (ip5b40aa59.dynamic.kabel-deutschland.de [91.64.170.89]) by mail.messagingengine.com (Postfix) with ESMTPA id 0861A3280063; Thu, 29 Oct 2020 23:28:37 -0400 (EDT) Date: Fri, 30 Oct 2020 04:28:34 +0100 From: Marek Marczykowski To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] tools/python: pass more -rpath-link options to ld Message-ID: <20201030032834.GC1447@mail-itl> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F4Dl6XKrV7PH8SJF" Content-Disposition: inline In-Reply-To: --F4Dl6XKrV7PH8SJF Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] tools/python: pass more -rpath-link options to ld On Mon, Oct 19, 2020 at 10:31:37AM +0200, Jan Beulich wrote: > With the split of libraries, I've observed a number of warnings from > (old?) ld. >=20 > Signed-off-by: Jan Beulich > --- > It's unclear to me whether this is ld version dependent - the pattern > of where I've seen such warnings doesn't suggest a clear version > dependency. >=20 > --- a/tools/python/setup.py > +++ b/tools/python/setup.py > @@ -7,10 +7,15 @@ XEN_ROOT =3D "../.." > extra_compile_args =3D [ "-fno-strict-aliasing", "-Werror" ] > =20 > PATH_XEN =3D XEN_ROOT + "/tools/include" > +PATH_LIBXENTOOLCORE =3D XEN_ROOT + "/tools/libs/toolcore" > PATH_LIBXENTOOLLOG =3D XEN_ROOT + "/tools/libs/toollog" > +PATH_LIBXENCALL =3D XEN_ROOT + "/tools/libs/call" > PATH_LIBXENEVTCHN =3D XEN_ROOT + "/tools/libs/evtchn" > +PATH_LIBXENGNTTAB =3D XEN_ROOT + "/tools/libs/gnttab" > PATH_LIBXENCTRL =3D XEN_ROOT + "/tools/libs/ctrl" > PATH_LIBXENGUEST =3D XEN_ROOT + "/tools/libs/guest" > +PATH_LIBXENDEVICEMODEL =3D XEN_ROOT + "/tools/libs/devicemodel" > +PATH_LIBXENFOREIGNMEMORY =3D XEN_ROOT + "/tools/libs/foreignmemory" > PATH_XENSTORE =3D XEN_ROOT + "/tools/libs/store" > =20 > xc =3D Extension("xc", > @@ -24,7 +29,13 @@ xc =3D Extension("xc", > library_dirs =3D [ PATH_LIBXENCTRL, PATH_LIBXENGUES= T ], > libraries =3D [ "xenctrl", "xenguest" ], > depends =3D [ PATH_LIBXENCTRL + "/libxenctrl.s= o", PATH_LIBXENGUEST + "/libxenguest.so" ], > - extra_link_args =3D [ "-Wl,-rpath-link=3D"+PATH_LIBXEN= TOOLLOG ], > + extra_link_args =3D [ "-Wl,-rpath-link=3D"+PATH_LIBXEN= CALL, > + "-Wl,-rpath-link=3D"+PATH_LIBXENDE= VICEMODEL, > + "-Wl,-rpath-link=3D"+PATH_LIBXENEV= TCHN, > + "-Wl,-rpath-link=3D"+PATH_LIBXENFO= REIGNMEMORY, > + "-Wl,-rpath-link=3D"+PATH_LIBXENGN= TTAB, > + "-Wl,-rpath-link=3D"+PATH_LIBXENTO= OLCORE, > + "-Wl,-rpath-link=3D"+PATH_LIBXENTO= OLLOG ], This basically open-codes SHLIB_libxenctrl + SHLIB_libxenguest. Isn't it better to pass it from make that already has all the dependencies resolved? > sources =3D [ "xen/lowlevel/xc/xc.c" ]) > =20 > xs =3D Extension("xs", > @@ -33,6 +44,7 @@ xs =3D Extension("xs", > library_dirs =3D [ PATH_XENSTORE ], > libraries =3D [ "xenstore" ], > depends =3D [ PATH_XENSTORE + "/libxenstore.so= " ], > + extra_link_args =3D [ "-Wl,-rpath-link=3D"+PATH_LIBXEN= TOOLCORE ], > sources =3D [ "xen/lowlevel/xs/xs.c" ]) > =20 > plat =3D os.uname()[0] --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --F4Dl6XKrV7PH8SJF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl+biGMACgkQ24/THMrX 1ywLpAf+JOAKhIphCQaat0Kg8bFiR/QoCzGlgTAabln1b5D+Gbl8qPO9HW6XuBo1 9wGKElizC/lgIZhFAMw0ulxCrNKn+fpCYQ16H2v/6JaSbXtsSBTEukiRw47AIjBC crcgkdSYDd26bniXZFTW/kY7kTpeVCYZYTwSHpzwmVnk3KP/BluAq4hER2fPYLna SUh7Moyh0RJNlGyUjV4D9+00bgjPUF2ppGc6McFjeKukctSV7U3uzhHHLjF/X/ko NecKn+pdSTe8I1K6ga78JB/yhHygUYqg3EY0GmahgbJTCT2IcIDUcLIwY2ym3cSB kpI/3E9Ggr5akcNxGhSYTEISPcQbCA== =2fCX -----END PGP SIGNATURE----- --F4Dl6XKrV7PH8SJF--