From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 06/16] mm/pagemap: Cleanup PREEMPT_COUNT leftovers
Date: Fri, 30 Oct 2020 05:21:32 +0800 [thread overview]
Message-ID: <202010300546.cKCboa60-lkp@intel.com> (raw)
In-Reply-To: <20201029165019.14218-6-urezki@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 13241 bytes --]
Hi "Uladzislau,
I love your patch! Perhaps something to improve:
[auto build test WARNING on arm/for-next]
[also build test WARNING on tip/sched/core linus/master v5.10-rc1]
[cannot apply to rcu/dev drm-intel/for-linux-next next-20201029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Uladzislau-Rezki-Sony/rcu-tree-Add-a-work-to-allocate-pages-from-regular-context/20201030-005247
base: git://git.armlinux.org.uk/~rmk/linux-arm.git for-next
config: arm-randconfig-r004-20201029 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 772aaa602383cf82795572ebcd86b0e660f3579f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/1e0b66ce2b779463194f8b398b8e48caa95aabf4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Uladzislau-Rezki-Sony/rcu-tree-Add-a-work-to-allocate-pages-from-regular-context/20201030-005247
git checkout 1e0b66ce2b779463194f8b398b8e48caa95aabf4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/char/random.c:348:
In file included from include/trace/events/random.h:8:
In file included from include/linux/writeback.h:14:
In file included from include/linux/blk-cgroup.h:23:
In file included from include/linux/blkdev.h:14:
include/linux/pagemap.h:207:26: error: expected ';' after do/while statement
VM_BUG_ON(preemptible())
^
;
>> drivers/char/random.c:1269:41: warning: shift count >= width of type [-Wshift-count-overflow]
c_high = (sizeof(cycles) > 4) ? cycles >> 32 : 0;
^ ~~
drivers/char/random.c:1270:35: warning: shift count >= width of type [-Wshift-count-overflow]
j_high = (sizeof(now) > 4) ? now >> 32 : 0;
^ ~~
drivers/char/random.c:2296:6: warning: no previous prototype for function 'add_hwgenerator_randomness' [-Wmissing-prototypes]
void add_hwgenerator_randomness(const char *buffer, size_t count,
^
drivers/char/random.c:2296:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void add_hwgenerator_randomness(const char *buffer, size_t count,
^
static
3 warnings and 1 error generated.
--
In file included from drivers/usb/host/ehci-platform.c:37:
In file included from include/linux/usb/of.h:12:
In file included from include/linux/usb/otg.h:13:
In file included from include/linux/phy/phy.h:17:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:22:
In file included from include/linux/writeback.h:14:
In file included from include/linux/blk-cgroup.h:23:
In file included from include/linux/blkdev.h:14:
include/linux/pagemap.h:207:26: error: expected ';' after do/while statement
VM_BUG_ON(preemptible())
^
;
>> drivers/usb/host/ehci-platform.c:259:24: warning: shift count >= width of type [-Wshift-count-overflow]
pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
1 warning and 1 error generated.
--
In file included from drivers/usb/host/xhci-plat.c:21:
In file included from include/linux/usb/of.h:12:
In file included from include/linux/usb/otg.h:13:
In file included from include/linux/phy/phy.h:17:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:22:
In file included from include/linux/writeback.h:14:
In file included from include/linux/blk-cgroup.h:23:
In file included from include/linux/blkdev.h:14:
include/linux/pagemap.h:207:26: error: expected ';' after do/while statement
VM_BUG_ON(preemptible())
^
;
>> drivers/usb/host/xhci-plat.c:222:10: warning: shift count >= width of type [-Wshift-count-overflow]
DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
drivers/usb/host/xhci-plat.c:224:43: warning: shift count >= width of type [-Wshift-count-overflow]
ret = dma_set_mask_and_coherent(sysdev, DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
2 warnings and 1 error generated.
--
In file included from drivers/mmc/host/sdhci.c:24:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:22:
In file included from include/linux/writeback.h:14:
In file included from include/linux/blk-cgroup.h:23:
In file included from include/linux/blkdev.h:14:
include/linux/pagemap.h:207:26: error: expected ';' after do/while statement
VM_BUG_ON(preemptible())
^
;
>> drivers/mmc/host/sdhci.c:3953:40: warning: shift count >= width of type [-Wshift-count-overflow]
ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
drivers/mmc/host/sdhci.c:4254:20: warning: shift count >= width of type [-Wshift-count-overflow]
host->dma_mask = DMA_BIT_MASK(64);
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
2 warnings and 1 error generated.
vim +1269 drivers/char/random.c
ee3e00e9e7101c8 Theodore Ts'o 2014-06-15 1254
775f4b297b78060 Theodore Ts'o 2012-07-02 1255 void add_interrupt_randomness(int irq, int irq_flags)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1256 {
775f4b297b78060 Theodore Ts'o 2012-07-02 1257 struct entropy_store *r;
1b2a1a7e8ad1144 Christoph Lameter 2014-08-17 1258 struct fast_pool *fast_pool = this_cpu_ptr(&irq_randomness);
775f4b297b78060 Theodore Ts'o 2012-07-02 1259 struct pt_regs *regs = get_irq_regs();
775f4b297b78060 Theodore Ts'o 2012-07-02 1260 unsigned long now = jiffies;
655b226470b2295 Theodore Ts'o 2013-09-22 1261 cycles_t cycles = random_get_entropy();
43759d4f429c8d5 Theodore Ts'o 2014-06-14 1262 __u32 c_high, j_high;
655b226470b2295 Theodore Ts'o 2013-09-22 1263 __u64 ip;
83664a6928a420b H. Peter Anvin 2014-03-17 1264 unsigned long seed;
91fcb532efe366d Theodore Ts'o 2014-06-10 1265 int credit = 0;
655b226470b2295 Theodore Ts'o 2013-09-22 1266
ee3e00e9e7101c8 Theodore Ts'o 2014-06-15 1267 if (cycles == 0)
ee3e00e9e7101c8 Theodore Ts'o 2014-06-15 1268 cycles = get_reg(fast_pool, regs);
655b226470b2295 Theodore Ts'o 2013-09-22 @1269 c_high = (sizeof(cycles) > 4) ? cycles >> 32 : 0;
655b226470b2295 Theodore Ts'o 2013-09-22 1270 j_high = (sizeof(now) > 4) ? now >> 32 : 0;
43759d4f429c8d5 Theodore Ts'o 2014-06-14 1271 fast_pool->pool[0] ^= cycles ^ j_high ^ irq;
43759d4f429c8d5 Theodore Ts'o 2014-06-14 1272 fast_pool->pool[1] ^= now ^ c_high;
655b226470b2295 Theodore Ts'o 2013-09-22 1273 ip = regs ? instruction_pointer(regs) : _RET_IP_;
43759d4f429c8d5 Theodore Ts'o 2014-06-14 1274 fast_pool->pool[2] ^= ip;
ee3e00e9e7101c8 Theodore Ts'o 2014-06-15 1275 fast_pool->pool[3] ^= (sizeof(ip) > 4) ? ip >> 32 :
ee3e00e9e7101c8 Theodore Ts'o 2014-06-15 1276 get_reg(fast_pool, regs);
3060d6fe2857064 Yinghai Lu 2008-08-19 1277
43759d4f429c8d5 Theodore Ts'o 2014-06-14 1278 fast_mix(fast_pool);
43759d4f429c8d5 Theodore Ts'o 2014-06-14 1279 add_interrupt_bench(cycles);
3060d6fe2857064 Yinghai Lu 2008-08-19 1280
43838a23a05fbd1 Theodore Ts'o 2018-04-11 1281 if (unlikely(crng_init == 0)) {
e192be9d9a30555 Theodore Ts'o 2016-06-12 1282 if ((fast_pool->count >= 64) &&
e192be9d9a30555 Theodore Ts'o 2016-06-12 1283 crng_fast_load((char *) fast_pool->pool,
e192be9d9a30555 Theodore Ts'o 2016-06-12 1284 sizeof(fast_pool->pool))) {
e192be9d9a30555 Theodore Ts'o 2016-06-12 1285 fast_pool->count = 0;
e192be9d9a30555 Theodore Ts'o 2016-06-12 1286 fast_pool->last = now;
e192be9d9a30555 Theodore Ts'o 2016-06-12 1287 }
e192be9d9a30555 Theodore Ts'o 2016-06-12 1288 return;
e192be9d9a30555 Theodore Ts'o 2016-06-12 1289 }
e192be9d9a30555 Theodore Ts'o 2016-06-12 1290
840f95077ffd640 Theodore Ts'o 2014-06-14 1291 if ((fast_pool->count < 64) &&
840f95077ffd640 Theodore Ts'o 2014-06-14 1292 !time_after(now, fast_pool->last + HZ))
^1da177e4c3f415 Linus Torvalds 2005-04-16 1293 return;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1294
e192be9d9a30555 Theodore Ts'o 2016-06-12 1295 r = &input_pool;
840f95077ffd640 Theodore Ts'o 2014-06-14 1296 if (!spin_trylock(&r->lock))
91fcb532efe366d Theodore Ts'o 2014-06-10 1297 return;
83664a6928a420b H. Peter Anvin 2014-03-17 1298
91fcb532efe366d Theodore Ts'o 2014-06-10 1299 fast_pool->last = now;
85608f8e16c28f8 Theodore Ts'o 2014-06-10 1300 __mix_pool_bytes(r, &fast_pool->pool, sizeof(fast_pool->pool));
83664a6928a420b H. Peter Anvin 2014-03-17 1301
83664a6928a420b H. Peter Anvin 2014-03-17 1302 /*
83664a6928a420b H. Peter Anvin 2014-03-17 1303 * If we have architectural seed generator, produce a seed and
48d6be955a7167b Theodore Ts'o 2014-07-17 1304 * add it to the pool. For the sake of paranoia don't let the
48d6be955a7167b Theodore Ts'o 2014-07-17 1305 * architectural seed generator dominate the input from the
48d6be955a7167b Theodore Ts'o 2014-07-17 1306 * interrupt noise.
83664a6928a420b H. Peter Anvin 2014-03-17 1307 */
83664a6928a420b H. Peter Anvin 2014-03-17 1308 if (arch_get_random_seed_long(&seed)) {
85608f8e16c28f8 Theodore Ts'o 2014-06-10 1309 __mix_pool_bytes(r, &seed, sizeof(seed));
48d6be955a7167b Theodore Ts'o 2014-07-17 1310 credit = 1;
83664a6928a420b H. Peter Anvin 2014-03-17 1311 }
91fcb532efe366d Theodore Ts'o 2014-06-10 1312 spin_unlock(&r->lock);
83664a6928a420b H. Peter Anvin 2014-03-17 1313
ee3e00e9e7101c8 Theodore Ts'o 2014-06-15 1314 fast_pool->count = 0;
83664a6928a420b H. Peter Anvin 2014-03-17 1315
ee3e00e9e7101c8 Theodore Ts'o 2014-06-15 1316 /* award one bit for the contents of the fast pool */
ee3e00e9e7101c8 Theodore Ts'o 2014-06-15 1317 credit_entropy_bits(r, credit + 1);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1318 }
4b44f2d18a33056 Stephan Mueller 2016-05-02 1319 EXPORT_SYMBOL_GPL(add_interrupt_randomness);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1320
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26115 bytes --]
next prev parent reply other threads:[~2020-10-29 21:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 16:50 [PATCH 01/16] rcu/tree: Add a work to allocate pages from regular context Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 02/16] lib/debug: Remove pointless ARCH_NO_PREEMPT dependencies Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 03/16] preempt: Make preempt count unconditional Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 04/16] preempt: Cleanup PREEMPT_COUNT leftovers Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 05/16] lockdep: " Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 06/16] mm/pagemap: " Uladzislau Rezki (Sony)
2020-10-29 20:57 ` Uladzislau Rezki
2020-10-29 21:26 ` Paul E. McKenney
2020-10-29 21:03 ` kernel test robot
2020-10-29 21:21 ` kernel test robot [this message]
2020-10-30 2:36 ` kernel test robot
2020-10-29 16:50 ` [PATCH 07/16] locking/bitspinlock: " Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 08/16] uaccess: " Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 09/16] sched: " Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 10/16] ARM: " Uladzislau Rezki (Sony)
2020-10-29 16:50 ` Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 11/16] xtensa: " Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [Intel-gfx] [PATCH 12/16] drm/i915: " Uladzislau Rezki (Sony)
2020-10-29 16:50 ` Uladzislau Rezki (Sony)
2020-10-29 16:50 ` Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 13/16] rcutorture: " Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 14/16] preempt: Remove PREEMPT_COUNT from Kconfig Uladzislau Rezki (Sony)
2020-10-29 16:50 ` [PATCH 15/16] rcu/tree: Allocate a page when caller is preemptible Uladzislau Rezki (Sony)
2020-11-03 18:03 ` Joel Fernandes
2020-11-04 11:39 ` Uladzislau Rezki
2020-11-04 14:36 ` Joel Fernandes
2020-10-29 16:50 ` [PATCH 16/16] rcu/tree: Use delayed work instead of hrtimer to refill the cache Uladzislau Rezki (Sony)
2020-10-29 19:47 ` Paul E. McKenney
2020-10-29 20:13 ` Uladzislau Rezki
2020-10-29 20:22 ` Uladzislau Rezki
2020-10-29 20:33 ` Paul E. McKenney
2020-10-29 21:00 ` Uladzislau Rezki
2020-11-03 15:47 ` [PATCH 01/16] rcu/tree: Add a work to allocate pages from regular context Joel Fernandes
2020-11-03 16:33 ` Uladzislau Rezki
2020-11-03 19:18 ` Paul E. McKenney
2020-11-04 12:35 ` Uladzislau Rezki
2020-11-04 14:12 ` Paul E. McKenney
2020-11-04 14:40 ` Uladzislau Rezki
2020-11-03 17:54 ` Joel Fernandes
2020-11-04 12:12 ` Uladzislau Rezki
2020-11-04 15:01 ` Joel Fernandes
2020-11-04 18:38 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010300546.cKCboa60-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.