From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Coiby Xu <Coiby.Xu@gmail.com>,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests
Date: Fri, 30 Oct 2020 08:42:19 -0400 [thread overview]
Message-ID: <20201030084155-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20201027173528.213464-1-stefanha@redhat.com>
On Tue, Oct 27, 2020 at 05:35:16PM +0000, Stefan Hajnoczi wrote:
> This patch series solves some issues with the new vhost-user-blk-server and
> adds the qtest test case. The test case was not included in the pull request
> that introduced the vhost-user-blk server because of reliability issues that
> are fixed in this patch series.
Fails make check for me:
Running test qtest-i386/qos-test
Broken pipe
../qemu/tests/qtest/libqtest.c:161: kill_qemu() detected QEMU death from signal 11 (Segmentation fault) (core dumped)
ERROR qtest-i386/qos-test - too few tests run (expected 92, got 65)
make: *** [Makefile.mtest:1857: run-test-230] Error 1
> Coiby Xu (1):
> test: new qTest case to test the vhost-user-blk-server
>
> Stefan Hajnoczi (11):
> libvhost-user: follow QEMU comment style
> configure: introduce --enable-vhost-user-blk-server
> block/export: make vhost-user-blk config space little-endian
> block/export: fix vhost-user-blk get_config() information leak
> contrib/vhost-user-blk: fix get_config() information leak
> tests/qtest: add multi-queue test case to vhost-user-blk-test
> libqtest: add qtest_socket_server()
> vhost-user-blk-test: rename destroy_drive() to destroy_file()
> vhost-user-blk-test: close fork child file descriptors
> vhost-user-blk-test: drop unused return value
> vhost-user-blk-test: fix races by using fd passing
>
> configure | 15 +
> contrib/libvhost-user/libvhost-user.h | 15 +-
> tests/qtest/libqos/libqtest.h | 25 +
> tests/qtest/libqos/vhost-user-blk.h | 48 ++
> block/export/export.c | 4 +-
> block/export/vhost-user-blk-server.c | 28 +-
> contrib/vhost-user-blk/vhost-user-blk.c | 2 +
> tests/qtest/libqos/vhost-user-blk.c | 129 ++++
> tests/qtest/libqtest.c | 76 ++-
> tests/qtest/vhost-user-blk-test.c | 843 ++++++++++++++++++++++++
> block/export/meson.build | 2 +-
> tests/qtest/libqos/meson.build | 1 +
> tests/qtest/meson.build | 2 +
> util/meson.build | 2 +-
> 14 files changed, 1151 insertions(+), 41 deletions(-)
> create mode 100644 tests/qtest/libqos/vhost-user-blk.h
> create mode 100644 tests/qtest/libqos/vhost-user-blk.c
> create mode 100644 tests/qtest/vhost-user-blk-test.c
>
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-10-30 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 17:35 [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 01/12] libvhost-user: follow QEMU comment style Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 02/12] configure: introduce --enable-vhost-user-blk-server Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 03/12] block/export: make vhost-user-blk config space little-endian Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 04/12] block/export: fix vhost-user-blk get_config() information leak Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 05/12] contrib/vhost-user-blk: fix " Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 06/12] test: new qTest case to test the vhost-user-blk-server Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 07/12] tests/qtest: add multi-queue test case to vhost-user-blk-test Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 08/12] libqtest: add qtest_socket_server() Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 09/12] vhost-user-blk-test: rename destroy_drive() to destroy_file() Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 10/12] vhost-user-blk-test: close fork child file descriptors Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 11/12] vhost-user-blk-test: drop unused return value Stefan Hajnoczi
2020-10-27 17:35 ` [PATCH 12/12] vhost-user-blk-test: fix races by using fd passing Stefan Hajnoczi
2020-10-30 12:42 ` Michael S. Tsirkin [this message]
2020-11-02 10:43 ` [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests Michael S. Tsirkin
2020-11-02 17:00 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030084155-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.