From: Guru Das Srinagesh <gurus@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Anirudh Ghayal <aghayal@codeaurora.org>
Subject: Re: [PATCH v4 2/3] bindings: pm8941-misc: Add support for VBUS detection
Date: Fri, 30 Oct 2020 16:37:42 -0700 [thread overview]
Message-ID: <20201030233742.GA29492@codeaurora.org> (raw)
In-Reply-To: <20201030133612.GB3721479@bogus>
On Fri, Oct 30, 2020 at 08:36:12AM -0500, Rob Herring wrote:
> On Wed, Oct 28, 2020 at 12:18:53AM -0700, Guru Das Srinagesh wrote:
> > Add compatible string that adds support for reporting VBUS detection
> > status that can be detected via a dedicated PMIC pin.
> >
> > Signed-off-by: Anirudh Ghayal <aghayal@codeaurora.org>
> > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> > ---
> > Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > index e8eea83..15e3749 100644
> > --- a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > +++ b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > @@ -15,18 +15,23 @@ description: |
> >
> > properties:
> > compatible:
> > + minItems: 1
> > items:
> > - const: qcom,pm8941-misc
> > + - const: qcom,pmd-vbus-det
>
> Do you really need another compatible here? Just detect this by having a
> 2nd interrupt.
Agreed; will drop this bit in the next patchset.
>
> >
> > reg:
> > maxItems: 1
> >
> > interrupts:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
> >
> > interrupt-names:
> > + minItems: 1
> > items:
> > - const: usb_id
> > + - const: usb_vbus
> >
> > required:
> > - compatible
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
next prev parent reply other threads:[~2020-10-30 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 7:18 [PATCH v4 0/3] Add support for VBUS detection Guru Das Srinagesh
2020-10-28 7:18 ` [PATCH v4 1/3] bindings: pm8941-misc: Convert bindings to YAML Guru Das Srinagesh
2020-10-30 13:33 ` Rob Herring
2020-10-28 7:18 ` [PATCH v4 2/3] bindings: pm8941-misc: Add support for VBUS detection Guru Das Srinagesh
2020-10-30 13:36 ` Rob Herring
2020-10-30 23:37 ` Guru Das Srinagesh [this message]
2020-10-28 7:18 ` [PATCH v4 3/3] extcon: qcom-spmi: " Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030233742.GA29492@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=aghayal@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.