From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F7EC55178 for ; Sat, 31 Oct 2020 12:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60D9320739 for ; Sat, 31 Oct 2020 12:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604146677; bh=hHp1qmsjV0wDANsgjHUiTIRnVbtGrlFEl/SuN5nWLEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HffVuLJ2CnILOnRGdVjpfeCbwa5ih261vu2RBcBc+njP2yRfpP6mSd+D+tl6kibRi MAm59mP00QETCaVFK6fxtKDXZBOrh+D30uBpXFngitRFlhPZJ9bJyX4YoGI/J/1tus ZQS9ZZySRFDvOJsoj60TcLeZ46StM8s7OBcN5DNI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbgJaMRx convert rfc822-to-8bit (ORCPT ); Sat, 31 Oct 2020 08:17:53 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40829 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726935AbgJaMRx (ORCPT ); Sat, 31 Oct 2020 08:17:53 -0400 Received: by mail-wm1-f65.google.com with SMTP id k18so5173096wmj.5; Sat, 31 Oct 2020 05:17:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WKzF1aaYbnVmrdWhOCJIvuCVQXHEwFndydQ7LCQLM48=; b=uMrXN3jhJacu5R/EzUuTLunep6fgZSHIlfPz/e7IPwkaCwsQjQJmA3ZEHUXd8XkXF1 Nd53PpnRSVmBCkO4PhrsiJ2r9pDo/e4voDtvB5f8dZp/VWNf6//M5r7m+q/fyLADDTv9 vWpllHbmDrXDE7WgHPS/6Y00JjYa0CqYb0b0asvZnUE1jW4fv4GkNLi79rHDE57mQjZh /vBcaj+TUIlVS1A5/aZwTxT4F4p/6dGVpazggZiDPTAE9zzdvBX7xslRLWvUAdW3V/t9 sT6MzVvuPQsqBQpvStpxm2g+wgtk9Wpd9aRdWvY4jDrufPWmQkj1ySPCkgoZBXJp7OJr ZHcQ== X-Gm-Message-State: AOAM530y3wsuLAaiV2zrxzcb4q2C0ltIUo/p2X986SWmOOuk9e15sdks cjYEL6kSVInr2IVKtEj+f426W+WcGlXzGg== X-Google-Smtp-Source: ABdhPJxtVxlOWJenfMblp90f/+WbEdzV8cTky1eQNG/79J3aKlrJViN3Ma99nExe5hJCGVj0D/9hNw== X-Received: by 2002:a1c:4b0c:: with SMTP id y12mr2090447wma.91.1604146670479; Sat, 31 Oct 2020 05:17:50 -0700 (PDT) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id r18sm15981833wrj.50.2020.10.31.05.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Oct 2020 05:17:49 -0700 (PDT) Date: Sat, 31 Oct 2020 13:17:47 +0100 From: Krzysztof Kozlowski To: Sylwester Nawrocki Cc: georgi.djakov@linaro.org, cw00.choi@samsung.com, devicetree@vger.kernel.org, robh+dt@kernel.org, a.swigon@samsung.com, myungjoo.ham@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs Message-ID: <20201031121747.GB9399@kozik-lap> References: <20201030125149.8227-1-s.nawrocki@samsung.com> <20201030125149.8227-3-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20201030125149.8227-3-s.nawrocki@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Oct 30, 2020 at 01:51:45PM +0100, Sylwester Nawrocki wrote: > This patch adds a generic interconnect driver for Exynos SoCs in order > to provide interconnect functionality for each "samsung,exynos-bus" > compatible device. > > The SoC topology is a graph (or more specifically, a tree) and its > edges are specified using the 'samsung,interconnect-parent' in the > DT. Due to unspecified relative probing order, -EPROBE_DEFER may be > propagated to ensure that the parent is probed before its children. > > Each bus is now an interconnect provider and an interconnect node as > well (cf. Documentation/interconnect/interconnect.rst), i.e. every bus > registers itself as a node. Node IDs are not hardcoded but rather > assigned dynamically at runtime. This approach allows for using this > driver with various Exynos SoCs. > > Frequencies requested via the interconnect API for a given node are > propagated to devfreq using dev_pm_qos_update_request(). Please note > that it is not an error when CONFIG_INTERCONNECT is 'n', in which > case all interconnect API functions are no-op. > > The bus-width DT property is to determine the interconnect data > width and traslate requested bandwidth to clock frequency for each > bus. > > Signed-off-by: Artur Świgoń > Signed-off-by: Sylwester Nawrocki > --- > Changes for v7: > - adjusted to the DT property changes: "interconnects" instead > of "samsung,interconnect-parent", "samsung,data-clk-ratio" > instead of "bus-width", > - adaptation to of_icc_get_from_provider() function changes > in v5.10-rc1. > > Changes for v6: > - corrected of_node dereferencing in exynos_icc_get_parent() > function, > - corrected initialization of icc_node->name so as to avoid > direct of_node->name dereferencing, > - added parsing of bus-width DT property. > > Changes for v5: > - adjust to renamed exynos,interconnect-parent-node property, > - use automatically generated platform device id as the interconect > node id instead of a now unavailable devfreq->id field, > - add icc_ prefix to some variables to make the code more self-commenting, > - use icc_nodes_remove() instead of icc_node_del() + icc_node_destroy(), > - adjust to exynos,interconnect-parent-node property rename to > samsung,interconnect-parent, > - converted to a separate platform driver in drivers/interconnect. > > --- > drivers/interconnect/Kconfig | 1 + > drivers/interconnect/Makefile | 1 + > drivers/interconnect/exynos/Kconfig | 6 ++ > drivers/interconnect/exynos/Makefile | 4 + > drivers/interconnect/exynos/exynos.c | 198 +++++++++++++++++++++++++++++++++++ How about naming the directory as "samsung"? I don't expect interconnect drivers for the old Samsung S3C or S5P platforms, but it would be consisteny with other names (memory, clk, pinctrl). How about adding separate maintainers entry for the driver with you and Artur (if he still works on this)? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5605CC388F7 for ; Sat, 31 Oct 2020 12:17:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 071672072C for ; Sat, 31 Oct 2020 12:17:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 071672072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D0E4D6E20F; Sat, 31 Oct 2020 12:17:52 +0000 (UTC) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFA0F6E20F for ; Sat, 31 Oct 2020 12:17:51 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id w23so5110677wmi.4 for ; Sat, 31 Oct 2020 05:17:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WKzF1aaYbnVmrdWhOCJIvuCVQXHEwFndydQ7LCQLM48=; b=itrPa9nR6XosHTVZUuvJlqegggME6ZTxn7UPMZY6licJhcNmJ3AhqpUN8dmkqkYgPE Sc82tR2ZtcfDllkmN5v3lAJps/LBXlyvlLLYS8zbr+G9VRuTwZ3AEr+si+yyKlDcPeWi P5tu6c4WCZLE+Ht9t8PKiHCLfDAIOm7hLyYqaU5d5TR8WVRZV4PSb1qt7GF/3mRy1T0w giAV5sjO48pBYA4cuIlh0VdzcXZpdADlMR/xsZ0Wl+rOkoqR3IdfcMZd6+V1sES8PyFS Q9J3j2tChEGwmtt6ABP/M8Oo/M7Fi5vFwofseMT3xpoeM3m+ZgzcPKWTRvls0akwsACa hDUA== X-Gm-Message-State: AOAM530VWhmoaGnnf7A65tkFK48sCvQ6D4Tfj/BGv95llEwy3KM2jk30 cTnyVUB36NA/tdOatUkLpTI= X-Google-Smtp-Source: ABdhPJxtVxlOWJenfMblp90f/+WbEdzV8cTky1eQNG/79J3aKlrJViN3Ma99nExe5hJCGVj0D/9hNw== X-Received: by 2002:a1c:4b0c:: with SMTP id y12mr2090447wma.91.1604146670479; Sat, 31 Oct 2020 05:17:50 -0700 (PDT) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id r18sm15981833wrj.50.2020.10.31.05.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Oct 2020 05:17:49 -0700 (PDT) Date: Sat, 31 Oct 2020 13:17:47 +0100 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs Message-ID: <20201031121747.GB9399@kozik-lap> References: <20201030125149.8227-1-s.nawrocki@samsung.com> <20201030125149.8227-3-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201030125149.8227-3-s.nawrocki@samsung.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-pm@vger.kernel.org, sw0312.kim@samsung.com, a.swigon@samsung.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, dri-devel@lists.freedesktop.org, georgi.djakov@linaro.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBPY3QgMzAsIDIwMjAgYXQgMDE6NTE6NDVQTSArMDEwMCwgU3lsd2VzdGVyIE5hd3Jv Y2tpIHdyb3RlOgo+IFRoaXMgcGF0Y2ggYWRkcyBhIGdlbmVyaWMgaW50ZXJjb25uZWN0IGRyaXZl ciBmb3IgRXh5bm9zIFNvQ3MgaW4gb3JkZXIKPiB0byBwcm92aWRlIGludGVyY29ubmVjdCBmdW5j dGlvbmFsaXR5IGZvciBlYWNoICJzYW1zdW5nLGV4eW5vcy1idXMiCj4gY29tcGF0aWJsZSBkZXZp Y2UuCj4gCj4gVGhlIFNvQyB0b3BvbG9neSBpcyBhIGdyYXBoIChvciBtb3JlIHNwZWNpZmljYWxs eSwgYSB0cmVlKSBhbmQgaXRzCj4gZWRnZXMgYXJlIHNwZWNpZmllZCB1c2luZyB0aGUgJ3NhbXN1 bmcsaW50ZXJjb25uZWN0LXBhcmVudCcgaW4gdGhlCj4gRFQuIER1ZSB0byB1bnNwZWNpZmllZCBy ZWxhdGl2ZSBwcm9iaW5nIG9yZGVyLCAtRVBST0JFX0RFRkVSIG1heSBiZQo+IHByb3BhZ2F0ZWQg dG8gZW5zdXJlIHRoYXQgdGhlIHBhcmVudCBpcyBwcm9iZWQgYmVmb3JlIGl0cyBjaGlsZHJlbi4K PiAKPiBFYWNoIGJ1cyBpcyBub3cgYW4gaW50ZXJjb25uZWN0IHByb3ZpZGVyIGFuZCBhbiBpbnRl cmNvbm5lY3Qgbm9kZSBhcwo+IHdlbGwgKGNmLiBEb2N1bWVudGF0aW9uL2ludGVyY29ubmVjdC9p bnRlcmNvbm5lY3QucnN0KSwgaS5lLiBldmVyeSBidXMKPiByZWdpc3RlcnMgaXRzZWxmIGFzIGEg bm9kZS4gTm9kZSBJRHMgYXJlIG5vdCBoYXJkY29kZWQgYnV0IHJhdGhlcgo+IGFzc2lnbmVkIGR5 bmFtaWNhbGx5IGF0IHJ1bnRpbWUuIFRoaXMgYXBwcm9hY2ggYWxsb3dzIGZvciB1c2luZyB0aGlz Cj4gZHJpdmVyIHdpdGggdmFyaW91cyBFeHlub3MgU29Dcy4KPiAKPiBGcmVxdWVuY2llcyByZXF1 ZXN0ZWQgdmlhIHRoZSBpbnRlcmNvbm5lY3QgQVBJIGZvciBhIGdpdmVuIG5vZGUgYXJlCj4gcHJv cGFnYXRlZCB0byBkZXZmcmVxIHVzaW5nIGRldl9wbV9xb3NfdXBkYXRlX3JlcXVlc3QoKS4gUGxl YXNlIG5vdGUKPiB0aGF0IGl0IGlzIG5vdCBhbiBlcnJvciB3aGVuIENPTkZJR19JTlRFUkNPTk5F Q1QgaXMgJ24nLCBpbiB3aGljaAo+IGNhc2UgYWxsIGludGVyY29ubmVjdCBBUEkgZnVuY3Rpb25z IGFyZSBuby1vcC4KPiAKPiBUaGUgYnVzLXdpZHRoIERUIHByb3BlcnR5IGlzIHRvIGRldGVybWlu ZSB0aGUgaW50ZXJjb25uZWN0IGRhdGEKPiB3aWR0aCBhbmQgdHJhc2xhdGUgcmVxdWVzdGVkIGJh bmR3aWR0aCB0byBjbG9jayBmcmVxdWVuY3kgZm9yIGVhY2gKPiBidXMuCj4gCj4gU2lnbmVkLW9m Zi1ieTogQXJ0dXIgxZp3aWdvxYQgPGEuc3dpZ29uQHNhbXN1bmcuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IFN5bHdlc3RlciBOYXdyb2NraSA8cy5uYXdyb2NraUBzYW1zdW5nLmNvbT4KPiAtLS0KPiBD aGFuZ2VzIGZvciB2NzoKPiAgLSBhZGp1c3RlZCB0byB0aGUgRFQgcHJvcGVydHkgY2hhbmdlczog ImludGVyY29ubmVjdHMiIGluc3RlYWQKPiAgICBvZiAic2Ftc3VuZyxpbnRlcmNvbm5lY3QtcGFy ZW50IiwgInNhbXN1bmcsZGF0YS1jbGstcmF0aW8iCj4gICAgaW5zdGVhZCBvZiAiYnVzLXdpZHRo IiwKPiAgLSBhZGFwdGF0aW9uIHRvIG9mX2ljY19nZXRfZnJvbV9wcm92aWRlcigpIGZ1bmN0aW9u IGNoYW5nZXMKPiAgICBpbiB2NS4xMC1yYzEuCj4gCj4gQ2hhbmdlcyBmb3IgdjY6Cj4gIC0gY29y cmVjdGVkIG9mX25vZGUgZGVyZWZlcmVuY2luZyBpbiBleHlub3NfaWNjX2dldF9wYXJlbnQoKQo+ ICAgIGZ1bmN0aW9uLAo+ICAtIGNvcnJlY3RlZCBpbml0aWFsaXphdGlvbiBvZiBpY2Nfbm9kZS0+ bmFtZSBzbyBhcyB0byBhdm9pZAo+ICAgIGRpcmVjdCBvZl9ub2RlLT5uYW1lIGRlcmVmZXJlbmNp bmcsCj4gIC0gYWRkZWQgcGFyc2luZyBvZiBidXMtd2lkdGggRFQgcHJvcGVydHkuCj4gCj4gQ2hh bmdlcyBmb3IgdjU6Cj4gIC0gYWRqdXN0IHRvIHJlbmFtZWQgZXh5bm9zLGludGVyY29ubmVjdC1w YXJlbnQtbm9kZSBwcm9wZXJ0eSwKPiAgLSB1c2UgYXV0b21hdGljYWxseSBnZW5lcmF0ZWQgcGxh dGZvcm0gZGV2aWNlIGlkIGFzIHRoZSBpbnRlcmNvbmVjdAo+ICAgIG5vZGUgaWQgaW5zdGVhZCBv ZiBhIG5vdyB1bmF2YWlsYWJsZSBkZXZmcmVxLT5pZCBmaWVsZCwKPiAgLSBhZGQgaWNjXyBwcmVm aXggdG8gc29tZSB2YXJpYWJsZXMgdG8gbWFrZSB0aGUgY29kZSBtb3JlIHNlbGYtY29tbWVudGlu ZywKPiAgLSB1c2UgaWNjX25vZGVzX3JlbW92ZSgpIGluc3RlYWQgb2YgaWNjX25vZGVfZGVsKCkg KyBpY2Nfbm9kZV9kZXN0cm95KCksCj4gIC0gYWRqdXN0IHRvIGV4eW5vcyxpbnRlcmNvbm5lY3Qt cGFyZW50LW5vZGUgcHJvcGVydHkgcmVuYW1lIHRvCj4gICAgc2Ftc3VuZyxpbnRlcmNvbm5lY3Qt cGFyZW50LAo+ICAtIGNvbnZlcnRlZCB0byBhIHNlcGFyYXRlIHBsYXRmb3JtIGRyaXZlciBpbiBk cml2ZXJzL2ludGVyY29ubmVjdC4KPiAKPiAtLS0KPiAgZHJpdmVycy9pbnRlcmNvbm5lY3QvS2Nv bmZpZyAgICAgICAgIHwgICAxICsKPiAgZHJpdmVycy9pbnRlcmNvbm5lY3QvTWFrZWZpbGUgICAg ICAgIHwgICAxICsKPiAgZHJpdmVycy9pbnRlcmNvbm5lY3QvZXh5bm9zL0tjb25maWcgIHwgICA2 ICsrCj4gIGRyaXZlcnMvaW50ZXJjb25uZWN0L2V4eW5vcy9NYWtlZmlsZSB8ICAgNCArCj4gIGRy aXZlcnMvaW50ZXJjb25uZWN0L2V4eW5vcy9leHlub3MuYyB8IDE5OCArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwoKSG93IGFib3V0IG5hbWluZyB0aGUgZGlyZWN0b3J5IGFzICJz YW1zdW5nIj8gSSBkb24ndCBleHBlY3QgaW50ZXJjb25uZWN0CmRyaXZlcnMgZm9yIHRoZSBvbGQg U2Ftc3VuZyBTM0Mgb3IgUzVQIHBsYXRmb3JtcywgYnV0IGl0IHdvdWxkIGJlCmNvbnNpc3Rlbnkg d2l0aCBvdGhlciBuYW1lcyAobWVtb3J5LCBjbGssIHBpbmN0cmwpLgoKSG93IGFib3V0IGFkZGlu ZyBzZXBhcmF0ZSBtYWludGFpbmVycyBlbnRyeSBmb3IgdGhlIGRyaXZlciB3aXRoIHlvdSBhbmQK QXJ0dXIgKGlmIGhlIHN0aWxsIHdvcmtzIG9uIHRoaXMpPwoKQmVzdCByZWdhcmRzLApLcnp5c3p0 b2YKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK