All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/8] package/optee-test: bump to version 3.11.0
Date: Sat, 31 Oct 2020 23:00:43 +0100	[thread overview]
Message-ID: <20201031230043.21190d90@windsurf> (raw)
In-Reply-To: <20201030075045.6960-6-etienne.carriere@linaro.org>

On Fri, 30 Oct 2020 08:50:43 +0100
Etienne Carriere <etienne.carriere@linaro.org> wrote:

> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_TOOLCHAIN_HAS_THREAD

You introduced a typo here by dropping the S.

> +	depends on !BR2_INSTALL_LIBSTDCPP

And this should have been:

	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP

indeed, the way you had written the conditions, the comment would only
displayed if the toolchain does not have threads *and* does not have
C++. But what we want is the comment to appear when the toolchain does
not have threads *or* does not have C++.

I fixed that up when applying. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-10-31 22:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  7:50 [Buildroot] [PATCH 1/8] configs/qemu_arm_vexpress_tz_defconfig: enable CXX toolchain Etienne Carriere
2020-10-30  7:50 ` [Buildroot] [PATCH 2/8] boot/optee-os: bump to version 3.11.0 Etienne Carriere
2020-10-30  7:50 ` [Buildroot] [PATCH 3/8] package/optee-client: " Etienne Carriere
2020-10-30  7:50 ` [Buildroot] [PATCH 4/8] package/optee-examples: " Etienne Carriere
2020-10-30  7:50 ` [Buildroot] [PATCH 5/8] package/optee-benchmark: " Etienne Carriere
2020-10-30  7:50 ` [Buildroot] [PATCH 6/8] package/optee-test: " Etienne Carriere
2020-10-31 22:00   ` Thomas Petazzoni [this message]
2020-11-02  6:12     ` Etienne Carriere
2020-10-30  7:50 ` [Buildroot] [PATCH 7/8] package/optee-test: add deps on openssl when enabled Etienne Carriere
2020-10-31 21:46   ` Thomas Petazzoni
2020-11-02  8:08     ` Etienne Carriere
2021-03-06 23:15   ` Yann E. MORIN
2021-03-06 23:29     ` Etienne Carriere
2021-03-17 19:09     ` Peter Korsgaard
2020-10-30  7:50 ` [Buildroot] [PATCH 8/8] configs/qemu_arm_vexpress_tz_defconfig: embed openssl library Etienne Carriere
2021-03-20 22:05   ` Thomas Petazzoni
2020-10-31 21:59 ` [Buildroot] [PATCH 1/8] configs/qemu_arm_vexpress_tz_defconfig: enable CXX toolchain Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201031230043.21190d90@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.