From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libglib2: fix util-linux-libs dependency
Date: Sun, 1 Nov 2020 14:03:58 +0100 [thread overview]
Message-ID: <20201101130358.GE2887157@scaer> (raw)
In-Reply-To: <20201101121536.1089498-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2020-11-01 13:15 +0100, Fabrice Fontaine spake thusly:
> Commit 2acaa86ce630f616b12aa92493e0269421c5bc97 replaced util-linux by
> util-linux-libs but this raises the following build failure:
>
> Makefile:585: *** util-linux-libs is in the dependency chain of libglib2 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop.
>
> To fix this build failure, use util-linux or util-linux-libs depending
> on BR2_PACKAGE_UTIL_LINUX_LIBS
OK, so this is exactly what I did not like in this util-linux vs
util-linus-libs split, and the fact that util-linux-libs is optional...
IMHO:
1. util-linux-libs must be enabled as soon as util-linux is enabled,
2. packages should build-depend on util-linux-libs, and never on
util-linux, and should 'select BR2_PACKAGE_UTIL_LINUX_LIBS' if
all they need is a library.
So, for now I'll apply this patch, because we do need a fix.
But ultimately, we wnat to sanitise this situation.
Regards,
Yann E. MORIN.
> Fixes:
> - http://autobuild.buildroot.org/results/8bf6360a343edd10c73a756ab86cdba727f9ea43
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libglib2/libglib2.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
> index 43fcb27fae..6e9dbd7b26 100644
> --- a/package/libglib2/libglib2.mk
> +++ b/package/libglib2/libglib2.mk
> @@ -86,8 +86,12 @@ endif
>
> ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
> LIBGLIB2_CONF_OPTS += -Dlibmount=enabled
> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBS),y)
> LIBGLIB2_DEPENDENCIES += util-linux-libs
> else
> +LIBGLIB2_DEPENDENCIES += util-linux
> +endif
> +else
> LIBGLIB2_CONF_OPTS += -Dlibmount=disabled
> endif
>
> --
> 2.28.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-11-01 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 12:15 [Buildroot] [PATCH 1/1] package/libglib2: fix util-linux-libs dependency Fabrice Fontaine
2020-11-01 13:03 ` Yann E. MORIN [this message]
2020-11-01 15:03 ` Fabrice Fontaine
2020-11-03 20:38 ` Yann E. MORIN
2020-12-01 21:12 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101130358.GE2887157@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.