Re: Linux Mint 20

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Sun, 1 Nov 2020 22:51:01 +0100
"filip.mutterer@gmail.com" <filip.mutterer@gmail.com> escreveu:

> Hi there,
> 
> I had the following error, which was easy to solve on Linux Mint 20:
> 
> Checking if the needed tools for Linux Mint 20 are available
> ERROR: please install "Proc::ProcessTable", otherwise, build won't work.
> I don't know distro Linux Mint 20. So, I can't provide you a hint with 
> the package names.
> Be welcome to contribute with a patch for media-build, by submitting a 
> distro-specific hint
> to linux-media@vger.kernel.org
> Build can't procceed as 1 dependency is missing at ./build line 276.

Never used Linux Mint. Yet, on a quick search for "ProcessTable linux-mint perl"

Showed a few packages:

	https://community.linuxmint.com/software/view/libproc-processtable-perl
	https://community.linuxmint.com/software/view/libproc-process-perl

It would be cool if you could send us a patch against ./build adding
support for Linux Mint dependencies.

If you take a look on it, you'll notice that it should be very easy to
teach the script about a new distro. You just need to add a new if
inside sub give_hints(). Something like:

	if ($system_release =~ /Linux Mint/) {
		give_mint_hints;
		return;
	}

And create a new subroutine telling the package names for:

	- the "lsdiff" command;
	- two perl packages: Digest::SHA and Proc::ProcessTable

Yet, as Mint is based on Debian/Ubuntu, perhaps just the enclosed
patch would be enough. 

> Here is what I installed to have it compile:
> 
> sudo cpan Proc::ProcessTable

Well, you can always install packages via cpan, although
this perl extension should very likely be there on all
distros.

Thanks,
Mauro

diff --git a/build b/build
index c2067e759213..2aa92cc2e819 100755
--- a/build
+++ b/build
@@ -207,6 +207,10 @@ sub give_hints()
 		give_ubuntu_hints;
 		return;
 	}
+	if ($system_release =~ /Linux Mint/) {
+		give_ubuntu_hints;
+		return;
+	}
 	if ($system_release =~ /Gentoo/) {
 		give_gentoo_hints;
 		return;