From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA5AC00A89 for ; Mon, 2 Nov 2020 07:34:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DE0A20719 for ; Mon, 2 Nov 2020 07:34:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oYhr+nX/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DE0A20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GU95VFbDH9lB0XE0DxAc4zLGzLjBOIeMc7nnK+Okydk=; b=oYhr+nX/3dDOxlM40wH3MUndD RmnZM1aT/8sFtNbk+TJT1/+Uqnc912i3ES97xb6MUMya5BPVfxzAou30nx+JhCXN9hGqzePIy3PU2 SA/CWO9IlbrkNlth1cimssZUw6fNRxbDN1z2VuNotb+EQXeEtp4b2mZRNVNU/nY6PvomVZK05tQnh c01I/UjO/C0GC8842tTrIu903p+wP2n2BAj5N3jrttPkhZBm9lOEJPl1y2sFJJKO4U7YboTcdZlHY dmz4yR9CJxNaJ8ZEauiMXC/mmbWnP/5UeG5R6uJSukuge8RgBAe+dBZw0ECcc40ZArtiVBwxxPQ9f GO1/UZUBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZULa-0007ih-98; Mon, 02 Nov 2020 07:33:46 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZULT-0007gt-Go; Mon, 02 Nov 2020 07:33:41 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 1D7DE20000A; Mon, 2 Nov 2020 07:32:59 +0000 (UTC) Date: Mon, 2 Nov 2020 08:32:58 +0100 From: Miquel Raynal To: =?UTF-8?B?6LW15Luq5bOw?= Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20201102083258.3a748c44@xps13> In-Reply-To: <20201102114503679684135@rock-chips.com> References: <20201028095326.15562-1-yifeng.zhao@rock-chips.com> <20201028095326.15562-3-yifeng.zhao@rock-chips.com> <0dabd80e-b281-be65-b8e2-da00f46964fb@gmail.com> <20201102114503679684135@rock-chips.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_023339_818006_840629C0 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , =?UTF-8?B?SGVpa29TdMO8Ym5lcg==?= , richard , linux-kernel , linux-rockchip , robh+dt , linux-mtd , Johan Jonker , linux-arm-kernel , vigneshr Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgrotbXku6rls7AgPHlpZmVuZy56aGFvQHJvY2stY2hpcHMuY29tPiB3cm90ZSBvbiBN b24sIDIgTm92IDIwMjAgMTE6NDY6MDQKKzA4MDA6Cgo+IEhpIEpvaGFuLAo+IAo+IHZvaWQgbmFu ZF9kZXNlbGVjdF90YXJnZXQoc3RydWN0IG5hbmRfY2hpcCAqY2hpcCkKPiB7Cj4gCWlmIChjaGlw LT5sZWdhY3kuc2VsZWN0X2NoaXApCj4gCQljaGlwLT5sZWdhY3kuc2VsZWN0X2NoaXAoY2hpcCwg LTEpOwo+IAo+IAljaGlwLT5jdXJfY3MgPSAtMTsKPiB9Cj4gCj4gSSBuZWVkIGFkZCB0aGUgY29k ZSBiZWxvdyBhbmQgaXQgd29yay4gCj4gCj4gwqAgwqBjaGlwLT5sZWdhY3kuc2VsZWN0X2NoaXAg PSBya19uZmNfc2VsZWN0X2NoaXA7Cj4gCj4gQnV0IEkgZm91bmTCoGFsbW9zdCBhbGwgbmFuZGMg ZHJpdmVycyBkbyBub3QgYWRkIHRoaXMgY29kZS4gSXMgdGhlcmUgYW55IG90aGVyIHdheSB0byBp bXBsZW1lbnQgaXTvvJ8KCkluZGVlZCwgd2UgZG9uJ3QgYWNjZXB0IG5ldyBjb2RlIHdlIGxlZ2Fj eSBiaW5kaW5ncy4KCkkgZG9uJ3QgdW5kZXJzdGFuZCB3aGF0IGV4dHJhIGNvbnN1bXB0aW9uIHlv dSBhcmUgdHJ5aW5nIHRvIGF2b2lkLApiZWNhdXNlIGlmIGl0IGlzIHRoZSBOQU5EIGRldmljZSBp dHNlbGYgdGhhdCBpcyBhYmxlIHRvIHNhdmUgcG93ZXIgd2hlbgppdCBnZXRzIHVuc2VsZWN0ZWQs IGl0J3MgcmVhbGx5IG5vbmUgb2YgeW91IGNvbnRyb2xsZXIncyBidXNpbmVzcy4KClBlcmhhcHMg aXQncyB0aGUgdGltZSB0byBmb2N1cyBvbiB0aGUgY29udHJvbGxlciBzdXBwb3J0IGFuZCB0dW5l IHRoZQpjb2RlIGJhc2UgbGF0ZXIgaW4gYSBiaWQgdG8gcmVkdWNlIGNvbnN1bXB0aW9uLgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1215BC00A89 for ; Mon, 2 Nov 2020 07:34:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99F2D20719 for ; Mon, 2 Nov 2020 07:34:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AgiESKj7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99F2D20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZDMAeh6siqg6KcFw4FqrsWmyNwk4c7YFTumwEqIJ4a0=; b=AgiESKj7uzyEfLk0qN+laFvGf wv3P7KrRcvdgl+qlRCBzU6sV1PMRM/iGW5S1dwTdK+KEViTP8qQk7NtThZX95tAyKrNH3QrHpySVw o1KXd9LiQ36tHJFP9SpVMYXJEShaKzOvpg1YO5mU5BpHZUQFAHFeZoPcbW2R2Jq9LBZUUUJXZIY+H ssZowfwDcjXbQ0ThcEsiV9lbz7n5GSoXttN2XJn9vJ6wrNpTHsFpOydv62sjaID39znYBIUovRS9I RokKVexD4xAoBK8QRj7ZiXgy1yxivkVnxMhZ1DtFgGIzqnFn/iYLer3y/DQMdH5s0y6Y08krR9ddX lkzjCL1VQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZULb-0007j1-HV; Mon, 02 Nov 2020 07:33:47 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZULT-0007gt-Go; Mon, 02 Nov 2020 07:33:41 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 1D7DE20000A; Mon, 2 Nov 2020 07:32:59 +0000 (UTC) Date: Mon, 2 Nov 2020 08:32:58 +0100 From: Miquel Raynal To: =?UTF-8?B?6LW15Luq5bOw?= Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20201102083258.3a748c44@xps13> In-Reply-To: <20201102114503679684135@rock-chips.com> References: <20201028095326.15562-1-yifeng.zhao@rock-chips.com> <20201028095326.15562-3-yifeng.zhao@rock-chips.com> <0dabd80e-b281-be65-b8e2-da00f46964fb@gmail.com> <20201102114503679684135@rock-chips.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_023339_818006_840629C0 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , =?UTF-8?B?SGVpa29TdMO8Ym5lcg==?= , richard , linux-kernel , linux-rockchip , robh+dt , linux-mtd , Johan Jonker , linux-arm-kernel , vigneshr Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGVsbG8sCgrotbXku6rls7AgPHlpZmVuZy56aGFvQHJvY2stY2hpcHMuY29tPiB3cm90ZSBvbiBN b24sIDIgTm92IDIwMjAgMTE6NDY6MDQKKzA4MDA6Cgo+IEhpIEpvaGFuLAo+IAo+IHZvaWQgbmFu ZF9kZXNlbGVjdF90YXJnZXQoc3RydWN0IG5hbmRfY2hpcCAqY2hpcCkKPiB7Cj4gCWlmIChjaGlw LT5sZWdhY3kuc2VsZWN0X2NoaXApCj4gCQljaGlwLT5sZWdhY3kuc2VsZWN0X2NoaXAoY2hpcCwg LTEpOwo+IAo+IAljaGlwLT5jdXJfY3MgPSAtMTsKPiB9Cj4gCj4gSSBuZWVkIGFkZCB0aGUgY29k ZSBiZWxvdyBhbmQgaXQgd29yay4gCj4gCj4gwqAgwqBjaGlwLT5sZWdhY3kuc2VsZWN0X2NoaXAg PSBya19uZmNfc2VsZWN0X2NoaXA7Cj4gCj4gQnV0IEkgZm91bmTCoGFsbW9zdCBhbGwgbmFuZGMg ZHJpdmVycyBkbyBub3QgYWRkIHRoaXMgY29kZS4gSXMgdGhlcmUgYW55IG90aGVyIHdheSB0byBp bXBsZW1lbnQgaXTvvJ8KCkluZGVlZCwgd2UgZG9uJ3QgYWNjZXB0IG5ldyBjb2RlIHdlIGxlZ2Fj eSBiaW5kaW5ncy4KCkkgZG9uJ3QgdW5kZXJzdGFuZCB3aGF0IGV4dHJhIGNvbnN1bXB0aW9uIHlv dSBhcmUgdHJ5aW5nIHRvIGF2b2lkLApiZWNhdXNlIGlmIGl0IGlzIHRoZSBOQU5EIGRldmljZSBp dHNlbGYgdGhhdCBpcyBhYmxlIHRvIHNhdmUgcG93ZXIgd2hlbgppdCBnZXRzIHVuc2VsZWN0ZWQs IGl0J3MgcmVhbGx5IG5vbmUgb2YgeW91IGNvbnRyb2xsZXIncyBidXNpbmVzcy4KClBlcmhhcHMg aXQncyB0aGUgdGltZSB0byBmb2N1cyBvbiB0aGUgY29udHJvbGxlciBzdXBwb3J0IGFuZCB0dW5l IHRoZQpjb2RlIGJhc2UgbGF0ZXIgaW4gYSBiaWQgdG8gcmVkdWNlIGNvbnN1bXB0aW9uLgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F16C00A89 for ; Mon, 2 Nov 2020 07:35:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21BC920719 for ; Mon, 2 Nov 2020 07:35:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X8mSFnGx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21BC920719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ql1vfCIl1L+SE7y1Aro5Swth7ZXs6FXqlErfTIgPiQc=; b=X8mSFnGxi7/0w/uB1DKY7VmJ9 5KQnZKUu528uE6hlyOvECjXm+VOu9M7x1Sp24rPnyRbT0KbsQBAshfdkwHqayInRnrvO96lwDoEoq u3t2clzSD+23stqF4wvb1E4nJ/klId6a+oydexlOYjP/hR+/b8bgO+7CXV0Voqnz5Ykz4VBBe6pJh kgdSjJb28xXway8LU+SuToZdOVelNQbkuD9NfWDXtVjxRup6w27VF78Mjf3GuHZZ+OhXEMJxVno8M dISU3aWpbVPQPge8MyjfYngs7xVaRdSsG/2DZ420wooEgdlnTatgOC6F1KkTkQJAx8tRbmka5CDFK sCZdZAaLQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZULY-0007iK-GZ; Mon, 02 Nov 2020 07:33:44 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZULT-0007gt-Go; Mon, 02 Nov 2020 07:33:41 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 1D7DE20000A; Mon, 2 Nov 2020 07:32:59 +0000 (UTC) Date: Mon, 2 Nov 2020 08:32:58 +0100 From: Miquel Raynal To: =?UTF-8?B?6LW15Luq5bOw?= Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20201102083258.3a748c44@xps13> In-Reply-To: <20201102114503679684135@rock-chips.com> References: <20201028095326.15562-1-yifeng.zhao@rock-chips.com> <20201028095326.15562-3-yifeng.zhao@rock-chips.com> <0dabd80e-b281-be65-b8e2-da00f46964fb@gmail.com> <20201102114503679684135@rock-chips.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_023339_818006_840629C0 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , =?UTF-8?B?SGVpa29TdMO8Ym5lcg==?= , richard , linux-kernel , linux-rockchip , robh+dt , linux-mtd , Johan Jonker , linux-arm-kernel , vigneshr Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgrotbXku6rls7AgPHlpZmVuZy56aGFvQHJvY2stY2hpcHMuY29tPiB3cm90ZSBvbiBN b24sIDIgTm92IDIwMjAgMTE6NDY6MDQKKzA4MDA6Cgo+IEhpIEpvaGFuLAo+IAo+IHZvaWQgbmFu ZF9kZXNlbGVjdF90YXJnZXQoc3RydWN0IG5hbmRfY2hpcCAqY2hpcCkKPiB7Cj4gCWlmIChjaGlw LT5sZWdhY3kuc2VsZWN0X2NoaXApCj4gCQljaGlwLT5sZWdhY3kuc2VsZWN0X2NoaXAoY2hpcCwg LTEpOwo+IAo+IAljaGlwLT5jdXJfY3MgPSAtMTsKPiB9Cj4gCj4gSSBuZWVkIGFkZCB0aGUgY29k ZSBiZWxvdyBhbmQgaXQgd29yay4gCj4gCj4gwqAgwqBjaGlwLT5sZWdhY3kuc2VsZWN0X2NoaXAg PSBya19uZmNfc2VsZWN0X2NoaXA7Cj4gCj4gQnV0IEkgZm91bmTCoGFsbW9zdCBhbGwgbmFuZGMg ZHJpdmVycyBkbyBub3QgYWRkIHRoaXMgY29kZS4gSXMgdGhlcmUgYW55IG90aGVyIHdheSB0byBp bXBsZW1lbnQgaXTvvJ8KCkluZGVlZCwgd2UgZG9uJ3QgYWNjZXB0IG5ldyBjb2RlIHdlIGxlZ2Fj eSBiaW5kaW5ncy4KCkkgZG9uJ3QgdW5kZXJzdGFuZCB3aGF0IGV4dHJhIGNvbnN1bXB0aW9uIHlv dSBhcmUgdHJ5aW5nIHRvIGF2b2lkLApiZWNhdXNlIGlmIGl0IGlzIHRoZSBOQU5EIGRldmljZSBp dHNlbGYgdGhhdCBpcyBhYmxlIHRvIHNhdmUgcG93ZXIgd2hlbgppdCBnZXRzIHVuc2VsZWN0ZWQs IGl0J3MgcmVhbGx5IG5vbmUgb2YgeW91IGNvbnRyb2xsZXIncyBidXNpbmVzcy4KClBlcmhhcHMg aXQncyB0aGUgdGltZSB0byBmb2N1cyBvbiB0aGUgY29udHJvbGxlciBzdXBwb3J0IGFuZCB0dW5l IHRoZQpjb2RlIGJhc2UgbGF0ZXIgaW4gYSBiaWQgdG8gcmVkdWNlIGNvbnN1bXB0aW9uLgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90175C00A89 for ; Mon, 2 Nov 2020 07:33:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CB5921556 for ; Mon, 2 Nov 2020 07:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbgKBHdh convert rfc822-to-8bit (ORCPT ); Mon, 2 Nov 2020 02:33:37 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:58773 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727961AbgKBHdh (ORCPT ); Mon, 2 Nov 2020 02:33:37 -0500 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 1D7DE20000A; Mon, 2 Nov 2020 07:32:59 +0000 (UTC) Date: Mon, 2 Nov 2020 08:32:58 +0100 From: Miquel Raynal To: =?UTF-8?B?6LW15Luq5bOw?= Cc: "Johan Jonker" , richard , vigneshr , robh+dt , devicetree , =?UTF-8?B?SGVpa29TdMO8Ym5lcg==?= , linux-kernel , linux-rockchip , linux-mtd , linux-arm-kernel Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20201102083258.3a748c44@xps13> In-Reply-To: <20201102114503679684135@rock-chips.com> References: <20201028095326.15562-1-yifeng.zhao@rock-chips.com> <20201028095326.15562-3-yifeng.zhao@rock-chips.com> <0dabd80e-b281-be65-b8e2-da00f46964fb@gmail.com> <20201102114503679684135@rock-chips.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, 赵仪峰 wrote on Mon, 2 Nov 2020 11:46:04 +0800: > Hi Johan, > > void nand_deselect_target(struct nand_chip *chip) > { > if (chip->legacy.select_chip) > chip->legacy.select_chip(chip, -1); > > chip->cur_cs = -1; > } > > I need add the code below and it work. > >    chip->legacy.select_chip = rk_nfc_select_chip; > > But I found almost all nandc drivers do not add this code. Is there any other way to implement it？ Indeed, we don't accept new code we legacy bindings. I don't understand what extra consumption you are trying to avoid, because if it is the NAND device itself that is able to save power when it gets unselected, it's really none of you controller's business. Perhaps it's the time to focus on the controller support and tune the code base later in a bid to reduce consumption. Thanks, Miquèl