From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B08EC00A89 for ; Mon, 2 Nov 2020 09:08:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDF6F22275 for ; Mon, 2 Nov 2020 09:08:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2h5JEb9N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cXswJPQd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDF6F22275 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uZJoUUMRi6TICaS0K0iSPT7AWJNl3Db3XmFDD/T0eWo=; b=2h5JEb9N6TR6a+o9Esqncu5cw FQtyyX25u888dGd1tH43VqR6e5iKAL8OLO52EmiCP27oFQc2IocEXma6OC3usYJNQ7fleuu7UNMdA p1up190iGKZR1jAumT3t6u8TPi8UTChDXv7Rx3QTbfaiTILRAIXw0FXMxevj56xn3qFP7Ni3VE/p4 QRW/GsSm2kQtlAuctnI12SYfmhVNDBJotcxsHxQ21YxFA7+sFbWrNaSWgbGYULoxLhqHDBXxSDHbQ 0qbD85o5sBCIaKtHIVI5DNwyZTzYLcZhAoehbknUO6rIMNy3lwitwPLnWuAzEEIgSVBBYXc2HaRgi SBoDV6sDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZVoI-0004PY-Mh; Mon, 02 Nov 2020 09:07:30 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZVoF-0004OX-WB for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 09:07:28 +0000 Received: by mail-wr1-x441.google.com with SMTP id g12so13588338wrp.10 for ; Mon, 02 Nov 2020 01:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=eh9Kx6+5Xx4FIWIBxaCzilDxfbxHKWBRRWt/h8bX/rs=; b=cXswJPQd/xUllwAxQLU9ImRdH4jkz6aY2eu6KPOyi/5Wp8hxpCloXAZPtyMpw4LyN4 4Bf5RY8F9D+7eziCzUE7qYHLQjLEXpww0+CXxnmHDVo7P+ItIQwWU+hpWQmJBUdXu7ne MLK+nap0AfUL2guPiI69O1B10CEgY0QWC9UqDCJPrwdHtMYlkl2yFOkzedgwX2xibZjX VVKvvUvqdmrM+yOjMNgos5Y9vetvGT+C4PYW7KCddIjdzIbm9YmxY5j9e/0dwI74zE+j 4fF81aw4jhdrcoGfgnegNs7OFAFydYwc452hKsZ5paJr+t6iel5fMcTDz2Rq5bf3KZh+ HoiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=eh9Kx6+5Xx4FIWIBxaCzilDxfbxHKWBRRWt/h8bX/rs=; b=eBfOfcODWjJ0pDy7/Wbe3bijDbKyjDeni37CTE+JLzi1kLDsd4HdH40Hc4U1vaB5yB Cds2IhZem04T+upPjnMI7f0VFAkZg5Ydm/LQZWrN8K/q2C8n2y0Yd7cvh+ff25Hw3ahj nBSaZm2oBE/PM0n4W4CSypT5+cBP7wMkoilyoitChlTdgldSGqDoZBhNLFaUzUkDs/Py SIWpTAm6l9jT4HT/2AAHqmEVKndg/4/h56u2K5IFHk1FBPLyCvndiLLpbVJWFQcEhLCI 3DMkuT4p8oR/3uvtUEAcRxiIzcG9p9SoFruf1yCpljDRHJTFB61/bE+T2KwJUJTJNrLh YtFg== X-Gm-Message-State: AOAM533jM09oZ3BcN7hiH05OsOlF7gqOQ8VYg4D2qYRHvyPTFcH8K2hj vTutYOCaPdw8IjNGVj9W6gzJ+Q== X-Google-Smtp-Source: ABdhPJw0w9JaxbWwnT/snRspP1tY78SzVXqSX83vCHLL7UV8wAMcDcQXL3WFGzMPjViP4T/aiIZ5Og== X-Received: by 2002:adf:c3c2:: with SMTP id d2mr19425327wrg.191.1604308047090; Mon, 02 Nov 2020 01:07:27 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id 66sm14827582wmb.3.2020.11.02.01.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 01:07:26 -0800 (PST) Date: Mon, 2 Nov 2020 09:07:24 +0000 From: Lee Jones To: Codrin.Ciubotariu@microchip.com Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Message-ID: <20201102090724.GG4127@dell> References: <20201030110702.886638-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_040728_115356_0F349F97 X-CRM114-Status: GOOD ( 27.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, richard.genoud@gmail.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAzMCBPY3QgMjAyMCwgQ29kcmluLkNpdWJvdGFyaXVAbWljcm9jaGlwLmNvbSB3cm90 ZToKCj4gT24gMzAuMTAuMjAyMCAxNTozOCwgTmljb2xhcyBGZXJyZSB3cm90ZToKPiA+IE9uIDMw LzEwLzIwMjAgYXQgMTI6MDcsIENvZHJpbiBDaXVib3Rhcml1IHdyb3RlOgo+ID4+IFRoZSAiYXRt ZWwsYXQ5MXNhbTkyNjAtdXNhcnQiIGRyaXZlciBpcyBhIE1GRCBkcml2ZXIsIHNvIGl0IG5lZWRz IAo+ID4+IHN1Yi1ub2Rlcwo+ID4+IHRvIG1hdGNoIHRoZSByZWdpc3RlcmVkIHBsYXRmb3JtIGRl dmljZS4gRm9yIHRoaXMgcmVhc29uLCB3ZSBhZGQgYSBzZXJpYWwKPiA+PiBzdWJub2RlIHRvIGFs bCB0aGUgImF0bWVsLGF0OTFzYW05MjYwLXVzYXJ0IiBzZXJpYWwgY29tcGF0aWJsZSBub2RzLiBU aGlzCj4gPj4gd2lsbCBhbHNvIHJlbW92ZSB0aGUgYm9vdCB3YXJuaW5nOgo+ID4+ICJhdG1lbF91 c2FydF9zZXJpYWw6IEZhaWxlZCB0byBsb2NhdGUgb2Zfbm9kZSBbaWQ6IC0yXSIKPiA+IAo+ID4g SSBkb24ndCByZW1lbWJlciB0aGlzIHdhcm5pbmcgd2FzIHJhaXNlZCBwcmV2aW91c2x5IGV2ZW4g aWYgdGhlIE1GRCAKPiA+IGRyaXZlciB3YXMgYWRkZWQgYSB3aGlsZSBhZ28gKFNlcHQuIDIwMTgp Lgo+ID4gCj4gPiBJIHdvdWxkIHNheSBpdCdzIGR1ZSB0byA0NjZhNjJkNzY0MmYgKCJtZmQ6IGNv cmU6IE1ha2UgYSBiZXN0IGVmZm9ydCAKPiA+IGF0dGVtcHQgdG8gbWF0Y2ggZGV2aWNlcyB3aXRo IHRoZSBjb3JyZWN0IG9mX25vZGVzIikgd2hpY2ggd2FzIGFkZGVkIG9uIAo+ID4gbWlkIEF1Z3Vz dCBhbmQgY29ycmVjdGVkIHdpdGggMjIzODBiNjVkYzcwICgibWZkOiBtZmQtY29yZTogRW5zdXJl IAo+ID4gZGlzYWJsZWQgZGV2aWNlcyBhcmUgaWdub3JlZCB3aXRob3V0IGVycm9yIikgYnV0IG1h eWJlIG5vdCBjb3ZlcmluZyBvdXIgCj4gPiBjYXNlLgo+IAo+IFdlbGwsIGl0J3Mgbm90IGNvdmVy aW5nIG91ciBlbmFibGVkIGRldmljZXMuCj4gCj4gPiAKPiA+IFNvLCB3ZWxsLCBJIGRvbid0IGtu b3cgd2hhdCdzIHRoZSBiZXN0IG9wdGlvbiB0byB0aGlzIGNoYW5nZS4gTW9yZW92ZXIsIAo+ID4g SSB3b3VsZCBzYXkgdGhhdCBhbGwgb3RoZXIgVVNBUlQgcmVsYXRlZCBwcm9wZXJ0aWVzIGdvIGlu dG8gdGhlIGNoaWxkIAo+ID4gbm90IGlmIHRoZXJlIGlzIGEgbmVlZCBmb3Igb25lLgo+ID4gCj4g PiBMZWUsIEkgc3VzcGVjdCB0aGF0IHdlJ3JlIG5vdCB0aGUgb25seSBvbmVzIGV4cGVyaWVuY2lu ZyB0aGlzIHVnbHkgCj4gPiB3YXJuaW5nIGR1cmluZyB0aGUgYm9vdCBsb2c6IGNhbiB5b3UgcG9p bnQgdXMgb3V0IGhvdyB0byBkZWFsIHdpdGggaXQgCj4gPiBmb3Igb3VyIGV4aXN0aW5nIGF0bWVs X3NlcmlhbC5jIHVzZXJzPwo+IAo+IE15IHVuZGVyc3RhZGluZyBpcyB0aGF0IHBsYXRmb3JtIGRl dmljZXMgcmVnaXN0ZXJlZCBieSBNRkQgc2hvdWxkIGhhdmUgYSAKPiBjb3JyZXNwb25kaWcgRFQg bm9kZS4gVGhlIHBhcnJlbnQgcHJvcGVydGllcyBhcmUgYWxzbyBhdmFpbGFibGUgZm9yIHRoZSAK PiBvdGhlciB1c2FydCBkZXZpY2UgKHVzYXJ0LXNwaSksIHNvIEkgdGhpbmsgd2Ugc2hvdWxkIGtl ZXAgdGhlbSBpbiB0aGUgCj4gcGFycmVudC4KCkRldmljZSBUcmVlIGFuZCBNRkQgYXJlIHVucmVs YXRlZC4gIE1GRHMgZG9uJ3QgZXZlbiBleGlzdCAtIHRoZXkgYXJlIGEKZmlnbWVudCBvZiBhIExp bnV4IEtlcm5lbCBFbmdpbmVlcidzIGltYWdpbmF0aW9uIC0gd2UgbWFkZSB0aGVtIHVwIQoKVGhl IERUIHNob3VsZCBkZXNjcmliZSB0aGUgaGFyZHdhcmUgYW5kIG5vdGhpbmcgZWxzZS4gIElmIHdl IHdpc2ggdG8KbWVzcyB3aXRoIGRldmljZXMgZm9yIG91ciBvd24gZ2FpbiBpLmUuIG9yZ2FuaXNl IHRoZW0gaW50byBkaWZmZXJlbnQKc3Vic3lzdGVtcywgd2UgaGF2ZSB0byBkbyB0aGF0IGluIHNv ZnR3YXJlLiAgVGhhdCdzIHdoYXQgTUZEIGlzIGZvci4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzm lq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3Jn IOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFj ZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD85C388F9 for ; Mon, 2 Nov 2020 09:07:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 263EA2074B for ; Mon, 2 Nov 2020 09:07:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cXswJPQd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728256AbgKBJH3 (ORCPT ); Mon, 2 Nov 2020 04:07:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728248AbgKBJH2 (ORCPT ); Mon, 2 Nov 2020 04:07:28 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 715E1C061A04 for ; Mon, 2 Nov 2020 01:07:28 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id k10so12272676wrw.13 for ; Mon, 02 Nov 2020 01:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=eh9Kx6+5Xx4FIWIBxaCzilDxfbxHKWBRRWt/h8bX/rs=; b=cXswJPQd/xUllwAxQLU9ImRdH4jkz6aY2eu6KPOyi/5Wp8hxpCloXAZPtyMpw4LyN4 4Bf5RY8F9D+7eziCzUE7qYHLQjLEXpww0+CXxnmHDVo7P+ItIQwWU+hpWQmJBUdXu7ne MLK+nap0AfUL2guPiI69O1B10CEgY0QWC9UqDCJPrwdHtMYlkl2yFOkzedgwX2xibZjX VVKvvUvqdmrM+yOjMNgos5Y9vetvGT+C4PYW7KCddIjdzIbm9YmxY5j9e/0dwI74zE+j 4fF81aw4jhdrcoGfgnegNs7OFAFydYwc452hKsZ5paJr+t6iel5fMcTDz2Rq5bf3KZh+ HoiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=eh9Kx6+5Xx4FIWIBxaCzilDxfbxHKWBRRWt/h8bX/rs=; b=ncXbwituQE2uYISMr+1jtZcVDxZ0+dlM6xHzDTY4xAfzF1/mEuizvtqr567ilxqGmu BIRgyOP79PF/WngdTGgpL6P28b8xvAb9TtvwU4Y8+bDCwha+YK5/zaDEOTo+NPM54gLP ggbyCU5LFeQwxuQfvwOhFLuJb4w9I2dPuAR+pCrdM5dyLXh8o/laJtl1/KuDigWsjcG8 192RkYrkrfWEkWd0exxYPkDYlxvZ7W07YB9LgQZ+Jri3OsJ75cmuw/AzTQztaHOPjLaD NGjs7P2igOTVespF8Bz0fWUHI65/3Z4VGKPOo/WLRsl3Ic7C2BwRJnAiCzKqm3bex1yB CQsA== X-Gm-Message-State: AOAM533cEUv1n+sJbWQaCcv8ATm82Lksh6RtVXe2S/4euUJTNUegCbtP 7fQi1PgL0KlP5ju/Lg8u9ZIGxwLFpxKmHQ== X-Google-Smtp-Source: ABdhPJw0w9JaxbWwnT/snRspP1tY78SzVXqSX83vCHLL7UV8wAMcDcQXL3WFGzMPjViP4T/aiIZ5Og== X-Received: by 2002:adf:c3c2:: with SMTP id d2mr19425327wrg.191.1604308047090; Mon, 02 Nov 2020 01:07:27 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id 66sm14827582wmb.3.2020.11.02.01.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 01:07:26 -0800 (PST) Date: Mon, 2 Nov 2020 09:07:24 +0000 From: Lee Jones To: Codrin.Ciubotariu@microchip.com Cc: Nicolas.Ferre@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, richard.genoud@gmail.com, alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Message-ID: <20201102090724.GG4127@dell> References: <20201030110702.886638-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 30 Oct 2020, Codrin.Ciubotariu@microchip.com wrote: > On 30.10.2020 15:38, Nicolas Ferre wrote: > > On 30/10/2020 at 12:07, Codrin Ciubotariu wrote: > >> The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs > >> sub-nodes > >> to match the registered platform device. For this reason, we add a serial > >> subnode to all the "atmel,at91sam9260-usart" serial compatible nods. This > >> will also remove the boot warning: > >> "atmel_usart_serial: Failed to locate of_node [id: -2]" > > > > I don't remember this warning was raised previously even if the MFD > > driver was added a while ago (Sept. 2018). > > > > I would say it's due to 466a62d7642f ("mfd: core: Make a best effort > > attempt to match devices with the correct of_nodes") which was added on > > mid August and corrected with 22380b65dc70 ("mfd: mfd-core: Ensure > > disabled devices are ignored without error") but maybe not covering our > > case. > > Well, it's not covering our enabled devices. > > > > > So, well, I don't know what's the best option to this change. Moreover, > > I would say that all other USART related properties go into the child > > not if there is a need for one. > > > > Lee, I suspect that we're not the only ones experiencing this ugly > > warning during the boot log: can you point us out how to deal with it > > for our existing atmel_serial.c users? > > My understading is that platform devices registered by MFD should have a > correspondig DT node. The parrent properties are also available for the > other usart device (usart-spi), so I think we should keep them in the > parrent. Device Tree and MFD are unrelated. MFDs don't even exist - they are a figment of a Linux Kernel Engineer's imagination - we made them up! The DT should describe the hardware and nothing else. If we wish to mess with devices for our own gain i.e. organise them into different subsystems, we have to do that in software. That's what MFD is for. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog