From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E35FCC00A89 for ; Mon, 2 Nov 2020 08:21:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66443206B7 for ; Mon, 2 Nov 2020 08:21:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NOHty0nB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66443206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K3kmjYapBcymVRySUBsFJ7hrEtwsEHEveNGZv0O8zPk=; b=NOHty0nB8rK2Wo5Wjp1kIFj7r L5io9jzAaYld/7V8VwqqEnG/e40kNDGO3+ed7kO28Z+DuAJfMIWt6dXDyPDsnAVWr4xKWC56Ds5ns 0ZC4QK10SFU7KvN3k0uLT8S4/OylWWMNHOiH034Gxt270z0KfozmwszXgTGLyyk2hBot4HgrAzDJL uDLBI5O+DZx0EwXzi9aeUXS5JqZaOhiY+Gs2l52uQIIOWlYvQMcK0KDpzrHxaSrqkDwLZyYnmxIj1 6ePxiSsdDVQBDXfhds6ndbU5wX7oJZpkBy2VGT/WFX0J0Po5b6DIC0wJG7RNSdCy0j90udx8inRqy 374ncgBGg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZV4r-0004MG-Qw; Mon, 02 Nov 2020 08:20:33 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZV4l-0004KW-0a; Mon, 02 Nov 2020 08:20:27 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 50205200015; Mon, 2 Nov 2020 08:20:22 +0000 (UTC) Date: Mon, 2 Nov 2020 09:20:21 +0100 From: Miquel Raynal To: =?UTF-8?B?6LW15Luq5bOw?= Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20201102092021.14159c03@xps13> In-Reply-To: <20201102161300764203144@rock-chips.com> References: <20201028095326.15562-1-yifeng.zhao@rock-chips.com> <20201028095326.15562-3-yifeng.zhao@rock-chips.com> <0dabd80e-b281-be65-b8e2-da00f46964fb@gmail.com> <20201102114503679684135@rock-chips.com> <20201102083258.3a748c44@xps13> <20201102161300764203144@rock-chips.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_032027_199392_20B69CC1 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , =?UTF-8?B?SGVpa29TdMO8Ym5lcg==?= , richard , linux-kernel , linux-rockchip , robh+dt , linux-mtd , Johan Jonker , linux-arm-kernel , vigneshr Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgWWlmZW5nLAoK6LW15Luq5bOwIDx5aWZlbmcuemhhb0Byb2NrLWNoaXBzLmNvbT4gd3JvdGUg b24gTW9uLCAyIE5vdiAyMDIwIDE2OjE0OjAxCiswODAwOgoKPiBIaSBNaXF1ZWwsCj4gCj4gVGhl IG5hbmRfYmFzZS5jIHdpbGwgY2FsbMKgbmFuZF9kZXNlbGVjdF90YXJnZXQgYWZ0ZXIgTkFORCBy ZWFkL3Byb2dyYW0uLi4gb3BzIGRvbmUsIGFuZCBzZXTCoHZhcmlhYmxlIGNoaXAtPmN1cl9jcyA9 IC0xLAo+IGJ1dCB0aGUgbmFuZCBjb250cm9sbGVyIGRvIG5vdGhpbmcgYW5kIHRoZSBjcyBvZiB0 aGUgTkFORCBkZXZpY2UgaXMgc3RpbGwgc2VsZWN0ZWQsIAo+IHNvIHRoZSBOQU5EIGRldmljZSDC oHdpbGwgbm90IGVudGVyIGF1dG8gcG93ZXIgc2F2ZSBtb2RlLgoKWWVzLCBJIG5lZWQgdG8gdGhp bmsgYWJvdXQgaXQgYWdhaW4uCgpXaGF0IEkgYW0gc2F5aW5nIGlzIHRoYXQgdGhpcyBoYXMgKm5v dGhpbmcqIHRvIGRvIHdpdGggdGhlIGNvbnRyb2xsZXIKZHJpdmVyIHlvdXIgYXJlIHRyeWluZyB0 byBtZXJnZS4gUGxlYXNlIGZvY3VzIG9uIHRoZSBiYXJlIGZlYXR1cmVzLgpPbmNlIHRoZXNlIHdp bGwgYmUgbWVyZ2VkLCBpdCB3aWxsIGJlIGVhc2llciB0byBwcm9wb3NlIGNoYW5nZXMgb24gdG9w Cm9mIGl0IHRvIGJyaW5nIG1vcmUgZmluZSBncmFpbmVkIGZlYXR1cmVzLgoKSXQncyB2MTMgYWxy ZWFkeSwgcGxlYXNlIGZvY3VzIG9uIHRoZSBjb250cm9sbGVyJ3MgYmFzaWMgZmVhdHVyZXMsCmlt cGxlbWVudCB0aGVtIGNvcnJlY3RseSBhbmQgaW4gYSBzZWNvbmQgdGltZSB3ZSdsbCB0aGluayBh Ym91dCB0aGUKcG93ZXIgY29uc3VtcHRpb24sIHdoYXQgZG8geW91IHRoaW5rPwoKVGhhbmtzLApN aXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08890C00A89 for ; Mon, 2 Nov 2020 08:20:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85E15206B7 for ; Mon, 2 Nov 2020 08:20:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FdFZgU31" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85E15206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tHzKztUai+VxIpmEVk5WHllxJJm1CFF3Qo2AP8Pej38=; b=FdFZgU315uZdmitfgbdNeJfQJ 4trVWvw+gq+U00lxgv1Jqp4WIGBqR6FBwK834UJjl+LNpBJSSdn2YOnjgFDjg3wNCxE/ftb7x+c4Y 9TrUWWyUVAMd93noybBL5Bdu0gjH6PHygbQ+ZhqJ+dL/Zlx3X434vw2DwPd9QuzkpNu25y1IumQhj A+gwv2hIXQ1KPPvutYapSqyOdp7AD2EtzdqcZp9fln7O2FYVPI384P0pCsQ8sbEcWggFtPHUClalq Y+r2DdmjFrBC6Jp5BeOhqj9kEf1e926g6z9bL5086xoaA86/4c03S9E/lxbU6VxTv2LYL1ofHwREE qfnkE9W4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZV4u-0004Mw-1o; Mon, 02 Nov 2020 08:20:36 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZV4l-0004KW-0a; Mon, 02 Nov 2020 08:20:27 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 50205200015; Mon, 2 Nov 2020 08:20:22 +0000 (UTC) Date: Mon, 2 Nov 2020 09:20:21 +0100 From: Miquel Raynal To: =?UTF-8?B?6LW15Luq5bOw?= Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20201102092021.14159c03@xps13> In-Reply-To: <20201102161300764203144@rock-chips.com> References: <20201028095326.15562-1-yifeng.zhao@rock-chips.com> <20201028095326.15562-3-yifeng.zhao@rock-chips.com> <0dabd80e-b281-be65-b8e2-da00f46964fb@gmail.com> <20201102114503679684135@rock-chips.com> <20201102083258.3a748c44@xps13> <20201102161300764203144@rock-chips.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_032027_199392_20B69CC1 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , =?UTF-8?B?SGVpa29TdMO8Ym5lcg==?= , richard , linux-kernel , linux-rockchip , robh+dt , linux-mtd , Johan Jonker , linux-arm-kernel , vigneshr Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgWWlmZW5nLAoK6LW15Luq5bOwIDx5aWZlbmcuemhhb0Byb2NrLWNoaXBzLmNvbT4gd3JvdGUg b24gTW9uLCAyIE5vdiAyMDIwIDE2OjE0OjAxCiswODAwOgoKPiBIaSBNaXF1ZWwsCj4gCj4gVGhl IG5hbmRfYmFzZS5jIHdpbGwgY2FsbMKgbmFuZF9kZXNlbGVjdF90YXJnZXQgYWZ0ZXIgTkFORCBy ZWFkL3Byb2dyYW0uLi4gb3BzIGRvbmUsIGFuZCBzZXTCoHZhcmlhYmxlIGNoaXAtPmN1cl9jcyA9 IC0xLAo+IGJ1dCB0aGUgbmFuZCBjb250cm9sbGVyIGRvIG5vdGhpbmcgYW5kIHRoZSBjcyBvZiB0 aGUgTkFORCBkZXZpY2UgaXMgc3RpbGwgc2VsZWN0ZWQsIAo+IHNvIHRoZSBOQU5EIGRldmljZSDC oHdpbGwgbm90IGVudGVyIGF1dG8gcG93ZXIgc2F2ZSBtb2RlLgoKWWVzLCBJIG5lZWQgdG8gdGhp bmsgYWJvdXQgaXQgYWdhaW4uCgpXaGF0IEkgYW0gc2F5aW5nIGlzIHRoYXQgdGhpcyBoYXMgKm5v dGhpbmcqIHRvIGRvIHdpdGggdGhlIGNvbnRyb2xsZXIKZHJpdmVyIHlvdXIgYXJlIHRyeWluZyB0 byBtZXJnZS4gUGxlYXNlIGZvY3VzIG9uIHRoZSBiYXJlIGZlYXR1cmVzLgpPbmNlIHRoZXNlIHdp bGwgYmUgbWVyZ2VkLCBpdCB3aWxsIGJlIGVhc2llciB0byBwcm9wb3NlIGNoYW5nZXMgb24gdG9w Cm9mIGl0IHRvIGJyaW5nIG1vcmUgZmluZSBncmFpbmVkIGZlYXR1cmVzLgoKSXQncyB2MTMgYWxy ZWFkeSwgcGxlYXNlIGZvY3VzIG9uIHRoZSBjb250cm9sbGVyJ3MgYmFzaWMgZmVhdHVyZXMsCmlt cGxlbWVudCB0aGVtIGNvcnJlY3RseSBhbmQgaW4gYSBzZWNvbmQgdGltZSB3ZSdsbCB0aGluayBh Ym91dCB0aGUKcG93ZXIgY29uc3VtcHRpb24sIHdoYXQgZG8geW91IHRoaW5rPwoKVGhhbmtzLApN aXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpM aW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJv Y2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0918BC388F2 for ; Mon, 2 Nov 2020 08:22:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FD36206B7 for ; Mon, 2 Nov 2020 08:22:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NVOUeuj0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FD36206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=apKPQm5KD4wMLZWwjAR3tEUgvxdzVu1hJjCqdklZNXM=; b=NVOUeuj0zqYDSEq1qKjYTeFRs Z/dDu4MQ44d5lK2jJH3zXNuqss2g8FClCr+Bs3wXe9phXSFi+hEEgA0bPnP/95mZeG6kGg99Dkpy0 YyJk6IQg6K/0hQmv90oXpeEwnojhcuFcdLkcM+FZuRlieD6pxZDdC+hB6CnLin8CZ6ikaIBGJvOjW szoG/ltrL/EH9Adzm89GPMpfhEX2wXDyR5NytPREmdnIlAR1lrzZTZ44iDCSwgL65dperIBvoGNRI LcX5b0GR2r8Jk6J1/4cpmfUDTdiXTBwRPbbWrg0U9fI6DvMSEvif+kSkambOps3IF9ldJRrwio9WJ seiEr28XQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZV4o-0004LZ-3l; Mon, 02 Nov 2020 08:20:30 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZV4l-0004KW-0a; Mon, 02 Nov 2020 08:20:27 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 50205200015; Mon, 2 Nov 2020 08:20:22 +0000 (UTC) Date: Mon, 2 Nov 2020 09:20:21 +0100 From: Miquel Raynal To: =?UTF-8?B?6LW15Luq5bOw?= Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20201102092021.14159c03@xps13> In-Reply-To: <20201102161300764203144@rock-chips.com> References: <20201028095326.15562-1-yifeng.zhao@rock-chips.com> <20201028095326.15562-3-yifeng.zhao@rock-chips.com> <0dabd80e-b281-be65-b8e2-da00f46964fb@gmail.com> <20201102114503679684135@rock-chips.com> <20201102083258.3a748c44@xps13> <20201102161300764203144@rock-chips.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_032027_199392_20B69CC1 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , =?UTF-8?B?SGVpa29TdMO8Ym5lcg==?= , richard , linux-kernel , linux-rockchip , robh+dt , linux-mtd , Johan Jonker , linux-arm-kernel , vigneshr Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgWWlmZW5nLAoK6LW15Luq5bOwIDx5aWZlbmcuemhhb0Byb2NrLWNoaXBzLmNvbT4gd3JvdGUg b24gTW9uLCAyIE5vdiAyMDIwIDE2OjE0OjAxCiswODAwOgoKPiBIaSBNaXF1ZWwsCj4gCj4gVGhl IG5hbmRfYmFzZS5jIHdpbGwgY2FsbMKgbmFuZF9kZXNlbGVjdF90YXJnZXQgYWZ0ZXIgTkFORCBy ZWFkL3Byb2dyYW0uLi4gb3BzIGRvbmUsIGFuZCBzZXTCoHZhcmlhYmxlIGNoaXAtPmN1cl9jcyA9 IC0xLAo+IGJ1dCB0aGUgbmFuZCBjb250cm9sbGVyIGRvIG5vdGhpbmcgYW5kIHRoZSBjcyBvZiB0 aGUgTkFORCBkZXZpY2UgaXMgc3RpbGwgc2VsZWN0ZWQsIAo+IHNvIHRoZSBOQU5EIGRldmljZSDC oHdpbGwgbm90IGVudGVyIGF1dG8gcG93ZXIgc2F2ZSBtb2RlLgoKWWVzLCBJIG5lZWQgdG8gdGhp bmsgYWJvdXQgaXQgYWdhaW4uCgpXaGF0IEkgYW0gc2F5aW5nIGlzIHRoYXQgdGhpcyBoYXMgKm5v dGhpbmcqIHRvIGRvIHdpdGggdGhlIGNvbnRyb2xsZXIKZHJpdmVyIHlvdXIgYXJlIHRyeWluZyB0 byBtZXJnZS4gUGxlYXNlIGZvY3VzIG9uIHRoZSBiYXJlIGZlYXR1cmVzLgpPbmNlIHRoZXNlIHdp bGwgYmUgbWVyZ2VkLCBpdCB3aWxsIGJlIGVhc2llciB0byBwcm9wb3NlIGNoYW5nZXMgb24gdG9w Cm9mIGl0IHRvIGJyaW5nIG1vcmUgZmluZSBncmFpbmVkIGZlYXR1cmVzLgoKSXQncyB2MTMgYWxy ZWFkeSwgcGxlYXNlIGZvY3VzIG9uIHRoZSBjb250cm9sbGVyJ3MgYmFzaWMgZmVhdHVyZXMsCmlt cGxlbWVudCB0aGVtIGNvcnJlY3RseSBhbmQgaW4gYSBzZWNvbmQgdGltZSB3ZSdsbCB0aGluayBh Ym91dCB0aGUKcG93ZXIgY29uc3VtcHRpb24sIHdoYXQgZG8geW91IHRoaW5rPwoKVGhhbmtzLApN aXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C8DC00A89 for ; Mon, 2 Nov 2020 08:20:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDC4722272 for ; Mon, 2 Nov 2020 08:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728118AbgKBIU1 convert rfc822-to-8bit (ORCPT ); Mon, 2 Nov 2020 03:20:27 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:42807 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727802AbgKBIU1 (ORCPT ); Mon, 2 Nov 2020 03:20:27 -0500 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 50205200015; Mon, 2 Nov 2020 08:20:22 +0000 (UTC) Date: Mon, 2 Nov 2020 09:20:21 +0100 From: Miquel Raynal To: =?UTF-8?B?6LW15Luq5bOw?= Cc: "Johan Jonker" , richard , vigneshr , robh+dt , devicetree , =?UTF-8?B?SGVpa29TdMO8Ym5lcg==?= , linux-kernel , linux-rockchip , linux-mtd , linux-arm-kernel Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20201102092021.14159c03@xps13> In-Reply-To: <20201102161300764203144@rock-chips.com> References: <20201028095326.15562-1-yifeng.zhao@rock-chips.com> <20201028095326.15562-3-yifeng.zhao@rock-chips.com> <0dabd80e-b281-be65-b8e2-da00f46964fb@gmail.com> <20201102114503679684135@rock-chips.com> <20201102083258.3a748c44@xps13> <20201102161300764203144@rock-chips.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Yifeng, 赵仪峰 wrote on Mon, 2 Nov 2020 16:14:01 +0800: > Hi Miquel, > > The nand_base.c will call nand_deselect_target after NAND read/program... ops done, and set variable chip->cur_cs = -1, > but the nand controller do nothing and the cs of the NAND device is still selected, > so the NAND device  will not enter auto power save mode. Yes, I need to think about it again. What I am saying is that this has *nothing* to do with the controller driver your are trying to merge. Please focus on the bare features. Once these will be merged, it will be easier to propose changes on top of it to bring more fine grained features. It's v13 already, please focus on the controller's basic features, implement them correctly and in a second time we'll think about the power consumption, what do you think? Thanks, Miquèl