All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] lib/tst_kconfig: Make use of boolean expression eval
Date: Mon, 2 Nov 2020 11:38:20 +0100	[thread overview]
Message-ID: <20201102103820.GA7653@yuki.lan> (raw)
In-Reply-To: <CAEemH2cOcAuoPcks4FPaTaS-THtjPvy+=uB3oGsnTSNp_umpMg@mail.gmail.com>

Hi!
> But a tiny issue was found from my test, the tst_kconfig_check() would be
> failed to parse expression if reverse the sequence of the above string.
> 
> i.e.
> -       "CONFIG_MMU & CONFIG_EXT4_FS=m",
> +       "CONFIG_EXT4_FS=m & CONFIG_MMU",
> (Core dumped here)
> 
> But trying with =Num, it gets different errors:
> 
> "CONFIG_MMU & CONFIG_PGTABLE_LEVELS=4",
> (works well)
> 
> "CONFIG_PGTABLE_LEVELS=4 & CONFIG_MMU",
> (print Expression not satisfied!)

Looks like off by one in the strncmp() in the map() function, I will fix
that as well and send v3.

Thanks a lot for testing.

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2020-11-02 10:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 11:04 [LTP] [PATCH v2 0/2] Add support for kconfig constraints Cyril Hrubis
2020-10-27 11:04 ` [LTP] [PATCH v2 1/2] lib: Add generic boolean expression parser and eval Cyril Hrubis
2020-10-27 15:33   ` Richard Palethorpe
2020-10-27 15:45     ` Cyril Hrubis
2020-10-27 11:04 ` [LTP] [PATCH v2 2/2] lib/tst_kconfig: Make use of boolean expression eval Cyril Hrubis
2020-10-28  3:45   ` Xiao Yang
2020-10-29 10:39     ` Cyril Hrubis
2020-11-02 10:17   ` Li Wang
2020-11-02 10:38     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102103820.GA7653@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.