From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4BD3C00A89 for ; Mon, 2 Nov 2020 11:10:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 578172076E for ; Mon, 2 Nov 2020 11:10:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vELR8v+N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SFTaJqUZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 578172076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5l+4/HhtKcXRWcgvA5DTWaNYM0/uFwKr+gfpL6Qtekc=; b=vELR8v+N4ZtuOBTzI7n8WKTQS WgsZ+tMmQxWjlJGbtSCI4lhxbbLzcawFwbTygsGr7xLp1ImE1Sjwq/eCk412aRE9bWeuox4NGVuFC B5KhwEv1Yz96526qW63ZUIp4Wp7wk+vVdbRWFKh2D3GKnom3ihbiLzlwbMaM1Jl0ed6N/98Tix03I PLM8fsh7RCQ1kP4urpGRjJmyRF7uKVo3cBruehvYYL4587Y3CTkOjFWNfF2rNDBq+m90jJlX9xLia Z0VmcidBO/FYaTSPCvpoWhweHS1WM6YtDI795k+nyOYd1qzKZmq1RyGRHPzBQ/WMtRgvhVQIGjk3C 8aYMsgEaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZXiF-0001Nn-FS; Mon, 02 Nov 2020 11:09:23 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZXiC-0001NI-Ir for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 11:09:21 +0000 Received: by mail-wr1-x443.google.com with SMTP id 33so3292983wrl.7 for ; Mon, 02 Nov 2020 03:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VNKBzuaah0h5Gb4hoIVZS3da51nQlrhYLCe3rboP11A=; b=SFTaJqUZtfkkrRI+Q9PY7VNO+a17R1kSjOtcGWcaK+CHErqUB/F2Sa3e/th8FMVcft TmgOCOTjq94XbgaUawLyPonyp5k6zXmfsTXV2c5U2H+oduVvMBHQfZoavcR4nCSVOAxY e9miCE9Iipq2MYWzeP+MDbIykjcYJY+WAAjOiKwHs2xr6UcrxbOO0I4ouSqA68j46mYC azb5mdF9wHULmZ2Cz6u54K2cSvx11STFdyPcDl9bInHXHq70Q98O+NKEk1Fq5YRZnsyK jacisaqaE9vTEUxs00HqwMo7MjuVoK8RkPC2yy5gcPU41D7lRiAA0z6d6utzoX9PXCjd w/bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VNKBzuaah0h5Gb4hoIVZS3da51nQlrhYLCe3rboP11A=; b=gC3BQ5w5np54Hx2kWU7+j8vX4s7CMJAyHLQfcR7jAPvCvo/gbqxcqEpWJwgHdGapyu OoTDkxeo6g1kYbMX1EvSVQbEDEFpcWiZPgwVHJ9gK2FPM6FLjv5YEPIdaWXVE2/aun2n 6kafKwoSE1Xe2KJqtqbrAf0XjdEEdFb+ceb3gzj7z9v0iFiE5bGrJdxmS+2l/JS09zdL Al9T9/n+X935UF3EZRyHJcVeei/ddYlQ6kLeloVZNPZa6yKyeEZxKasMDdWlUfdrDbOr ArFmlkgarw8AvDqLzfWBreFS5KtTPIccDExKd/8OI83FmmMtJuRKt6em4PWKs0/ewzny 4SHw== X-Gm-Message-State: AOAM531ByKvl3p2yLJh8vg7TZekc4ChYPt4NNLRDOnCEd1ewSEOEvuaj JW2xjcaRSF9aqAUjBqGOfVVyVw== X-Google-Smtp-Source: ABdhPJxNCPU3ugtaw5SbDq9bRqIQsbfrQpZvvzXXHChVJFEpTyYgy/+pQ1unhh72pfJOI5cuZzTiTw== X-Received: by 2002:adf:df91:: with SMTP id z17mr18923542wrl.379.1604315359142; Mon, 02 Nov 2020 03:09:19 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id y185sm14706772wmb.29.2020.11.02.03.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:09:18 -0800 (PST) Date: Mon, 2 Nov 2020 11:09:16 +0000 From: Lee Jones To: Daniel Vetter Subject: Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier Message-ID: <20201102110916.GK4127@dell> References: <20201030181822.570402-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_060920_699222_255DE30E X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg KH , Russell King , stable , Linux Kernel Mailing List , Peilin Ye , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwMiBOb3YgMjAyMCwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gT24gRnJpLCBPY3Qg MzAsIDIwMjAgYXQgNzoxOCBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPiB3cm90 ZToKPiA+Cj4gPiBDb21taXQgMDllNWIzZmQ1NjcyICgiRm9udHM6IFN1cHBvcnQgRk9OVF9FWFRS QV9XT1JEUyBtYWNyb3MgZm9yCj4gPiBidWlsdC1pbiBmb250cyIpIGludHJvZHVjZWQgdGhlIGZv bGxvd2luZyBlcnJvciB3aGVuIGJ1aWxkaW5nCj4gPiBycGNfZGVmY29uZmlnIChvbmx5IHRoaXMg YnVpbGQgYXBwZWFycyB0byBiZSBhZmZlY3RlZCk6Cj4gPgo+ID4gIGBhY29ybmRhdGFfOHg4JyBy ZWZlcmVuY2VkIGluIHNlY3Rpb24gYC50ZXh0JyBvZiBhcmNoL2FybS9ib290L2NvbXByZXNzZWQv bGxfY2hhcl93ci5vOgo+ID4gICAgIGRlZmluZWQgaW4gZGlzY2FyZGVkIHNlY3Rpb24gYC5kYXRh JyBvZiBhcmNoL2FybS9ib290L2NvbXByZXNzZWQvZm9udC5vCj4gPiAgYGFjb3JuZGF0YV84eDgn IHJlZmVyZW5jZWQgaW4gc2VjdGlvbiBgLmRhdGEucmVsLnJvJyBvZiBhcmNoL2FybS9ib290L2Nv bXByZXNzZWQvZm9udC5vOgo+ID4gICAgIGRlZmluZWQgaW4gZGlzY2FyZGVkIHNlY3Rpb24gYC5k YXRhJyBvZiBhcmNoL2FybS9ib290L2NvbXByZXNzZWQvZm9udC5vCj4gPiAgbWFrZVszXTogKioq IFsvc2NyYXRjaC9saW51eC9hcmNoL2FybS9ib290L2NvbXByZXNzZWQvTWFrZWZpbGU6MTkxOiBh cmNoL2FybS9ib290L2NvbXByZXNzZWQvdm1saW51eF0gRXJyb3IgMQo+ID4gIG1ha2VbMl06ICoq KiBbL3NjcmF0Y2gvbGludXgvYXJjaC9hcm0vYm9vdC9NYWtlZmlsZTo2MTogYXJjaC9hcm0vYm9v dC9jb21wcmVzc2VkL3ZtbGludXhdIEVycm9yIDIKPiA+ICBtYWtlWzFdOiAqKiogWy9zY3JhdGNo L2xpbnV4L2FyY2gvYXJtL01ha2VmaWxlOjMxNzogekltYWdlXSBFcnJvciAyCj4gPgo+ID4gVGhl IC5kYXRhIHNlY3Rpb24gaXMgZGlzY2FyZGVkIGF0IGxpbmsgdGltZS4gIFJlaW5zdGF0aW5nCj4g PiBhY29ybmRhdGFfOHg4IGFzIGNvbnN0IGVuc3VyZXMgaXQgaXMgc3RpbGwgYXZhaWxhYmxlIGFm dGVyIGxpbmtpbmcuCj4gPgo+ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgo+ID4gQ2M6 IFJ1c3NlbGwgS2luZyA8bGludXhAYXJtbGludXgub3JnLnVrPgo+ID4gU2lnbmVkLW9mZi1ieTog TGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiAKPiBTaG91bGRuJ3Qgd2UgYWRkIHRo ZSBjb25zdCB0byBhbGwgb2YgdGhlbSwgZm9yIGNvbnNpc3RlbmN5PwoKVGhlIHRob3VnaHQgZGlk IGNyb3NzIG15IG1pbmQuICBIb3dldmVyLCBJIGRvIG5vdCBzZWUgYW55IGZ1cnRoZXIKaXNzdWVz IHdoaWNoIG5lZWQgYWRkcmVzc2luZy4gIE5vciBkbyBJIGhhdmUgYW55IHZpc2liaWxpdHkgaW50 byB3aGF0Cmlzc3VlcyBtYXkgYmUgY2F1c2VkIGJ5IGRvaW5nIHNvLiAgVGhlIG9ubHkgdGhpbmcg SSBrbm93IGZvciBzdXJlIGlzCnRoYXQgdGhpcyBwYXRjaCBmaXhlcyB0aGUgY29tcGlsZSBlcnJv ciBwZXJ0YWluZWQgdG8gaW4gdGhlIGNvbW1pdAptZXNzYWdlLCBhbmQgSSdkIGxpa2UgZm9yIHRo aXMgZml4IHRvIGJlIGFzIGF0b21pYyBhcyBwb3NzaWJsZSwgYXMKaXQncyBkZXNpZ25lZCB0byBi ZSByb3V0ZWQgdGhyb3VnaCB0aGUgU3RhYmxlL0xUUyB0cmVlcy4KCi0tIApMZWUgSm9uZXMgW+ad jueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFy by5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJv OiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10189C388F2 for ; Mon, 2 Nov 2020 11:09:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4A5A223BE for ; Mon, 2 Nov 2020 11:09:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SFTaJqUZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728444AbgKBLJW (ORCPT ); Mon, 2 Nov 2020 06:09:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728288AbgKBLJW (ORCPT ); Mon, 2 Nov 2020 06:09:22 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 906C2C0617A6 for ; Mon, 2 Nov 2020 03:09:20 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id x7so14104394wrl.3 for ; Mon, 02 Nov 2020 03:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VNKBzuaah0h5Gb4hoIVZS3da51nQlrhYLCe3rboP11A=; b=SFTaJqUZtfkkrRI+Q9PY7VNO+a17R1kSjOtcGWcaK+CHErqUB/F2Sa3e/th8FMVcft TmgOCOTjq94XbgaUawLyPonyp5k6zXmfsTXV2c5U2H+oduVvMBHQfZoavcR4nCSVOAxY e9miCE9Iipq2MYWzeP+MDbIykjcYJY+WAAjOiKwHs2xr6UcrxbOO0I4ouSqA68j46mYC azb5mdF9wHULmZ2Cz6u54K2cSvx11STFdyPcDl9bInHXHq70Q98O+NKEk1Fq5YRZnsyK jacisaqaE9vTEUxs00HqwMo7MjuVoK8RkPC2yy5gcPU41D7lRiAA0z6d6utzoX9PXCjd w/bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VNKBzuaah0h5Gb4hoIVZS3da51nQlrhYLCe3rboP11A=; b=IirRacX0UQcMjKfy87RSgE0fICBHO6GV1fQzKnTj6bpIN43bZR6eQpdoXmi5i0y1uq Yxkjj1ONiEYHF2rsiKsq998OMU10bOyPG/cXXlbVjUd8Q3f6vCKcgKFC6U0J488ACZdS qxtv88S1J4HDpNCauRujJDgem69ROjH5JmZFXR3rTk6mR359VnkDraQErFph6luOyCHN fViCW/QsYdDaRycSvV7reFvwsLJx2C7TOh8+MnIDB1++KR9HHpG8KkelIIb/pYzgv2GW iUtbKAbHwimatYiOD0vStdA8tSdLCtoQKOZUzVNLQjgOYhfYA5tYPGNkMuqOHbIW5V4m njPg== X-Gm-Message-State: AOAM531kDmG4gbFsiSmbcluI2MZM1TdIWzuOlF00REI29G2zefb4/2X2 N1KAaIrsmv+/nWeGuIXPDKIRMg== X-Google-Smtp-Source: ABdhPJxNCPU3ugtaw5SbDq9bRqIQsbfrQpZvvzXXHChVJFEpTyYgy/+pQ1unhh72pfJOI5cuZzTiTw== X-Received: by 2002:adf:df91:: with SMTP id z17mr18923542wrl.379.1604315359142; Mon, 02 Nov 2020 03:09:19 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id y185sm14706772wmb.29.2020.11.02.03.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:09:18 -0800 (PST) Date: Mon, 2 Nov 2020 11:09:16 +0000 From: Lee Jones To: Daniel Vetter Cc: Greg KH , Peilin Ye , Linux ARM , Linux Kernel Mailing List , stable , Russell King Subject: Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier Message-ID: <20201102110916.GK4127@dell> References: <20201030181822.570402-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Nov 2020, Daniel Vetter wrote: > On Fri, Oct 30, 2020 at 7:18 PM Lee Jones wrote: > > > > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for > > built-in fonts") introduced the following error when building > > rpc_defconfig (only this build appears to be affected): > > > > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o: > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o: > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1 > > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2 > > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2 > > > > The .data section is discarded at link time. Reinstating > > acorndata_8x8 as const ensures it is still available after linking. > > > > Cc: > > Cc: Russell King > > Signed-off-by: Lee Jones > > Shouldn't we add the const to all of them, for consistency? The thought did cross my mind. However, I do not see any further issues which need addressing. Nor do I have any visibility into what issues may be caused by doing so. The only thing I know for sure is that this patch fixes the compile error pertained to in the commit message, and I'd like for this fix to be as atomic as possible, as it's designed to be routed through the Stable/LTS trees. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog