From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D9D1C00A89 for ; Mon, 2 Nov 2020 11:31:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD77122275 for ; Mon, 2 Nov 2020 11:31:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0+4rrUgD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m5bLNXPJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD77122275 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cqyPRXsIzXCzEWekN+qYaEZDdUtuCa3m1S/YUXxDUEY=; b=0+4rrUgDpZZIeHsMmDVEJejG0 98UBYClGRz/XztXbY9tK+u9pI5/Xmj1oMrH0u4KVshEfOPol+AiVHpJIAAR62V+LeMmw0il3r9ZXC S/EN3tnakn0fE2eSW4oyLso2PSJtDXMhuilmtiygG4wqnDBMNqh4bl8ysPOMeLvQcOisoyP+KihNt zshxOkG0l96o657GDIB81NqCoYL7yvubLnUhdHZwuD4OZPy5VMWvqTAtMEhu2n/zgmGS7YhZ1ztVc X0HrX0bmGDdeBzu+HnrJF84xci5bmbxdTOTPW/BiKgwctgCkwGvmuZfhM1enUJUjUNEuxe/m5xWRS EQoLlU/0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZY2r-0003w1-Pw; Mon, 02 Nov 2020 11:30:41 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZY2o-0003v4-BE for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 11:30:39 +0000 Received: by mail-wm1-x343.google.com with SMTP id p22so9036514wmg.3 for ; Mon, 02 Nov 2020 03:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=i8P+1ihFPTbcqcdmnuv8HM9WxJxCIqZJiXX7QB+7i7w=; b=m5bLNXPJlIXPe6vWNe3sFFSqDvuKpn8KQElblDrEAUjPPJ2eqIzNOrD3K/kopR8Ase RSAPoUZhcDDx3dQFrjjHC1QIKuuD6JSsE7It14yxKziSIBvaSZXu33sWRJ7uDViuTbvl 9kL2L2H4wJNIMI/GCwrvWmmHkxvHRxlISY03JRMcZALik0l9m0WgQj/dslfRvAR1yxC+ eAwXE3y4fJ/pPTlC7Ag+jgR1TRLjYFw4KpXIH93q62PTyU6cogjAnQzL15l4NPVyZ8iA nG47OUy2+XRjE47dt1+j+COQE96+FTrP+xnGYV6RMYjFEvlaVqGW2ZVkKtbaHZPn3xJz gzzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=i8P+1ihFPTbcqcdmnuv8HM9WxJxCIqZJiXX7QB+7i7w=; b=cnUgxB1QuR5aXDE8CG3BiVhnf+96LnEzrKdvawQnH6aNth8t8IMK8Bwro8VFwnG5nT znkEkphdXYfyr+5Qj6Xp8f1AjkPUJBisIJ+QX2/n1RPPXRNnFO9srZWRVEUpt9n6TT3T UvosePrnp6A6HOUT8d154C0pDu3terbCLsZ4rKFEvELrGvLeaN7iJSj8d90T8IHbLzwX hCNjpzL+6fHDA/Eyau/l0xN7wWmUG4EkRd2x//BYZKhsZvnbpvjOSLdG9cV46fkmsmB9 fmaxTvfx6WHvCwRzG+rv93WcfB8ei6tzt1RWMbr1RXZcOqcr9AnZLstQ+CJkajWf/cgX tVcg== X-Gm-Message-State: AOAM531F8GyYIZ7U514Kxs/ewvTLwYnshhj1jcXeHNYdyni2sCmcTudm uhGftKgnZI3bRruio8YiyZZv/w== X-Google-Smtp-Source: ABdhPJyukRK6/lVQPZEtTsbbFN0/7S8cO1TDZDy93qCXars0Ldc0ODXaZPWGpf44BJ2D8ZiOzJUMJg== X-Received: by 2002:a7b:ce85:: with SMTP id q5mr16890502wmj.35.1604316637217; Mon, 02 Nov 2020 03:30:37 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id b136sm14536930wmb.21.2020.11.02.03.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:30:36 -0800 (PST) Date: Mon, 2 Nov 2020 11:30:34 +0000 From: Lee Jones To: Daniel Vetter Subject: Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier Message-ID: <20201102113034.GL4127@dell> References: <20201030181822.570402-1-lee.jones@linaro.org> <20201102110916.GK4127@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_063038_507677_805ADE97 X-CRM114-Status: GOOD ( 25.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg KH , Russell King , stable , Linux Kernel Mailing List , Peilin Ye , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwMiBOb3YgMjAyMCwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gT24gTW9uLCBOb3Yg MiwgMjAyMCBhdCAxMjowOSBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPiB3cm90 ZToKPiA+Cj4gPiBPbiBNb24sIDAyIE5vdiAyMDIwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4K PiA+ID4gT24gRnJpLCBPY3QgMzAsIDIwMjAgYXQgNzoxOCBQTSBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IENvbW1pdCAwOWU1YjNmZDU2NzIg KCJGb250czogU3VwcG9ydCBGT05UX0VYVFJBX1dPUkRTIG1hY3JvcyBmb3IKPiA+ID4gPiBidWls dC1pbiBmb250cyIpIGludHJvZHVjZWQgdGhlIGZvbGxvd2luZyBlcnJvciB3aGVuIGJ1aWxkaW5n Cj4gPiA+ID4gcnBjX2RlZmNvbmZpZyAob25seSB0aGlzIGJ1aWxkIGFwcGVhcnMgdG8gYmUgYWZm ZWN0ZWQpOgo+ID4gPiA+Cj4gPiA+ID4gIGBhY29ybmRhdGFfOHg4JyByZWZlcmVuY2VkIGluIHNl Y3Rpb24gYC50ZXh0JyBvZiBhcmNoL2FybS9ib290L2NvbXByZXNzZWQvbGxfY2hhcl93ci5vOgo+ ID4gPiA+ICAgICBkZWZpbmVkIGluIGRpc2NhcmRlZCBzZWN0aW9uIGAuZGF0YScgb2YgYXJjaC9h cm0vYm9vdC9jb21wcmVzc2VkL2ZvbnQubwo+ID4gPiA+ICBgYWNvcm5kYXRhXzh4OCcgcmVmZXJl bmNlZCBpbiBzZWN0aW9uIGAuZGF0YS5yZWwucm8nIG9mIGFyY2gvYXJtL2Jvb3QvY29tcHJlc3Nl ZC9mb250Lm86Cj4gPiA+ID4gICAgIGRlZmluZWQgaW4gZGlzY2FyZGVkIHNlY3Rpb24gYC5kYXRh JyBvZiBhcmNoL2FybS9ib290L2NvbXByZXNzZWQvZm9udC5vCj4gPiA+ID4gIG1ha2VbM106ICoq KiBbL3NjcmF0Y2gvbGludXgvYXJjaC9hcm0vYm9vdC9jb21wcmVzc2VkL01ha2VmaWxlOjE5MTog YXJjaC9hcm0vYm9vdC9jb21wcmVzc2VkL3ZtbGludXhdIEVycm9yIDEKPiA+ID4gPiAgbWFrZVsy XTogKioqIFsvc2NyYXRjaC9saW51eC9hcmNoL2FybS9ib290L01ha2VmaWxlOjYxOiBhcmNoL2Fy bS9ib290L2NvbXByZXNzZWQvdm1saW51eF0gRXJyb3IgMgo+ID4gPiA+ICBtYWtlWzFdOiAqKiog Wy9zY3JhdGNoL2xpbnV4L2FyY2gvYXJtL01ha2VmaWxlOjMxNzogekltYWdlXSBFcnJvciAyCj4g PiA+ID4KPiA+ID4gPiBUaGUgLmRhdGEgc2VjdGlvbiBpcyBkaXNjYXJkZWQgYXQgbGluayB0aW1l LiAgUmVpbnN0YXRpbmcKPiA+ID4gPiBhY29ybmRhdGFfOHg4IGFzIGNvbnN0IGVuc3VyZXMgaXQg aXMgc3RpbGwgYXZhaWxhYmxlIGFmdGVyIGxpbmtpbmcuCj4gPiA+ID4KPiA+ID4gPiBDYzogPHN0 YWJsZUB2Z2VyLmtlcm5lbC5vcmc+Cj4gPiA+ID4gQ2M6IFJ1c3NlbGwgS2luZyA8bGludXhAYXJt bGludXgub3JnLnVrPgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVz QGxpbmFyby5vcmc+Cj4gPiA+Cj4gPiA+IFNob3VsZG4ndCB3ZSBhZGQgdGhlIGNvbnN0IHRvIGFs bCBvZiB0aGVtLCBmb3IgY29uc2lzdGVuY3k/Cj4gPgo+ID4gVGhlIHRob3VnaHQgZGlkIGNyb3Nz IG15IG1pbmQuICBIb3dldmVyLCBJIGRvIG5vdCBzZWUgYW55IGZ1cnRoZXIKPiA+IGlzc3VlcyB3 aGljaCBuZWVkIGFkZHJlc3NpbmcuICBOb3IgZG8gSSBoYXZlIGFueSB2aXNpYmlsaXR5IGludG8g d2hhdAo+ID4gaXNzdWVzIG1heSBiZSBjYXVzZWQgYnkgZG9pbmcgc28uICBUaGUgb25seSB0aGlu ZyBJIGtub3cgZm9yIHN1cmUgaXMKPiA+IHRoYXQgdGhpcyBwYXRjaCBmaXhlcyB0aGUgY29tcGls ZSBlcnJvciBwZXJ0YWluZWQgdG8gaW4gdGhlIGNvbW1pdAo+ID4gbWVzc2FnZSwgYW5kIEknZCBs aWtlIGZvciB0aGlzIGZpeCB0byBiZSBhcyBhdG9taWMgYXMgcG9zc2libGUsIGFzCj4gPiBpdCdz IGRlc2lnbmVkIHRvIGJlIHJvdXRlZCB0aHJvdWdoIHRoZSBTdGFibGUvTFRTIHRyZWVzLgo+IAo+ IFRoZSB0cm91YmxlIGlzIHRoYXQgaWYgd2Ugb25seSBtYWtlIG9uZSBvZiB0aGVtIGNvbnN0LCB0 aGVuIGl0J2xsIHRha2UKPiBzbyBtdWNoIGxvbmdlciB0byBoaXQgYW55IGlzc3VlcyBkdWUgdG8g Y29kZSBub3QgaGFuZGxpbmcgdGhpcwo+IGNvcnJlY3RseS4gQmVpbmcgY29uc2lzdGVudCB3aXRo IGFsbCBmb250cyBzb3VuZHMgbGlrZSB0aGUgYmVzdAo+IGFwcHJvYWNoLgo+IAo+IEFuZCB0aGUg b3JpZ2luYWwgcGF0Y2ggdGhhdCBsb3N0IHRoZSBjb25zdCBmb3IgdGhlIGFkZGl0aW9uYWwgZGF0 YQo+IGFsc28gd2VudCB0aHJvdWdoIGNjOiBzdGFibGUgZm9yIGFsbCBmb250cyB0b2dldGhlci4g U28gdGhhdCBzaG91bGRuJ3QKPiBiZSB0aGUgaG9sZC11cC4KCk15IHBsYW4gd2FzIHRvIGtlZXAg dGhlIGZpeCBhcyBzaW1wbGUgYXMgcG9zc2libGUuCgpUaGlzIGlzIG9ubHkgYW4gaXNzdWUgZHVl IHRvIHRoZSBvZGQgaGFuZGxpbmcgb2YgdGhlIGNvbXByZXNzZWQgQXJtCmltYWdlIHdoaWNoIGV4 Y2x1c2l2ZWx5IHJlZmVyZW5jZXMgJ2Fjb3JuZGF0YV84eDgnIGFuZCBkaXNjYXJkcyBpdCdzCi5k YXRhIHNlY3Rpb24uCgpJIGFtIGhhcHB5IHRvIGdvIHdpdGggdGhlIG1ham9yaXR5IG9uIHRoaXMg dGhvdWdoLgoKRG9lcyBhbnlvbmUgZWxzZSBoYXZlIGFuIG9waW5pb24/CgotLSAKTGVlIEpvbmVz IFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpM aW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExp bmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D72CC2D0A3 for ; Mon, 2 Nov 2020 11:30:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C443122275 for ; Mon, 2 Nov 2020 11:30:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m5bLNXPJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728754AbgKBLam (ORCPT ); Mon, 2 Nov 2020 06:30:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbgKBLai (ORCPT ); Mon, 2 Nov 2020 06:30:38 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86CBCC061A04 for ; Mon, 2 Nov 2020 03:30:38 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id 205so1394852wma.4 for ; Mon, 02 Nov 2020 03:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=i8P+1ihFPTbcqcdmnuv8HM9WxJxCIqZJiXX7QB+7i7w=; b=m5bLNXPJlIXPe6vWNe3sFFSqDvuKpn8KQElblDrEAUjPPJ2eqIzNOrD3K/kopR8Ase RSAPoUZhcDDx3dQFrjjHC1QIKuuD6JSsE7It14yxKziSIBvaSZXu33sWRJ7uDViuTbvl 9kL2L2H4wJNIMI/GCwrvWmmHkxvHRxlISY03JRMcZALik0l9m0WgQj/dslfRvAR1yxC+ eAwXE3y4fJ/pPTlC7Ag+jgR1TRLjYFw4KpXIH93q62PTyU6cogjAnQzL15l4NPVyZ8iA nG47OUy2+XRjE47dt1+j+COQE96+FTrP+xnGYV6RMYjFEvlaVqGW2ZVkKtbaHZPn3xJz gzzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=i8P+1ihFPTbcqcdmnuv8HM9WxJxCIqZJiXX7QB+7i7w=; b=d/X6s6AW5ODSxEEtYFCAPL+oRz20v0XZdpQI6njjZJSP9xWva0trwgTu0m43fN7zNB gDLojvl+xAg1ZR0HbPm5JARI64SRjJDWT/cmj04+ruTCJRrwF72erCa2QoC4qy0tEfpb XR4iJEbrM7jn/vn0hP9wvpRKBsS0vXvzKVf7MRsxLf/muRBGSXVzlKyuxErcz2ySNOvx lVH6II7gtHu0T7pPRvYVBd6NTtGorjGuv/FMVLH+s+BAEO5TnVd8dM9sLJinajaLt+7+ 43HzUnRZcX3kIXwE6PKOXFq42J39s2af4wNRov0tuGv82TCaBp9qi5fe+E1vpl8B5wWW ivgA== X-Gm-Message-State: AOAM531c8wXAOkS8ROi7GnJL+0T8MJZQ5rTA8Zl+9Hsl1qdOcQR14iRx oe4HpbxrxQR9DGsjhR9YkKZJ5g== X-Google-Smtp-Source: ABdhPJyukRK6/lVQPZEtTsbbFN0/7S8cO1TDZDy93qCXars0Ldc0ODXaZPWGpf44BJ2D8ZiOzJUMJg== X-Received: by 2002:a7b:ce85:: with SMTP id q5mr16890502wmj.35.1604316637217; Mon, 02 Nov 2020 03:30:37 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id b136sm14536930wmb.21.2020.11.02.03.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:30:36 -0800 (PST) Date: Mon, 2 Nov 2020 11:30:34 +0000 From: Lee Jones To: Daniel Vetter Cc: Greg KH , Peilin Ye , Linux ARM , Linux Kernel Mailing List , stable , Russell King Subject: Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier Message-ID: <20201102113034.GL4127@dell> References: <20201030181822.570402-1-lee.jones@linaro.org> <20201102110916.GK4127@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Nov 2020, Daniel Vetter wrote: > On Mon, Nov 2, 2020 at 12:09 PM Lee Jones wrote: > > > > On Mon, 02 Nov 2020, Daniel Vetter wrote: > > > > > On Fri, Oct 30, 2020 at 7:18 PM Lee Jones wrote: > > > > > > > > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for > > > > built-in fonts") introduced the following error when building > > > > rpc_defconfig (only this build appears to be affected): > > > > > > > > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o: > > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o: > > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1 > > > > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2 > > > > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2 > > > > > > > > The .data section is discarded at link time. Reinstating > > > > acorndata_8x8 as const ensures it is still available after linking. > > > > > > > > Cc: > > > > Cc: Russell King > > > > Signed-off-by: Lee Jones > > > > > > Shouldn't we add the const to all of them, for consistency? > > > > The thought did cross my mind. However, I do not see any further > > issues which need addressing. Nor do I have any visibility into what > > issues may be caused by doing so. The only thing I know for sure is > > that this patch fixes the compile error pertained to in the commit > > message, and I'd like for this fix to be as atomic as possible, as > > it's designed to be routed through the Stable/LTS trees. > > The trouble is that if we only make one of them const, then it'll take > so much longer to hit any issues due to code not handling this > correctly. Being consistent with all fonts sounds like the best > approach. > > And the original patch that lost the const for the additional data > also went through cc: stable for all fonts together. So that shouldn't > be the hold-up. My plan was to keep the fix as simple as possible. This is only an issue due to the odd handling of the compressed Arm image which exclusively references 'acorndata_8x8' and discards it's .data section. I am happy to go with the majority on this though. Does anyone else have an opinion? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog