From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F2CC00A89 for ; Mon, 2 Nov 2020 12:31:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6061E208B6 for ; Mon, 2 Nov 2020 12:31:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WdWPS69F"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G1YSAkrh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6061E208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=viU5vvd03zR7MlN8lOBqkR2x9QAT3LMlgHfxseepVJc=; b=WdWPS69F4gMkpTdIpzt4jOrVv L2ZvmMPYDe6HpwYTAeZQDpoAtqpuBNrVc0xRY3qdM7knrcZxGGHokw6YXTkDQtuDfbiOfGlq4DrVC MC/u8/4fg06Nu9JwZ7exifTXOlLR/wA8AWdjVGxn2YadX49BJy5iFnhNJeJAbT+IdLEToZWHZEFUH ebBTRHQEdBKyT++Yi+m4snkscDtkj6PtkPm905l+gwwNihaQ+lODLpXcreDSV6dK4XAutqFQ2ZV3Z WDIcFIDVj6TfNNfy26eLkKgoTLRKIbXB9nWWS7F5AjULqLOacqo29XfgFDfH5pf+pMxNsdffthcUu vTcvN4Diw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZYyG-0007Fg-Bj; Mon, 02 Nov 2020 12:30:00 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZYyC-0007EZ-K6 for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 12:29:57 +0000 Received: by mail-wm1-x32d.google.com with SMTP id c9so7669504wml.5 for ; Mon, 02 Nov 2020 04:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4ILeNdi6oZHwCJ6iUbV3quJceEqtA1JSpxIiTg6qDXc=; b=G1YSAkrhaSYGxB3ZzXLFbutEnLIugxjFS/MnHvwogKJ/2z9t6lYistGV8bYmpqP6tr bblR8mBLvTeJ1fhCVf6rwZPdXoxj0ggzYVdS/Boub9l/Km3XhxqMjTeRGteaeIHEtb3y 5jgrMQkRG7MiScwoe8GTo5azdVwCfrm8jFEXmgReGPv3Ml7rzoBYDu36ZD8wM0NkUniP 4DiPp1ycgkolSM8Mkibl4pMVti5RxZN+FpPQgCUCmECtLqib47VmUFugMi+22C6rHGuj a3IDhz7wmWyxQVj7oDiyBIav9n4OAS+RiRevgZv23EvNPhBofheeruXXF74Sp8fz0+ri aj0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4ILeNdi6oZHwCJ6iUbV3quJceEqtA1JSpxIiTg6qDXc=; b=arm8MgD8Qo296u2sIm/JURXIbdhJ18lD+TF7vXk5xCHpq0b3FmR2G/X0P5QX6EUY4F 5bRiYWUxIjQKR2NgtY8KXCndu1HYpbxv2cygEv1TW/l3TfTBK5dEHYvOd/MN5qf2j5XA O6jwdE1BufGWZmep3T0//ZC80zJ8siphmHgbFBwKn0Mcqt3RNcrAGZE2sZgccitf5/LW 6sJia4dE4TRdY3IN0WGQMklomrPUD0Ki8fpTbU98RfZen5eCJEoIc2+7eIw030lzDR41 AW7CBBgmmSbmwx3pPPnB0H8WJZvql16p2hfUXPy9OIMIQpW+YxtVR3Q2vKt8qag3Q+De DfPA== X-Gm-Message-State: AOAM53346/WAH7WQ9NI4aHEk5Ct0hFbt1WWPB0OqoyC/OtRGTD3Twm51 do8mQJ6/6Eyob5z3jqjR8SPBwQ== X-Google-Smtp-Source: ABdhPJwUIfYXvZE9GcYuAEbLNWA2EEvj2uHM3TWkdRQSTGZfJMk9FgilHnSAFA8PxIJijlcW1NsSSw== X-Received: by 2002:a7b:c015:: with SMTP id c21mr17247812wmb.22.1604320194705; Mon, 02 Nov 2020 04:29:54 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id p13sm21671382wrt.73.2020.11.02.04.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 04:29:54 -0800 (PST) Date: Mon, 2 Nov 2020 12:29:52 +0000 From: Lee Jones To: Codrin.Ciubotariu@microchip.com Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Message-ID: <20201102122952.GB4488@dell> References: <20201030110702.886638-1-codrin.ciubotariu@microchip.com> <20201102090122.GF4127@dell> <780303c7-2c32-f2e1-c9ce-1e2ee6bf0533@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <780303c7-2c32-f2e1-c9ce-1e2ee6bf0533@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_072956_980654_BDC1F2C2 X-CRM114-Status: GOOD ( 33.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, richard.genoud@gmail.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwMiBOb3YgMjAyMCwgQ29kcmluLkNpdWJvdGFyaXVAbWljcm9jaGlwLmNvbSB3cm90 ZToKCj4gT24gMDIuMTEuMjAyMCAxMTowMSwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gRnJpLCAz MCBPY3QgMjAyMCwgTmljb2xhcyBGZXJyZSB3cm90ZToKPiA+IAo+ID4+IE9uIDMwLzEwLzIwMjAg YXQgMTI6MDcsIENvZHJpbiBDaXVib3Rhcml1IHdyb3RlOgo+ID4+PiBUaGUgImF0bWVsLGF0OTFz YW05MjYwLXVzYXJ0IiBkcml2ZXIgaXMgYSBNRkQgZHJpdmVyLCBzbyBpdCBuZWVkcyBzdWItbm9k ZXMKPiA+Pj4gdG8gbWF0Y2ggdGhlIHJlZ2lzdGVyZWQgcGxhdGZvcm0gZGV2aWNlLiBGb3IgdGhp cyByZWFzb24sIHdlIGFkZCBhIHNlcmlhbAo+ID4+PiBzdWJub2RlIHRvIGFsbCB0aGUgImF0bWVs LGF0OTFzYW05MjYwLXVzYXJ0IiBzZXJpYWwgY29tcGF0aWJsZSBub2RzLiBUaGlzCj4gPj4+IHdp bGwgYWxzbyByZW1vdmUgdGhlIGJvb3Qgd2FybmluZzoKPiA+Pj4gImF0bWVsX3VzYXJ0X3Nlcmlh bDogRmFpbGVkIHRvIGxvY2F0ZSBvZl9ub2RlIFtpZDogLTJdIgo+ID4+Cj4gPj4gSSBkb24ndCBy ZW1lbWJlciB0aGlzIHdhcm5pbmcgd2FzIHJhaXNlZCBwcmV2aW91c2x5IGV2ZW4gaWYgdGhlIE1G RCBkcml2ZXIKPiA+PiB3YXMgYWRkZWQgYSB3aGlsZSBhZ28gKFNlcHQuIDIwMTgpLgo+ID4+Cj4g Pj4gSSB3b3VsZCBzYXkgaXQncyBkdWUgdG8gNDY2YTYyZDc2NDJmICgibWZkOiBjb3JlOiBNYWtl IGEgYmVzdCBlZmZvcnQgYXR0ZW1wdAo+ID4+IHRvIG1hdGNoIGRldmljZXMgd2l0aCB0aGUgY29y cmVjdCBvZl9ub2RlcyIpIHdoaWNoIHdhcyBhZGRlZCBvbiBtaWQgQXVndXN0Cj4gPj4gYW5kIGNv cnJlY3RlZCB3aXRoIDIyMzgwYjY1ZGM3MCAoIm1mZDogbWZkLWNvcmU6IEVuc3VyZSBkaXNhYmxl ZCBkZXZpY2VzIGFyZQo+ID4+IGlnbm9yZWQgd2l0aG91dCBlcnJvciIpIGJ1dCBtYXliZSBub3Qg Y292ZXJpbmcgb3VyIGNhc2UuCj4gPj4KPiA+PiBTbywgd2VsbCwgSSBkb24ndCBrbm93IHdoYXQn cyB0aGUgYmVzdCBvcHRpb24gdG8gdGhpcyBjaGFuZ2UuIE1vcmVvdmVyLCBJCj4gPj4gd291bGQg c2F5IHRoYXQgYWxsIG90aGVyIFVTQVJUIHJlbGF0ZWQgcHJvcGVydGllcyBnbyBpbnRvIHRoZSBj aGlsZCBub3QgaWYKPiA+PiB0aGVyZSBpcyBhIG5lZWQgZm9yIG9uZS4KPiA+Pgo+ID4+IExlZSwg SSBzdXNwZWN0IHRoYXQgd2UncmUgbm90IHRoZSBvbmx5IG9uZXMgZXhwZXJpZW5jaW5nIHRoaXMg dWdseSB3YXJuaW5nCj4gPj4gZHVyaW5nIHRoZSBib290IGxvZzogY2FuIHlvdSBwb2ludCB1cyBv dXQgaG93IHRvIGRlYWwgd2l0aCBpdCBmb3Igb3VyCj4gPj4gZXhpc3RpbmcgYXRtZWxfc2VyaWFs LmMgdXNlcnM/Cj4gPiAKPiA+IFlvdSBzaG91bGQgbm90IGJlIGluc3RhbnRpYXRpbmcgZHJpdmVy cyB0aHJvdWdoIERldmljZSBUcmVlIHdoaWNoIGFyZQo+ID4gbm90IGRlc2NyaWJlZCB0aGVyZS4g IElmIHRoZSBjb3JyZWN0IHJlcHJlc2VudGF0aW9uIG9mIHRoZSBIL1cgYWxyZWFkeQo+ID4gZXhp c3RzIGluIERldmljZSBUcmVlIGkuZS4gbm8gU1BJIGFuZCBVQVJUIElQIHJlYWxseSBleGlzdHMs IHVzZSB0aGUKPiA+IE1GRCBjb3JlIEFQSSB0byByZWdpc3RlciB0aGVtIHV0aWxpc2luZyB0aGUg cGxhdGZvcm0gQVBJIGluc3RlYWQuCj4gPiAKPiA+IFRoaXMgc2hvdWxkIGRvIGl0Ogo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvYXQ5MS11c2FydC5jIGIvZHJpdmVycy9tZmQvYXQ5 MS11c2FydC5jCj4gPiBpbmRleCA2YTgzNTFhNDU4OGUyLi45MzliZDIzMzJhNGY2IDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9tZmQvYXQ5MS11c2FydC5jCj4gPiArKysgYi9kcml2ZXJzL21mZC9h dDkxLXVzYXJ0LmMKPiA+IEBAIC0xNywxMiArMTcsMTAgQEAKPiA+IAo+ID4gICBzdGF0aWMgY29u c3Qgc3RydWN0IG1mZF9jZWxsIGF0OTFfdXNhcnRfc3BpX3N1YmRldiA9IHsKPiA+ICAgICAgICAg IC5uYW1lID0gImF0OTFfdXNhcnRfc3BpIiwKPiA+IC0gICAgICAgLm9mX2NvbXBhdGlibGUgPSAi bWljcm9jaGlwLGF0OTFzYW05ZzQ1LXVzYXJ0LXNwaSIsCj4gPiAgIH07Cj4gPiAKPiA+ICAgc3Rh dGljIGNvbnN0IHN0cnVjdCBtZmRfY2VsbCBhdDkxX3VzYXJ0X3NlcmlhbF9zdWJkZXYgPSB7Cj4g PiAgICAgICAgICAubmFtZSA9ICJhdG1lbF91c2FydF9zZXJpYWwiLAo+ID4gLSAgICAgICAub2Zf Y29tcGF0aWJsZSA9ICJhdG1lbCxhdDkxcm05MjAwLXVzYXJ0LXNlcmlhbCIsCj4gPiAgIH07Cj4g PiAKPiA+ICAgc3RhdGljIGludCBhdDkxX3VzYXJ0X21vZGVfcHJvYmUoc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqcGRldikKPiAKPiBbc25pcF0KPiAKPiBIaSBMZWUsIHRoYW5rIHlvdSBmb3IgbG9v a2luZyB0aHJvdWdoIG91ciB1c2FydCBkcml2ZXIgYW5kIGZvciBzaGFyaW5nIAo+IHlvdXIgdGhv dWdodHMuIFJlbW92aW5nIHRoZSB1c2FnZSBvZiBjb21wYXRpYmxlIHN0cmluZyBtZWFucyB0aGF0 IGZvciAKPiBzaW1pbGFyIHNlcmlhbC9TUEkgSVBzIHdlIHdvdWxkIG5lZWQgdG8gY3JlYXRlIG5l dyBwbGF0Zm9ybSBkcml2ZXJzLiAKCldoeSB3b3VsZCB5b3UgbmVlZCB0byBkbyB0aGF0PwoKPiBU aGlzIGlzIG5vdCBpZGVhbCwgYnV0IGl0J3MgYSBzb2x1dGlvbi4gV2hhdCBJIHByb3Bvc2VkIGlz IG1vcmUgCj4gZmxleGlibGUsIGJ1dCwgYXMgeW91IHBvaW50ZWQgb3V0LCBJIGFtIG5vdCBzdXJl IGl0IGNvcnJlY3RseSBkZXNjcmliZXMgCj4gdGhlIEhXLCBiZWNhdXNlIHRoZSBkZWNpc2lvbiBv ZiB3aGV0aGVyIHRvIHVzZSB0aGlzIElQIGFzIGEgc2VyaWFsIG9yIGEgCj4gU1BJIGlzIGEgY29u ZmlndXJhYmxlIG9uZS4KPiAKPiBUaGFua3MgYW5kIGJlc3QgcmVnYXJkcywKPiBDb2RyaW4KCi0t IApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVy IFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BE31C388F2 for ; Mon, 2 Nov 2020 12:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 082D222450 for ; Mon, 2 Nov 2020 12:29:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G1YSAkrh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728789AbgKBM34 (ORCPT ); Mon, 2 Nov 2020 07:29:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728498AbgKBM34 (ORCPT ); Mon, 2 Nov 2020 07:29:56 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F2F7C061A04 for ; Mon, 2 Nov 2020 04:29:56 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id e2so9324049wme.1 for ; Mon, 02 Nov 2020 04:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4ILeNdi6oZHwCJ6iUbV3quJceEqtA1JSpxIiTg6qDXc=; b=G1YSAkrhaSYGxB3ZzXLFbutEnLIugxjFS/MnHvwogKJ/2z9t6lYistGV8bYmpqP6tr bblR8mBLvTeJ1fhCVf6rwZPdXoxj0ggzYVdS/Boub9l/Km3XhxqMjTeRGteaeIHEtb3y 5jgrMQkRG7MiScwoe8GTo5azdVwCfrm8jFEXmgReGPv3Ml7rzoBYDu36ZD8wM0NkUniP 4DiPp1ycgkolSM8Mkibl4pMVti5RxZN+FpPQgCUCmECtLqib47VmUFugMi+22C6rHGuj a3IDhz7wmWyxQVj7oDiyBIav9n4OAS+RiRevgZv23EvNPhBofheeruXXF74Sp8fz0+ri aj0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4ILeNdi6oZHwCJ6iUbV3quJceEqtA1JSpxIiTg6qDXc=; b=gx8JlU7oWR1Y4R4rpTH9UQVvb5Sz1juy/RmgK5fXGIF5Ia7YmdWbf85aaz+ZZdu1Qv NWNBjrEuhcXB31RKEMcVKyg7T3tJLkgEg+esdPRXZago16Tb5xnOZffcb9L0ez8ZV0zJ B9Q1GlIywA/C38HGGirpLllgR83SbQ2axDRuUGugR0gfbJcFhOi7qzhvElfC0VdxYRYd 5G+/NG0pTjp9C5jTW0oVCy6z8R4CyIWwbxYgqauQwCwdzgWiNLL+zeFxFBC2eI8mcqfF dQE3z0b9T5yPqIAG7DepZyFCpKHesrC4dsjJaPGx1LbjKngtmIF0YBXE6WIqKWpfOi6b eAsQ== X-Gm-Message-State: AOAM532GuYYBdWAYuQXh+KxiHb2VO/eoYe+W4C4NuIpU21dfar3HilgZ +YsqHyQCQkzyU/P6YJHzkT27+Q== X-Google-Smtp-Source: ABdhPJwUIfYXvZE9GcYuAEbLNWA2EEvj2uHM3TWkdRQSTGZfJMk9FgilHnSAFA8PxIJijlcW1NsSSw== X-Received: by 2002:a7b:c015:: with SMTP id c21mr17247812wmb.22.1604320194705; Mon, 02 Nov 2020 04:29:54 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id p13sm21671382wrt.73.2020.11.02.04.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 04:29:54 -0800 (PST) Date: Mon, 2 Nov 2020 12:29:52 +0000 From: Lee Jones To: Codrin.Ciubotariu@microchip.com Cc: Nicolas.Ferre@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, richard.genoud@gmail.com, alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Message-ID: <20201102122952.GB4488@dell> References: <20201030110702.886638-1-codrin.ciubotariu@microchip.com> <20201102090122.GF4127@dell> <780303c7-2c32-f2e1-c9ce-1e2ee6bf0533@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <780303c7-2c32-f2e1-c9ce-1e2ee6bf0533@microchip.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 02 Nov 2020, Codrin.Ciubotariu@microchip.com wrote: > On 02.11.2020 11:01, Lee Jones wrote: > > On Fri, 30 Oct 2020, Nicolas Ferre wrote: > > > >> On 30/10/2020 at 12:07, Codrin Ciubotariu wrote: > >>> The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs sub-nodes > >>> to match the registered platform device. For this reason, we add a serial > >>> subnode to all the "atmel,at91sam9260-usart" serial compatible nods. This > >>> will also remove the boot warning: > >>> "atmel_usart_serial: Failed to locate of_node [id: -2]" > >> > >> I don't remember this warning was raised previously even if the MFD driver > >> was added a while ago (Sept. 2018). > >> > >> I would say it's due to 466a62d7642f ("mfd: core: Make a best effort attempt > >> to match devices with the correct of_nodes") which was added on mid August > >> and corrected with 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are > >> ignored without error") but maybe not covering our case. > >> > >> So, well, I don't know what's the best option to this change. Moreover, I > >> would say that all other USART related properties go into the child not if > >> there is a need for one. > >> > >> Lee, I suspect that we're not the only ones experiencing this ugly warning > >> during the boot log: can you point us out how to deal with it for our > >> existing atmel_serial.c users? > > > > You should not be instantiating drivers through Device Tree which are > > not described there. If the correct representation of the H/W already > > exists in Device Tree i.e. no SPI and UART IP really exists, use the > > MFD core API to register them utilising the platform API instead. > > > > This should do it: > > > > diff --git a/drivers/mfd/at91-usart.c b/drivers/mfd/at91-usart.c > > index 6a8351a4588e2..939bd2332a4f6 100644 > > --- a/drivers/mfd/at91-usart.c > > +++ b/drivers/mfd/at91-usart.c > > @@ -17,12 +17,10 @@ > > > > static const struct mfd_cell at91_usart_spi_subdev = { > > .name = "at91_usart_spi", > > - .of_compatible = "microchip,at91sam9g45-usart-spi", > > }; > > > > static const struct mfd_cell at91_usart_serial_subdev = { > > .name = "atmel_usart_serial", > > - .of_compatible = "atmel,at91rm9200-usart-serial", > > }; > > > > static int at91_usart_mode_probe(struct platform_device *pdev) > > [snip] > > Hi Lee, thank you for looking through our usart driver and for sharing > your thoughts. Removing the usage of compatible string means that for > similar serial/SPI IPs we would need to create new platform drivers. Why would you need to do that? > This is not ideal, but it's a solution. What I proposed is more > flexible, but, as you pointed out, I am not sure it correctly describes > the HW, because the decision of whether to use this IP as a serial or a > SPI is a configurable one. > > Thanks and best regards, > Codrin -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog