From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB0E9C388F2 for ; Mon, 2 Nov 2020 12:53:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EB6822268 for ; Mon, 2 Nov 2020 12:53:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ItkDG+B7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EB6822268 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RmXLrpU2hiimRYtKoyBq803vcGBiR+ZY4uVnkJPBwcI=; b=ItkDG+B7mjeiyEW4dwT0YEk3q HxY1g23FJrl0xJ6gzbowuUaD1mRiU/HFIbzsheComydGe5TGaKNu9kCRXkd1gTyqnxTFWEM72gPxM ZPFnUMIDjUfIkpkeDHCskomxVZIqsx+P1K1JmpxirDkFzbno+KxLOqKNBlKv25Ihkp/yNJ2iE7x3m V7LWOfQ6x2hSbhsRvRn1neZye6fqomiKORBw9j0zaRZNofibnKz7OUV9A4uWZnSi1IiLksaar07ye Z6V6agWktriXvSLHVWHE+mDoLZnAwJKPmORdMAKTX1IkeBFD5GQFIQKaHfMF24qLxVh4c2D14F/nJ Qi2IhivVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZZKI-0003Rn-GB; Mon, 02 Nov 2020 12:52:46 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZZKF-0003R3-Ve for linux-mtd@lists.infradead.org; Mon, 02 Nov 2020 12:52:44 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AF340C0011; Mon, 2 Nov 2020 12:52:38 +0000 (UTC) Date: Mon, 2 Nov 2020 13:52:37 +0100 From: Miquel Raynal To: Lee Jones Subject: Re: [PATCH 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev' Message-ID: <20201102135237.7a03b817@xps13> In-Reply-To: <20201102115406.1074327-24-lee.jones@linaro.org> References: <20201102115406.1074327-1-lee.jones@linaro.org> <20201102115406.1074327-24-lee.jones@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_075244_123493_2965CE5A X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Benjamin Herrenschmidt , vigneshr@ti.com, Michael Ellerman , linux-kernel@vger.kernel.org, Paul Mackerras , Richard Weinberger , linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Cyril Bur Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTGVlLAoKTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3JvdGUgb24gTW9uLCAg MiBOb3YgMjAyMCAxMTo1NDowNgorMDAwMDoKCj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2Vy bmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4gCj4gIGRyaXZlcnMvbXRkL2RldmljZXMvcG93ZXJudl9m bGFzaC5jOjEyOTogd2FybmluZzogQ2Fubm90IHVuZGVyc3RhbmQgICogQG10ZDogdGhlIGRldmlj ZQo+ICBkcml2ZXJzL210ZC9kZXZpY2VzL3Bvd2VybnZfZmxhc2guYzoxNDU6IHdhcm5pbmc6IENh bm5vdCB1bmRlcnN0YW5kICAqIEBtdGQ6IHRoZSBkZXZpY2UKPiAgZHJpdmVycy9tdGQvZGV2aWNl cy9wb3dlcm52X2ZsYXNoLmM6MTYxOiB3YXJuaW5nOiBDYW5ub3QgdW5kZXJzdGFuZCAgKiBAbXRk OiB0aGUgZGV2aWNlCj4gIGRyaXZlcnMvbXRkL2RldmljZXMvcG93ZXJudl9mbGFzaC5jOjE4NDog d2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAnZGV2JyBub3QgZGVzY3JpYmVk IGluICdwb3dlcm52X2ZsYXNoX3NldF9kcml2ZXJfaW5mbycKPiAKPiBDYzogTWlxdWVsIFJheW5h bCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KPiBDYzogUmljaGFyZCBXZWluYmVyZ2VyIDxy aWNoYXJkQG5vZC5hdD4KPiBDYzogVmlnbmVzaCBSYWdoYXZlbmRyYSA8dmlnbmVzaHJAdGkuY29t Pgo+IENjOiBNaWNoYWVsIEVsbGVybWFuIDxtcGVAZWxsZXJtYW4uaWQuYXU+Cj4gQ2M6IEJlbmph bWluIEhlcnJlbnNjaG1pZHQgPGJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZz4KPiBDYzogUGF1bCBN YWNrZXJyYXMgPHBhdWx1c0BzYW1iYS5vcmc+Cj4gQ2M6IEN5cmlsIEJ1ciA8Y3lyaWwuYnVyQGF1 MS5pYm0uY29tPgo+IENjOiBsaW51eC1tdGRAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IENjOiBsaW51 eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVl LmpvbmVzQGxpbmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL2RldmljZXMvcG93ZXJudl9m bGFzaC5jIHwgNiArKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9kZXZpY2VzL3Bvd2VybnZf Zmxhc2guYyBiL2RyaXZlcnMvbXRkL2RldmljZXMvcG93ZXJudl9mbGFzaC5jCj4gaW5kZXggMGI3 NTdkOWJhMmY2Yi4uMzJjYjBlNjQ5MDk2ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9kZXZp Y2VzL3Bvd2VybnZfZmxhc2guYwo+ICsrKyBiL2RyaXZlcnMvbXRkL2RldmljZXMvcG93ZXJudl9m bGFzaC5jCj4gQEAgLTEyNiw2ICsxMjYsOCBAQCBzdGF0aWMgaW50IHBvd2VybnZfZmxhc2hfYXN5 bmNfb3Aoc3RydWN0IG10ZF9pbmZvICptdGQsIGVudW0gZmxhc2hfb3Agb3AsCj4gIH0KPiAgCj4g IC8qKgo+ICsgKiBwb3dlcm52X2ZsYXNoX3JlYWQKPiArICoKClBlcmhhcHMgd2Ugc2hvdWxkIG5v dCBhZGQgYmxhbmsgbGluZXMgaWYgdGhlIHJlc3Qgb2YgdGhlIGZpbGUgZG9lcyBub3QKYWxyZWFk eSBoYXZlIHN1Y2ggc3BhY2luZyAoc2VlIGJlbG93KS4KCj4gICAqIEBtdGQ6IHRoZSBkZXZpY2UK PiAgICogQGZyb206IHRoZSBvZmZzZXQgdG8gcmVhZCBmcm9tCj4gICAqIEBsZW46IHRoZSBudW1i ZXIgb2YgYnl0ZXMgdG8gcmVhZAo+IEBAIC0xNDIsNiArMTQ0LDcgQEAgc3RhdGljIGludCBwb3dl cm52X2ZsYXNoX3JlYWQoc3RydWN0IG10ZF9pbmZvICptdGQsIGxvZmZfdCBmcm9tLCBzaXplX3Qg bGVuLAo+ICB9Cj4gIAo+ICAvKioKPiArICogcG93ZXJudl9mbGFzaF93cml0ZQo+ICAgKiBAbXRk OiB0aGUgZGV2aWNlCj4gICAqIEB0bzogdGhlIG9mZnNldCB0byB3cml0ZSB0bwo+ICAgKiBAbGVu OiB0aGUgbnVtYmVyIG9mIGJ5dGVzIHRvIHdyaXRlCj4gQEAgLTE1OCw2ICsxNjEsNyBAQCBzdGF0 aWMgaW50IHBvd2VybnZfZmxhc2hfd3JpdGUoc3RydWN0IG10ZF9pbmZvICptdGQsIGxvZmZfdCB0 bywgc2l6ZV90IGxlbiwKPiAgfQo+ICAKPiAgLyoqCj4gKyAqIHBvd2VybnZfZmxhc2hfZXJhc2UK PiAgICogQG10ZDogdGhlIGRldmljZQo+ICAgKiBAZXJhc2U6IHRoZSBlcmFzZSBpbmZvCj4gICAq IFJldHVybnMgMCBpZiBlcmFzZSBzdWNjZXNzZnVsIG9yIC1FUlJOTyBpZiBhbiBlcnJvciBvY2N1 cnJlZAo+IEBAIC0xNzYsNyArMTgwLDcgQEAgc3RhdGljIGludCBwb3dlcm52X2ZsYXNoX2VyYXNl KHN0cnVjdCBtdGRfaW5mbyAqbXRkLCBzdHJ1Y3QgZXJhc2VfaW5mbyAqZXJhc2UpCj4gIAo+ICAv KioKPiAgICogcG93ZXJudl9mbGFzaF9zZXRfZHJpdmVyX2luZm8gLSBGaWxsIHRoZSBtdGRfaW5m byBzdHJ1Y3R1cmUgYW5kIGRvY2czCj4gLSAqIHN0cnVjdHVyZSBAcGRldjogVGhlIHBsYXRmb3Jt IGRldmljZQo+ICsgKiBAZGV2OiBUaGUgZGV2aWNlIHN0cnVjdHVyZQo+ICAgKiBAbXRkOiBUaGUg c3RydWN0dXJlIHRvIGZpbGwKPiAgICovCj4gIHN0YXRpYyBpbnQgcG93ZXJudl9mbGFzaF9zZXRf ZHJpdmVyX2luZm8oc3RydWN0IGRldmljZSAqZGV2LAoKClRoYW5rcywKTWlxdcOobAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1U RCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C662C00A89 for ; Mon, 2 Nov 2020 12:59:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B80B222BA for ; Mon, 2 Nov 2020 12:59:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B80B222BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CPtKL4GnjzDqQf for ; Mon, 2 Nov 2020 23:59:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.178.242; helo=mslow2.mail.gandi.net; envelope-from=miquel.raynal@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Received: from mslow2.mail.gandi.net (mslow2.mail.gandi.net [217.70.178.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CPtCT5rZVzDqHh for ; Mon, 2 Nov 2020 23:54:12 +1100 (AEDT) Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 71C413A9340 for ; Mon, 2 Nov 2020 12:53:20 +0000 (UTC) X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AF340C0011; Mon, 2 Nov 2020 12:52:38 +0000 (UTC) Date: Mon, 2 Nov 2020 13:52:37 +0100 From: Miquel Raynal To: Lee Jones Subject: Re: [PATCH 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev' Message-ID: <20201102135237.7a03b817@xps13> In-Reply-To: <20201102115406.1074327-24-lee.jones@linaro.org> References: <20201102115406.1074327-1-lee.jones@linaro.org> <20201102115406.1074327-24-lee.jones@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, linux-kernel@vger.kernel.org, Paul Mackerras , Richard Weinberger , linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Cyril Bur Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Lee, Lee Jones wrote on Mon, 2 Nov 2020 11:54:06 +0000: > Fixes the following W=3D1 kernel build warning(s): >=20 > drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @= mtd: the device > drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @= mtd: the device > drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @= mtd: the device > drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or = member 'dev' not described in 'powernv_flash_set_driver_info' >=20 > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Cyril Bur > Cc: linux-mtd@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones > --- > drivers/mtd/devices/powernv_flash.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/po= wernv_flash.c > index 0b757d9ba2f6b..32cb0e649096f 100644 > --- a/drivers/mtd/devices/powernv_flash.c > +++ b/drivers/mtd/devices/powernv_flash.c > @@ -126,6 +126,8 @@ static int powernv_flash_async_op(struct mtd_info *mt= d, enum flash_op op, > } > =20 > /** > + * powernv_flash_read > + * Perhaps we should not add blank lines if the rest of the file does not already have such spacing (see below). > * @mtd: the device > * @from: the offset to read from > * @len: the number of bytes to read > @@ -142,6 +144,7 @@ static int powernv_flash_read(struct mtd_info *mtd, l= off_t from, size_t len, > } > =20 > /** > + * powernv_flash_write > * @mtd: the device > * @to: the offset to write to > * @len: the number of bytes to write > @@ -158,6 +161,7 @@ static int powernv_flash_write(struct mtd_info *mtd, = loff_t to, size_t len, > } > =20 > /** > + * powernv_flash_erase > * @mtd: the device > * @erase: the erase info > * Returns 0 if erase successful or -ERRNO if an error occurred > @@ -176,7 +180,7 @@ static int powernv_flash_erase(struct mtd_info *mtd, = struct erase_info *erase) > =20 > /** > * powernv_flash_set_driver_info - Fill the mtd_info structure and docg3 > - * structure @pdev: The platform device > + * @dev: The device structure > * @mtd: The structure to fill > */ > static int powernv_flash_set_driver_info(struct device *dev, Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EC7C00A89 for ; Mon, 2 Nov 2020 12:52:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F0C822273 for ; Mon, 2 Nov 2020 12:52:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728828AbgKBMwp convert rfc822-to-8bit (ORCPT ); Mon, 2 Nov 2020 07:52:45 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34221 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728253AbgKBMwo (ORCPT ); Mon, 2 Nov 2020 07:52:44 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AF340C0011; Mon, 2 Nov 2020 12:52:38 +0000 (UTC) Date: Mon, 2 Nov 2020 13:52:37 +0100 From: Miquel Raynal To: Lee Jones Cc: vigneshr@ti.com, linux-kernel@vger.kernel.org, Richard Weinberger , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Cyril Bur , linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev' Message-ID: <20201102135237.7a03b817@xps13> In-Reply-To: <20201102115406.1074327-24-lee.jones@linaro.org> References: <20201102115406.1074327-1-lee.jones@linaro.org> <20201102115406.1074327-24-lee.jones@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, Lee Jones wrote on Mon, 2 Nov 2020 11:54:06 +0000: > Fixes the following W=1 kernel build warning(s): > > drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device > drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device > drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device > drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info' > > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Cyril Bur > Cc: linux-mtd@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones > --- > drivers/mtd/devices/powernv_flash.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c > index 0b757d9ba2f6b..32cb0e649096f 100644 > --- a/drivers/mtd/devices/powernv_flash.c > +++ b/drivers/mtd/devices/powernv_flash.c > @@ -126,6 +126,8 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op, > } > > /** > + * powernv_flash_read > + * Perhaps we should not add blank lines if the rest of the file does not already have such spacing (see below). > * @mtd: the device > * @from: the offset to read from > * @len: the number of bytes to read > @@ -142,6 +144,7 @@ static int powernv_flash_read(struct mtd_info *mtd, loff_t from, size_t len, > } > > /** > + * powernv_flash_write > * @mtd: the device > * @to: the offset to write to > * @len: the number of bytes to write > @@ -158,6 +161,7 @@ static int powernv_flash_write(struct mtd_info *mtd, loff_t to, size_t len, > } > > /** > + * powernv_flash_erase > * @mtd: the device > * @erase: the erase info > * Returns 0 if erase successful or -ERRNO if an error occurred > @@ -176,7 +180,7 @@ static int powernv_flash_erase(struct mtd_info *mtd, struct erase_info *erase) > > /** > * powernv_flash_set_driver_info - Fill the mtd_info structure and docg3 > - * structure @pdev: The platform device > + * @dev: The device structure > * @mtd: The structure to fill > */ > static int powernv_flash_set_driver_info(struct device *dev, Thanks, Miquèl