From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FFBC00A89 for ; Mon, 2 Nov 2020 23:36:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A29FF22384 for ; Mon, 2 Nov 2020 23:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604360171; bh=CRV8C2Tp6iKLHwUS/Grck1D9BQp3JqHIdxV29tUsxvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LW7NoyLU+NaA1V0YiGtHuEagPi/bGpc2IsMp/BMUhGkMo4bEHyPlgIdWkSmsQFQ46 GXnjdTFxOGmyRmx3aFSwm+dt7yIdgkXU00ohDZDLKHxcmPPToJ4EUAvnRoWR7Silos Hi0ZKoXS2WeQ/ZTuZ6695mZNXQXMSCquJ2quS8sk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726439AbgKBXgL (ORCPT ); Mon, 2 Nov 2020 18:36:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:34572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726433AbgKBXgL (ORCPT ); Mon, 2 Nov 2020 18:36:11 -0500 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCE76222BA; Mon, 2 Nov 2020 23:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604360170; bh=CRV8C2Tp6iKLHwUS/Grck1D9BQp3JqHIdxV29tUsxvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XVRKF95eDLutw9IswFoF+yzqV6t7m4cR5sn5Z4a3nWJIA8Uxoj+cNFCb4MjaOO74w GgTmALuAAxat7t/AJe41xqHytBG8rbd4Xyp6uotn00+1QiYPpC53j3BSOMI+F4qx0b XJ/h6Kh+wVTlhkSYr1oO5pWOpMyIDNAH/sBwyJEI= Date: Tue, 3 Nov 2020 07:36:05 +0800 From: Shawn Guo To: Dong Aisheng Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, mturquette@baylibre.com, fabio.estevam@nxp.com, linux-imx@nxp.com, kernel@pengutronix.de, kernel test robot Subject: Re: [PATCH 1/1] clk: imx: scu: fix build break when compiled as modules Message-ID: <20201102233604.GV31601@dragon> References: <20201030153733.30160-1-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201030153733.30160-1-aisheng.dong@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Fri, Oct 30, 2020 at 11:37:33PM +0800, Dong Aisheng wrote: > After commit e0d0d4d86c76 ("clk: imx8qxp: Support building i.MX8QXP clock > driver as module"), clk-scu.c and clk-imx8qxp.c are complied in one module, > thus there can be only one module_init() in those two files. > Commit 77d8f3068c63 ("clk: imx: scu: add two cells binding support") > introduced another module_init() in clk_scu.c which caused the errors > below. > > To fix the issue, we can remove the unnecessary builtin_platform_driver > from clk_scu.c and directly register the driver in imx_clk_scu_init(). > > CC [M] drivers/clk/imx/clk-scu.o > In file included from ../include/linux/of_device.h:6, > from ../include/linux/of_platform.h:12, > from ../drivers/clk/imx/clk-scu.c:11: > ../drivers/clk/imx/clk-scu.c: In function ‘imx_clk_scu_init’: > ../drivers/clk/imx/clk-scu.c:176:35: error: ‘imx_clk_scu_driver’ undeclared (first use in this function); did you mean ‘imx_clk_scu_init’? > 176 | return platform_driver_register(&imx_clk_scu_driver); > | ^~~~~~~~~~~~~~~~~~ > ../include/linux/platform_device.h:218:29: note: in definition of macro ‘platform_driver_register’ > 218 | __platform_driver_register(drv, THIS_MODULE) > | ^~~ > ../drivers/clk/imx/clk-scu.c:176:35: note: each undeclared identifier is reported only once for each function it appears in > 176 | return platform_driver_register(&imx_clk_scu_driver); > | ^~~~~~~~~~~~~~~~~~ > ../include/linux/platform_device.h:218:29: note: in definition of macro ‘platform_driver_register’ > 218 | __platform_driver_register(drv, THIS_MODULE) > | ^~~ > ../drivers/clk/imx/clk-scu.c:177:1: error: control reaches end of non-void function [-Werror=return-type] > 177 | } > | ^ > At top level: > ../drivers/clk/imx/clk-scu.c:470:31: warning: ‘imx_clk_scu_driver’ defined but not used [-Wunused-variable] > 470 | static struct platform_driver imx_clk_scu_driver = { > > Reported-by: kernel test robot > Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") > Signed-off-by: Dong Aisheng Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894EFC00A89 for ; Mon, 2 Nov 2020 23:36:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EF0D2225E for ; Mon, 2 Nov 2020 23:36:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1dgnLJqV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XVRKF95e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EF0D2225E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=evVTPywzuiinYShGjUFxeVPcbvjaWFHi4qpoggNqX5Y=; b=1dgnLJqV0wcNAwZYwoWFQKdU8 xL0bl6BOA2c0oLyVVtTV25FLOkmn0tS/GhD6lB8Q9uTzquW/k7XNtKQ9KE50nd2AmNa1pGt6F2vmt xvcCnMGAXwihj6QcJHqI+dLNHMVv7AG029pay7W9SP5HYug576ndf6NwVhsWu6R6sz7GBgaqXvhuS 9XSR8isyB35+VP953rKBvRYa5n0rvNclek8ITgZxnyQuDxfCtNsMTDYJCPcA9en2/NWqAGJV6lHGY LNr0M8qRiG7NOe5q1uj00nxBeQ7IUOBKhwpRkEp6fHVhdtF/Ocq0yX/smmhMEMCiWOmGiyKMdzzWH ddOG/B6DQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZjN2-0004ez-5h; Mon, 02 Nov 2020 23:36:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZjMx-0004dK-Pa for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 23:36:12 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCE76222BA; Mon, 2 Nov 2020 23:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604360170; bh=CRV8C2Tp6iKLHwUS/Grck1D9BQp3JqHIdxV29tUsxvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XVRKF95eDLutw9IswFoF+yzqV6t7m4cR5sn5Z4a3nWJIA8Uxoj+cNFCb4MjaOO74w GgTmALuAAxat7t/AJe41xqHytBG8rbd4Xyp6uotn00+1QiYPpC53j3BSOMI+F4qx0b XJ/h6Kh+wVTlhkSYr1oO5pWOpMyIDNAH/sBwyJEI= Date: Tue, 3 Nov 2020 07:36:05 +0800 From: Shawn Guo To: Dong Aisheng Subject: Re: [PATCH 1/1] clk: imx: scu: fix build break when compiled as modules Message-ID: <20201102233604.GV31601@dragon> References: <20201030153733.30160-1-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201030153733.30160-1-aisheng.dong@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_183612_207101_9CA3BED9 X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , sboyd@kernel.org, mturquette@baylibre.com, linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBPY3QgMzAsIDIwMjAgYXQgMTE6Mzc6MzNQTSArMDgwMCwgRG9uZyBBaXNoZW5nIHdy b3RlOgo+IEFmdGVyIGNvbW1pdCBlMGQwZDRkODZjNzYgKCJjbGs6IGlteDhxeHA6IFN1cHBvcnQg YnVpbGRpbmcgaS5NWDhRWFAgY2xvY2sKPiBkcml2ZXIgYXMgbW9kdWxlIiksIGNsay1zY3UuYyBh bmQgY2xrLWlteDhxeHAuYyBhcmUgY29tcGxpZWQgaW4gb25lIG1vZHVsZSwKPiB0aHVzIHRoZXJl IGNhbiBiZSBvbmx5IG9uZSBtb2R1bGVfaW5pdCgpIGluIHRob3NlIHR3byBmaWxlcy4KPiBDb21t aXQgNzdkOGYzMDY4YzYzICgiY2xrOiBpbXg6IHNjdTogYWRkIHR3byBjZWxscyBiaW5kaW5nIHN1 cHBvcnQiKQo+IGludHJvZHVjZWQgYW5vdGhlciBtb2R1bGVfaW5pdCgpIGluIGNsa19zY3UuYyB3 aGljaCBjYXVzZWQgdGhlIGVycm9ycwo+IGJlbG93Lgo+IAo+IFRvIGZpeCB0aGUgaXNzdWUsIHdl IGNhbiByZW1vdmUgdGhlIHVubmVjZXNzYXJ5IGJ1aWx0aW5fcGxhdGZvcm1fZHJpdmVyCj4gZnJv bSBjbGtfc2N1LmMgYW5kIGRpcmVjdGx5IHJlZ2lzdGVyIHRoZSBkcml2ZXIgaW4gaW14X2Nsa19z Y3VfaW5pdCgpLgo+IAo+ICAgQ0MgW01dICBkcml2ZXJzL2Nsay9pbXgvY2xrLXNjdS5vCj4gSW4g ZmlsZSBpbmNsdWRlZCBmcm9tIC4uL2luY2x1ZGUvbGludXgvb2ZfZGV2aWNlLmg6NiwKPiAgICAg ICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9saW51eC9vZl9wbGF0Zm9ybS5oOjEyLAo+ICAg ICAgICAgICAgICAgICAgZnJvbSAuLi9kcml2ZXJzL2Nsay9pbXgvY2xrLXNjdS5jOjExOgo+IC4u L2RyaXZlcnMvY2xrL2lteC9jbGstc2N1LmM6IEluIGZ1bmN0aW9uIOKAmGlteF9jbGtfc2N1X2lu aXTigJk6Cj4gLi4vZHJpdmVycy9jbGsvaW14L2Nsay1zY3UuYzoxNzY6MzU6IGVycm9yOiDigJhp bXhfY2xrX3NjdV9kcml2ZXLigJkgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rp b24pOyBkaWQgeW91IG1lYW4g4oCYaW14X2Nsa19zY3VfaW5pdOKAmT8KPiAgIDE3NiB8ICByZXR1 cm4gcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyKCZpbXhfY2xrX3NjdV9kcml2ZXIpOwo+ICAgICAg IHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fgo+ IC4uL2luY2x1ZGUvbGludXgvcGxhdGZvcm1fZGV2aWNlLmg6MjE4OjI5OiBub3RlOiBpbiBkZWZp bml0aW9uIG9mIG1hY3JvIOKAmHBsYXRmb3JtX2RyaXZlcl9yZWdpc3RlcuKAmQo+ICAgMjE4IHwg IF9fcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyKGRydiwgVEhJU19NT0RVTEUpCj4gICAgICAgfCAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+Cj4gLi4vZHJpdmVycy9jbGsvaW14L2Nsay1z Y3UuYzoxNzY6MzU6IG5vdGU6IGVhY2ggdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlzIHJlcG9ydGVk IG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBlYXJzIGluCj4gICAxNzYgfCAgcmV0 dXJuIHBsYXRmb3JtX2RyaXZlcl9yZWdpc3RlcigmaW14X2Nsa19zY3VfZHJpdmVyKTsKPiAgICAg ICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn4K PiAuLi9pbmNsdWRlL2xpbnV4L3BsYXRmb3JtX2RldmljZS5oOjIxODoyOTogbm90ZTogaW4gZGVm aW5pdGlvbiBvZiBtYWNybyDigJhwbGF0Zm9ybV9kcml2ZXJfcmVnaXN0ZXLigJkKPiAgIDIxOCB8 ICBfX3BsYXRmb3JtX2RyaXZlcl9yZWdpc3RlcihkcnYsIFRISVNfTU9EVUxFKQo+ICAgICAgIHwg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fgo+IC4uL2RyaXZlcnMvY2xrL2lteC9jbGst c2N1LmM6MTc3OjE6IGVycm9yOiBjb250cm9sIHJlYWNoZXMgZW5kIG9mIG5vbi12b2lkIGZ1bmN0 aW9uIFstV2Vycm9yPXJldHVybi10eXBlXQo+ICAgMTc3IHwgfQo+ICAgICAgIHwgXgo+IEF0IHRv cCBsZXZlbDoKPiAuLi9kcml2ZXJzL2Nsay9pbXgvY2xrLXNjdS5jOjQ3MDozMTogd2FybmluZzog 4oCYaW14X2Nsa19zY3VfZHJpdmVy4oCZIGRlZmluZWQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC12 YXJpYWJsZV0KPiAgIDQ3MCB8IHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIGlteF9jbGtf c2N1X2RyaXZlciA9IHsKPiAKPiBSZXBvcnRlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPGxrcEBp bnRlbC5jb20+Cj4gRml4ZXM6IDc3ZDhmMzA2OGM2MyAoImNsazogaW14OiBzY3U6IGFkZCB0d28g Y2VsbHMgYmluZGluZyBzdXBwb3J0IikKPiBTaWduZWQtb2ZmLWJ5OiBEb25nIEFpc2hlbmcgPGFp c2hlbmcuZG9uZ0BueHAuY29tPgoKQXBwbGllZCwgdGhhbmtzLgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=