All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Adit Ranadive <aditr@vmware.com>
Cc: <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
	<pv-drivers@vmware.com>
Subject: Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value
Date: Mon, 2 Nov 2020 20:02:54 -0400	[thread overview]
Message-ID: <20201103000254.GA3741762@nvidia.com> (raw)
In-Reply-To: <20201102225437.26557-1-aditr@vmware.com>

On Mon, Nov 02, 2020 at 10:54:37PM +0000, Adit Ranadive wrote:
> The PVRDMA device still reports the active_speed in u8.
> The pvrdma_port_attr structure is used by the device to report the
> port attributes in the device API query port response structure -
> pvrdma_cmd_query_port_resp - and shouldn't be changed.
> 
> Fixes: 376ceb31ff87 ("RDMA: Fix link active_speed size")
> Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
> Signed-off-by: Adit Ranadive <aditr@vmware.com>
> ---
> 
> Changelog:
>  - v0->v1: Reverted the structure layout only as per Jason. Updated description.
> ---
>  drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc

If you think it is better you can send another patch to use the
ib_get_eth_speed() function

Also please send a patch to move all of these ABI structs into the
pvrdma_dev_api.h - ABI structures should not be strewn randomly over
header files, it leads to mistakes like this.

Thanks,
Jason

      reply	other threads:[~2020-11-03  0:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 22:54 [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value Adit Ranadive
2020-11-03  0:02 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103000254.GA3741762@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=aditr@vmware.com \
    --cc=dledford@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.