From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by arago-project.org (Postfix) with ESMTPS id 39C9552968 for ; Tue, 3 Nov 2020 00:08:23 +0000 (UTC) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A305E2N059659 for ; Mon, 2 Nov 2020 18:05:14 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604361914; bh=aQswhqWYfjs7XAirLdLNOZg2kWjv7apOhsTvm/gxJ04=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=tWK9dkxynz16Nepe8rDSstFEqLVdc4lM9fruXRXgjORVU5hwCPI9LlakiYlqoFC4b olMjOHE3C1dCPI1hwIOVxtx4e/vfmS+hFZm+LPEoeYlUmzaDTGuLGznDwqRVJ/jlU4 Dv60dKdfBYCJB5SOS8NxZqyqrB+t26ETNWkL4kzc= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A305Efu035981 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Nov 2020 18:05:14 -0600 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 2 Nov 2020 18:05:09 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 2 Nov 2020 18:05:09 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A30595g099735; Mon, 2 Nov 2020 18:05:09 -0600 Date: Mon, 2 Nov 2020 19:05:09 -0500 From: Denys Dmytriyenko To: Suman Anna Message-ID: <20201103000508.GA3224@beryl> References: <20201027024112.5330-1-s-anna@ti.com> <20201027024533.GR19741@beryl> <21098998-f191-b9f0-79af-26b1045c6a54@ti.com> <20201027040839.GS19741@beryl> <39ea11fd-e4bf-3133-b280-ece903a9b9f8@ti.com> <20201027191149.GY19741@beryl> <4469fbf2-fe4f-df39-351c-318411f9e7ed@ti.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org Subject: Re: [master/dunfell PATCH] packagegroup-arago-tisdk-addons-sdk-target: Add ti-rpmsg-char dev packages X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 00:08:23 -0000 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Nov 02, 2020 at 04:53:56PM -0600, Suman Anna wrote: > Hi Dan, > > On 11/2/20 4:18 PM, Dan Murphy wrote: > > Suman > > > > On 10/27/20 2:11 PM, Denys Dmytriyenko wrote: > >> On Tue, Oct 27, 2020 at 09:37:18AM -0500, Suman Anna wrote: > >>> Hi Denys, > >>> > >>> On 10/26/20 11:08 PM, Denys Dmytriyenko wrote: > >>>> On Mon, Oct 26, 2020 at 09:48:26PM -0500, Suman Anna wrote: > >>>>> On 10/26/20 9:45 PM, Denys Dmytriyenko wrote: > >>>>>> On Mon, Oct 26, 2020 at 09:41:12PM -0500, Suman Anna wrote: > >>>>>>> Add the ti-rpmsg-char dev packages to make the public headers available in > >>>>>>> the target fileystem so that applications can be compiled natively on the > >>>>>>> target. > >>>>>> -sdk-target is not for the target filesystem! > >>>>>> It is for the target sysroot in the devkit. > >>>>> Hmm, is this supposed to go into a different file or my patch description > >>>>> needs > >>>>> correcting? > >>>> It depends on what you actually need. > >>> I want the files from the  ti-rpmsg-char-dev package (the public header files > >>> and libti_rpmsg_char.so) to be part of the FS tarball. > >> Then you need to pull corresponding -dev package into the packagegroup that > >> builds up the rootfs. > >> > >> At least in Arago, I kept the namespace convention that -sdk-target and > >> -sdk-host suffixes are used to identify packagegroups for the devkit - > >> cross-compile development environment on the host, target and host sysroots. > >> > >>> regards > >>> Suman > >>> > >>>> > >>>>>>> Signed-off-by: Suman Anna > >>>>>>> --- > >>>>>>>   .../packagegroup-arago-tisdk-addons-sdk-target.bb         | 8 ++++++-- > >>>>>>>   1 file changed, 6 insertions(+), 2 deletions(-) > >>>>>>> > >>>>>>> diff --git > >>>>>>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb > >>>>>>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb > >>>>>>> > >>>>>>> index e372dd67744e..b55c79a4d4df 100644 > >>>>>>> --- > >>>>>>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb > >>>>>>> > >>>>>>> +++ > >>>>>>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb > >>>>>>> > >>>>>>> @@ -1,6 +1,6 @@ > >>>>>>>   DESCRIPTION = "Task to install headers and libraries related to addons > >>>>>>> into the SDK" > >>>>>>>   LICENSE = "MIT" > >>>>>>> -PR = "r43" > >>>>>>> +PR = "r44" > >>>>>>>     PACKAGE_ARCH = "${MACHINE_ARCH}" > >>>>>>>   @@ -143,7 +143,11 @@ UTILS_append_dra7xx = " can-utils-dev \ > >>>>>>>                           elfutils-staticdev \ > >>>>>>>   " > >>>>>>>   UTILS_append_k2g = " can-utils-dev" > >>>>>>> -UTILS_append_k3 = " can-utils-dev" > >>>>>>> +UTILS_append_k3 = "\ > >>>>>>> +    can-utils-dev \ > >>>>>>> +    ti-rpmsg-char-dev \ > >>>>>>> +    ti-rpmsg-char-staticdev \ > >>>>>>> +" > >>>>>>>     EXTRA_LIBS = "" > >>>>>>>   EXTRA_LIBS_append_ti43x = "\ > >>>>>>> --  > >>>>>>> 2.28.0 > >>>>>>> > > > > Does this need to go in or are you going to send in v2? > > I am confused by the terminology above, I am not sure if I need to move this to > the packagegroup-arago-tisdk-addons.bb file, or if this is just a question of > writing the proper patch description. I cannot verify myself until I fix my OE > build issues. Suman, If you do need these development packages on the target rootfs, then you do need to add them to packagegroup-arago-tisdk-addons.bb But if you need them to be part of the devkit (cross-compile development environment on the host), then you need to add to the corresponding packagegroup-arago-tisdk-addons-sdk-target.bb In other words, do you expect someone to compile natively on the target against your library and headers? Then it's the first one. But, enabling native development environment on the target should not be decided lightly. As a matter of fact, for 7.0 we removed this from the default rootfs, expecting users to be able to add it optionally from package feeds. Though public package feeds were not ready and got postponed... So, my point is - what are you trying to achieve here? Why do you need -dev package on the target filesystem? If you are trying to enable other developers to build apps against your library, could they just write a recipe? Is it really necessary for the default rootfs? Anyway, hopefully these questions could guide you towards the proper solution. Please let me know if you still have questions :) -- Denys