From: Jarkko Sakkinen <jarkko@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
clang-built-linux@googlegroups.com,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Will Deacon <will@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1
Date: Tue, 3 Nov 2020 06:55:21 +0200 [thread overview]
Message-ID: <20201103045521.GA58906@kernel.org> (raw)
In-Reply-To: <20200902225911.209899-2-ndesaulniers@google.com>
On Wed, Sep 02, 2020 at 03:59:05PM -0700, Nick Desaulniers wrote:
> During Plumbers 2020, we voted to just support the latest release of
> Clang for now. Add a compile time check for this.
>
> We plan to remove workarounds for older versions now, which will break
> in subtle and not so subtle ways.
>
> Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
> Suggested-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
> Acked-by: Marco Elver <elver@google.com>
> Acked-by: Nathan Chancellor <natechancellor@gmail.com>
> Acked-by: Sedat Dilek <sedat.dilek@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/9
> Link: https://github.com/ClangBuiltLinux/linux/issues/941
> ---
> include/linux/compiler-clang.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h
> index cee0c728d39a..230604e7f057 100644
> --- a/include/linux/compiler-clang.h
> +++ b/include/linux/compiler-clang.h
> @@ -3,6 +3,14 @@
> #error "Please don't include <linux/compiler-clang.h> directly, include <linux/compiler.h> instead."
> #endif
>
> +#define CLANG_VERSION (__clang_major__ * 10000 \
> + + __clang_minor__ * 100 \
> + + __clang_patchlevel__)
> +
> +#if CLANG_VERSION < 100001
> +# error Sorry, your version of Clang is too old - please use 10.0.1 or newer.
> +#endif
I'm trying to compile a BPF enabled test kernel for a live system and I
get this error even though I have much newer clang:
➜ ~ (master) ✔ clang --version
Ubuntu clang version 11.0.0-2
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Tried to Google for troubleshooter tips but this patch is basically the
only hit I get :-)
> +
> /* Compiler specific definitions for Clang compiler */
>
> /* same as gcc, this was present in clang-2.6 so we can assume it works
> --
> 2.28.0.402.g5ffc5be6b7-goog
>
/Jarkko
next prev parent reply other threads:[~2020-11-03 4:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 22:59 [PATCH v3 0/7] set clang minimum version to 10.0.1 Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1 Nick Desaulniers
2020-11-03 4:55 ` Jarkko Sakkinen [this message]
2020-11-03 6:38 ` Nathan Chancellor
2020-11-03 9:00 ` Jarkko Sakkinen
2020-11-03 18:48 ` Nick Desaulniers
2020-11-04 0:38 ` Jarkko Sakkinen
2020-11-04 1:18 ` Nick Desaulniers
2020-11-04 1:34 ` Jarkko Sakkinen
2020-11-04 1:36 ` Jarkko Sakkinen
2020-11-17 3:04 ` John Hubbard
2020-11-17 18:46 ` Nick Desaulniers
2020-11-18 2:31 ` Nathan Chancellor
2020-11-18 2:37 ` Andrew Morton
2020-09-02 22:59 ` [PATCH v3 2/7] Revert "kbuild: disable clang's default use of -fmerge-all-constants" Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 3/7] Revert "arm64: bti: Require clang >= 10.0.1 for in-kernel BTI support" Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 4/7] Revert "arm64: vdso: Fix compilation with clang older than 8" Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 5/7] Partially revert "ARM: 8905/1: Emit __gnu_mcount_nc when using Clang 10.0.0 or newer" Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 6/7] kasan: Remove mentions of unsupported Clang versions Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 7/7] compiler-gcc: improve version error Nick Desaulniers
2020-09-07 21:25 ` Will Deacon
2020-09-03 14:06 ` [PATCH v3 0/7] set clang minimum version to 10.0.1 Sedat Dilek
2020-09-03 17:28 ` Nathan Chancellor
2020-09-04 5:42 ` Miguel Ojeda
2020-09-07 16:12 ` Arvind Sankar
2020-09-08 4:42 ` Nathan Chancellor
2020-09-07 21:26 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103045521.GA58906@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=ast@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=elver@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.