From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EFD4C2D0A3 for ; Tue, 3 Nov 2020 07:31:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3144721D91 for ; Tue, 3 Nov 2020 07:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbgKCHbs (ORCPT ); Tue, 3 Nov 2020 02:31:48 -0500 Received: from verein.lst.de ([213.95.11.211]:36003 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbgKCHbs (ORCPT ); Tue, 3 Nov 2020 02:31:48 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 0C56567373; Tue, 3 Nov 2020 08:31:47 +0100 (CET) Date: Tue, 3 Nov 2020 08:31:46 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH 06/17] mm/filemap: Don't call ->readpage if IOCB_WAITQ is set Message-ID: <20201103073146.GF8389@lst.de> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-7-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Nov 02, 2020 at 06:43:01PM +0000, Matthew Wilcox (Oracle) wrote: > The readpage operation can block in many (most?) filesystems, so we > should punt to a work queue instead of calling it. This was the last > caller of lock_page_async(), so remove it. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig