From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EF7C2D0A3 for ; Tue, 3 Nov 2020 08:57:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0036A22275 for ; Tue, 3 Nov 2020 08:57:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r/JIJPsn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SZQ67zdv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0036A22275 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GBtgRzXtzjxKzgYitBPUcu8siXgOWDWchvNYD6IFC8Y=; b=r/JIJPsnJ6w0q6W4oywjlKdEt TeK44FIB8vm+AGqRGOG8SLF5EF+B6Sq9k+gLZD2LIfU5/1TK22PZvZNrPBIxfyHELDIIPuwN1slI+ CO/SY9TCeineknqLcogCb4/jsL4y1IqnMKLxESE/BFxK34kpY9TsJ7llYlIQxxGIUCHUtYuLtr4Qa t+DO/bf5GJBtKh0mQnr6oPi8NXG/R340F/dS0HgVlbwYq4Hm81naJa5ebd1Dup4qZco1lBcmrnWAw YcGDeUpl6Ez1o3IXvW3DlQZUICO39pvA+Q6vbgY6LYkT4GcUwZu4jzFs6X853uGRGG0Toy401PEdw c7DhQThwg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZs7d-0007dr-Aj; Tue, 03 Nov 2020 08:56:57 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZs79-0007Pj-8U for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 08:56:29 +0000 Received: by mail-wm1-x32e.google.com with SMTP id c18so11887979wme.2 for ; Tue, 03 Nov 2020 00:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=rLDVs90HA1Aa+VugGzlqO4fLN0akysT9yEHAzoqJBD4=; b=SZQ67zdvLAgNLnEVBHfuSAHpiveEkSKRczKIGbpt3wBrWTve25M0Eh/H0+UqKG042b qSWODOktAM/IYQR9xNOtbV/xSzCknBirpktpfU7EM4M7uJRfgQjft4sXp0TOwqm3lkwz EcWHTsqfTrddlouXjbF/5+2aSePLpTDgNfOm0Hw+yO9x/yH+FasQ6DJzabfRqN/8k0nK hpRWiaqzaJUXtAoRrc3vi87SQtQveoQM/ihh8QI8TWmbCFzEmjvT7A8VWTmTCrhqs+h0 zySHsWdRiD+vfWP6Wl8pYmI5xeSMkUEnvbKrVh2eSWZ1Mbr5KWUQURH0G8OWE18oRIKg 8Hdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rLDVs90HA1Aa+VugGzlqO4fLN0akysT9yEHAzoqJBD4=; b=A85fWhHz55Fy++xtyWJYWcndvNreOBhsAEzyOOx3WvtZCpD6YQ20kL6Z+9hSQfRDnj KSPxDiUmBXXunsOVbZsYBILiN/FBcnqOW/vgoBVLL6gdzBAbh9/kHUDKiP0Qu+KybQU6 CxjPkuPpx/bcppxyml615GfSgJ4BSg/K36MaCFr1UxowHWdTK7s5jdeKf9Ox2M8rYc78 OOXkifwgkdq9D7bpHaykK0NgqUadTA+Evr29q0YixR9pVDljXWqzT6G4aGNmZh1BUZpN GKb/5NMMOh+QXMdTjV2R+l2ej1ROyD591SZQ3ZG3wptHJ7i07kq/gJbYQrqI2lAfHsZ3 WVTA== X-Gm-Message-State: AOAM533+WMByOm7KdoGooVXl8TjQ6b+htM39qPxM2zFkr0ilrt71WKB6 T3fIB0veGiQo/b4tF2S5CuTsJw== X-Google-Smtp-Source: ABdhPJwJNIYTW9tTc+Ezdxe0aES7lJBJWFwUM1pZ4XapbFkcE4vbG0IUDESF5nCL8gmLDVjDSEHgSQ== X-Received: by 2002:a1c:2d8f:: with SMTP id t137mr2344738wmt.26.1604393783224; Tue, 03 Nov 2020 00:56:23 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id u195sm2235969wmu.18.2020.11.03.00.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 00:56:22 -0800 (PST) Date: Tue, 3 Nov 2020 08:56:20 +0000 From: Lee Jones To: Codrin.Ciubotariu@microchip.com Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Message-ID: <20201103085620.GM4488@dell> References: <20201030110702.886638-1-codrin.ciubotariu@microchip.com> <20201102090122.GF4127@dell> <780303c7-2c32-f2e1-c9ce-1e2ee6bf0533@microchip.com> <20201102122952.GB4488@dell> <9f99dcf1-239d-b3b3-4b7d-e6d628bb3fed@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9f99dcf1-239d-b3b3-4b7d-e6d628bb3fed@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_035628_466949_BB4D6E54 X-CRM114-Status: GOOD ( 33.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, richard.genoud@gmail.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwMiBOb3YgMjAyMCwgQ29kcmluLkNpdWJvdGFyaXVAbWljcm9jaGlwLmNvbSB3cm90 ZToKCj4gT24gMDIuMTEuMjAyMCAxNDo1NSwgQ29kcmluLkNpdWJvdGFyaXVAbWljcm9jaGlwLmNv bSB3cm90ZToKPiA+IE9uIDAyLjExLjIwMjAgMTQ6MjksIExlZSBKb25lcyB3cm90ZToKPiA+PiBF WFRFUk5BTCBFTUFJTDogRG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW5s ZXNzIHlvdSBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUKPiA+Pgo+ID4+IE9uIE1vbiwgMDIgTm92 IDIwMjAsIENvZHJpbi5DaXVib3Rhcml1QG1pY3JvY2hpcC5jb20gd3JvdGU6Cj4gPj4KPiA+Pj4g T24gMDIuMTEuMjAyMCAxMTowMSwgTGVlIEpvbmVzIHdyb3RlOgo+ID4+Pj4gT24gRnJpLCAzMCBP Y3QgMjAyMCwgTmljb2xhcyBGZXJyZSB3cm90ZToKPiA+Pj4+Cj4gPj4+Pj4gT24gMzAvMTAvMjAy MCBhdCAxMjowNywgQ29kcmluIENpdWJvdGFyaXUgd3JvdGU6Cj4gPj4+Pj4+IFRoZSAiYXRtZWws YXQ5MXNhbTkyNjAtdXNhcnQiIGRyaXZlciBpcyBhIE1GRCBkcml2ZXIsIHNvIGl0IG5lZWRzIHN1 Yi1ub2Rlcwo+ID4+Pj4+PiB0byBtYXRjaCB0aGUgcmVnaXN0ZXJlZCBwbGF0Zm9ybSBkZXZpY2Uu IEZvciB0aGlzIHJlYXNvbiwgd2UgYWRkIGEgc2VyaWFsCj4gPj4+Pj4+IHN1Ym5vZGUgdG8gYWxs IHRoZSAiYXRtZWwsYXQ5MXNhbTkyNjAtdXNhcnQiIHNlcmlhbCBjb21wYXRpYmxlIG5vZHMuIFRo aXMKPiA+Pj4+Pj4gd2lsbCBhbHNvIHJlbW92ZSB0aGUgYm9vdCB3YXJuaW5nOgo+ID4+Pj4+PiAi YXRtZWxfdXNhcnRfc2VyaWFsOiBGYWlsZWQgdG8gbG9jYXRlIG9mX25vZGUgW2lkOiAtMl0iCj4g Pj4+Pj4KPiA+Pj4+PiBJIGRvbid0IHJlbWVtYmVyIHRoaXMgd2FybmluZyB3YXMgcmFpc2VkIHBy ZXZpb3VzbHkgZXZlbiBpZiB0aGUgTUZEIGRyaXZlcgo+ID4+Pj4+IHdhcyBhZGRlZCBhIHdoaWxl IGFnbyAoU2VwdC4gMjAxOCkuCj4gPj4+Pj4KPiA+Pj4+PiBJIHdvdWxkIHNheSBpdCdzIGR1ZSB0 byA0NjZhNjJkNzY0MmYgKCJtZmQ6IGNvcmU6IE1ha2UgYSBiZXN0IGVmZm9ydCBhdHRlbXB0Cj4g Pj4+Pj4gdG8gbWF0Y2ggZGV2aWNlcyB3aXRoIHRoZSBjb3JyZWN0IG9mX25vZGVzIikgd2hpY2gg d2FzIGFkZGVkIG9uIG1pZCBBdWd1c3QKPiA+Pj4+PiBhbmQgY29ycmVjdGVkIHdpdGggMjIzODBi NjVkYzcwICgibWZkOiBtZmQtY29yZTogRW5zdXJlIGRpc2FibGVkIGRldmljZXMgYXJlCj4gPj4+ Pj4gaWdub3JlZCB3aXRob3V0IGVycm9yIikgYnV0IG1heWJlIG5vdCBjb3ZlcmluZyBvdXIgY2Fz ZS4KPiA+Pj4+Pgo+ID4+Pj4+IFNvLCB3ZWxsLCBJIGRvbid0IGtub3cgd2hhdCdzIHRoZSBiZXN0 IG9wdGlvbiB0byB0aGlzIGNoYW5nZS4gTW9yZW92ZXIsIEkKPiA+Pj4+PiB3b3VsZCBzYXkgdGhh dCBhbGwgb3RoZXIgVVNBUlQgcmVsYXRlZCBwcm9wZXJ0aWVzIGdvIGludG8gdGhlIGNoaWxkIG5v dCBpZgo+ID4+Pj4+IHRoZXJlIGlzIGEgbmVlZCBmb3Igb25lLgo+ID4+Pj4+Cj4gPj4+Pj4gTGVl LCBJIHN1c3BlY3QgdGhhdCB3ZSdyZSBub3QgdGhlIG9ubHkgb25lcyBleHBlcmllbmNpbmcgdGhp cyB1Z2x5IHdhcm5pbmcKPiA+Pj4+PiBkdXJpbmcgdGhlIGJvb3QgbG9nOiBjYW4geW91IHBvaW50 IHVzIG91dCBob3cgdG8gZGVhbCB3aXRoIGl0IGZvciBvdXIKPiA+Pj4+PiBleGlzdGluZyBhdG1l bF9zZXJpYWwuYyB1c2Vycz8KPiA+Pj4+Cj4gPj4+PiBZb3Ugc2hvdWxkIG5vdCBiZSBpbnN0YW50 aWF0aW5nIGRyaXZlcnMgdGhyb3VnaCBEZXZpY2UgVHJlZSB3aGljaCBhcmUKPiA+Pj4+IG5vdCBk ZXNjcmliZWQgdGhlcmUuICBJZiB0aGUgY29ycmVjdCByZXByZXNlbnRhdGlvbiBvZiB0aGUgSC9X IGFscmVhZHkKPiA+Pj4+IGV4aXN0cyBpbiBEZXZpY2UgVHJlZSBpLmUuIG5vIFNQSSBhbmQgVUFS VCBJUCByZWFsbHkgZXhpc3RzLCB1c2UgdGhlCj4gPj4+PiBNRkQgY29yZSBBUEkgdG8gcmVnaXN0 ZXIgdGhlbSB1dGlsaXNpbmcgdGhlIHBsYXRmb3JtIEFQSSBpbnN0ZWFkLgo+ID4+Pj4KPiA+Pj4+ IFRoaXMgc2hvdWxkIGRvIGl0Ogo+ID4+Pj4KPiA+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21m ZC9hdDkxLXVzYXJ0LmMgYi9kcml2ZXJzL21mZC9hdDkxLXVzYXJ0LmMKPiA+Pj4+IGluZGV4IDZh ODM1MWE0NTg4ZTIuLjkzOWJkMjMzMmE0ZjYgMTAwNjQ0Cj4gPj4+PiAtLS0gYS9kcml2ZXJzL21m ZC9hdDkxLXVzYXJ0LmMKPiA+Pj4+ICsrKyBiL2RyaXZlcnMvbWZkL2F0OTEtdXNhcnQuYwo+ID4+ Pj4gQEAgLTE3LDEyICsxNywxMCBAQAo+ID4+Pj4KPiA+Pj4+ICAgICBzdGF0aWMgY29uc3Qgc3Ry dWN0IG1mZF9jZWxsIGF0OTFfdXNhcnRfc3BpX3N1YmRldiA9IHsKPiA+Pj4+ICAgICAgICAgICAg Lm5hbWUgPSAiYXQ5MV91c2FydF9zcGkiLAo+ID4+Pj4gLSAgICAgICAub2ZfY29tcGF0aWJsZSA9 ICJtaWNyb2NoaXAsYXQ5MXNhbTlnNDUtdXNhcnQtc3BpIiwKPiA+Pj4+ICAgICB9Owo+ID4+Pj4K PiA+Pj4+ICAgICBzdGF0aWMgY29uc3Qgc3RydWN0IG1mZF9jZWxsIGF0OTFfdXNhcnRfc2VyaWFs X3N1YmRldiA9IHsKPiA+Pj4+ICAgICAgICAgICAgLm5hbWUgPSAiYXRtZWxfdXNhcnRfc2VyaWFs IiwKPiA+Pj4+IC0gICAgICAgLm9mX2NvbXBhdGlibGUgPSAiYXRtZWwsYXQ5MXJtOTIwMC11c2Fy dC1zZXJpYWwiLAo+ID4+Pj4gICAgIH07Cj4gPj4+Pgo+ID4+Pj4gICAgIHN0YXRpYyBpbnQgYXQ5 MV91c2FydF9tb2RlX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPj4+Cj4g Pj4+IFtzbmlwXQo+ID4+Pgo+ID4+PiBIaSBMZWUsIHRoYW5rIHlvdSBmb3IgbG9va2luZyB0aHJv dWdoIG91ciB1c2FydCBkcml2ZXIgYW5kIGZvciBzaGFyaW5nCj4gPj4+IHlvdXIgdGhvdWdodHMu IFJlbW92aW5nIHRoZSB1c2FnZSBvZiBjb21wYXRpYmxlIHN0cmluZyBtZWFucyB0aGF0IGZvcgo+ ID4+PiBzaW1pbGFyIHNlcmlhbC9TUEkgSVBzIHdlIHdvdWxkIG5lZWQgdG8gY3JlYXRlIG5ldyBw bGF0Zm9ybSBkcml2ZXJzLgo+ID4+Cj4gPj4gV2h5IHdvdWxkIHlvdSBuZWVkIHRvIGRvIHRoYXQ/ Cj4gPiAKPiA+IEluIHRoZSBjYXNlIHdlIHdpbGwgaGF2ZSB0byBzdXBwb3J0IGFub3RoZXIgc2lt aWxhciBJUCwgYnV0IHdpdGggYQo+ID4gZGlmZmVyZW50IHNldCBvZiBmZWF0dXJlcy4gTm90IGEg bmV3IHBsYXRmb3JtIGRyaXZlciBmcm9tIHNjcmF0Y2gsIGJ1dAo+ID4gYXQgbGVhc3QgYSBuZXcg c3RydWN0IHBsYXRmb3JtX2RyaXZlciBmb3IgZWFjaCB2YXJpYW50Lgo+IAo+IEkgZ3Vlc3Mgd2Ug Y291bGQgdXNlIHN0cnVjdCBtZmRfY2VsbC5wbGF0Zm9ybV9kYXRhIHRvIHNlbGVjdCB0aGUgCj4g ZmVhdHVyZXMgZm9yIHRoZSBzZXJpYWwvU1BJLiBUaGlzIHBsYXRmb3JtIGRhdGEgY2FuIGJlIHBl ciBjb21wYXRpYmxlIG9mIAo+IG91ciBNRkQgZHJpdmVyLiBJIHdpbGwgc2VuZCBhIHBhdGNoIHdp dGggdGhlIGNoYW5nZXMgeW91IHN1Z2dlc3RlZC4gCgpZZXMsIHRoYXQgaXMgd2hhdCBwbGF0Zm9y bSBkYXRhIGlzIGZvci4KCj4gVGhhbmsgeW91IQoKTlAuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzm lq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3Jn IOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFj ZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0DAC2D0A3 for ; Tue, 3 Nov 2020 08:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D12DD223BF for ; Tue, 3 Nov 2020 08:56:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SZQ67zdv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727936AbgKCI4Z (ORCPT ); Tue, 3 Nov 2020 03:56:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727921AbgKCI4Z (ORCPT ); Tue, 3 Nov 2020 03:56:25 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A192C0617A6 for ; Tue, 3 Nov 2020 00:56:24 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id 205so4199863wma.4 for ; Tue, 03 Nov 2020 00:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=rLDVs90HA1Aa+VugGzlqO4fLN0akysT9yEHAzoqJBD4=; b=SZQ67zdvLAgNLnEVBHfuSAHpiveEkSKRczKIGbpt3wBrWTve25M0Eh/H0+UqKG042b qSWODOktAM/IYQR9xNOtbV/xSzCknBirpktpfU7EM4M7uJRfgQjft4sXp0TOwqm3lkwz EcWHTsqfTrddlouXjbF/5+2aSePLpTDgNfOm0Hw+yO9x/yH+FasQ6DJzabfRqN/8k0nK hpRWiaqzaJUXtAoRrc3vi87SQtQveoQM/ihh8QI8TWmbCFzEmjvT7A8VWTmTCrhqs+h0 zySHsWdRiD+vfWP6Wl8pYmI5xeSMkUEnvbKrVh2eSWZ1Mbr5KWUQURH0G8OWE18oRIKg 8Hdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rLDVs90HA1Aa+VugGzlqO4fLN0akysT9yEHAzoqJBD4=; b=Kz6pa2HM0C1CsI7mRlZwsraGioLXIMiUapPWq73j6jQTzORdSxFgZX0G6tzDPrwR6x FfBx8lr/ZgXd8IBSUwI5D8Sge+s9c+hv8b3uLifsRFG+H1JWLRTA1848dVGwSOA3T3+n +r1ZGWvePVlUL1P1Q7qGs7y7JRGmS3vMjXNyc4SWoSEnrbmgsgIb6G503V8uI2fiO5kF YsB4kKQmfdQtA9zt7QVbMx6C/JI+CXO6eiTCJCrb0hcFqjC843xfCMCsQsPmzsXgyysU aaVtBjRGM6yiGGm7ZwIZnSqthtQndA3s5plii1qEAedIU8emjvlttHEwWnSuSZXu14yJ lW4w== X-Gm-Message-State: AOAM531Z5Rnnt9/FVmXG+XaGoISc3kRmkcGGGkkj+NhouTrPnzUA/H1N dtLHpzmI/icjrdDK5mnDwqzxiw== X-Google-Smtp-Source: ABdhPJwJNIYTW9tTc+Ezdxe0aES7lJBJWFwUM1pZ4XapbFkcE4vbG0IUDESF5nCL8gmLDVjDSEHgSQ== X-Received: by 2002:a1c:2d8f:: with SMTP id t137mr2344738wmt.26.1604393783224; Tue, 03 Nov 2020 00:56:23 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id u195sm2235969wmu.18.2020.11.03.00.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 00:56:22 -0800 (PST) Date: Tue, 3 Nov 2020 08:56:20 +0000 From: Lee Jones To: Codrin.Ciubotariu@microchip.com Cc: Nicolas.Ferre@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, richard.genoud@gmail.com, alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Message-ID: <20201103085620.GM4488@dell> References: <20201030110702.886638-1-codrin.ciubotariu@microchip.com> <20201102090122.GF4127@dell> <780303c7-2c32-f2e1-c9ce-1e2ee6bf0533@microchip.com> <20201102122952.GB4488@dell> <9f99dcf1-239d-b3b3-4b7d-e6d628bb3fed@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9f99dcf1-239d-b3b3-4b7d-e6d628bb3fed@microchip.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 02 Nov 2020, Codrin.Ciubotariu@microchip.com wrote: > On 02.11.2020 14:55, Codrin.Ciubotariu@microchip.com wrote: > > On 02.11.2020 14:29, Lee Jones wrote: > >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> > >> On Mon, 02 Nov 2020, Codrin.Ciubotariu@microchip.com wrote: > >> > >>> On 02.11.2020 11:01, Lee Jones wrote: > >>>> On Fri, 30 Oct 2020, Nicolas Ferre wrote: > >>>> > >>>>> On 30/10/2020 at 12:07, Codrin Ciubotariu wrote: > >>>>>> The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs sub-nodes > >>>>>> to match the registered platform device. For this reason, we add a serial > >>>>>> subnode to all the "atmel,at91sam9260-usart" serial compatible nods. This > >>>>>> will also remove the boot warning: > >>>>>> "atmel_usart_serial: Failed to locate of_node [id: -2]" > >>>>> > >>>>> I don't remember this warning was raised previously even if the MFD driver > >>>>> was added a while ago (Sept. 2018). > >>>>> > >>>>> I would say it's due to 466a62d7642f ("mfd: core: Make a best effort attempt > >>>>> to match devices with the correct of_nodes") which was added on mid August > >>>>> and corrected with 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are > >>>>> ignored without error") but maybe not covering our case. > >>>>> > >>>>> So, well, I don't know what's the best option to this change. Moreover, I > >>>>> would say that all other USART related properties go into the child not if > >>>>> there is a need for one. > >>>>> > >>>>> Lee, I suspect that we're not the only ones experiencing this ugly warning > >>>>> during the boot log: can you point us out how to deal with it for our > >>>>> existing atmel_serial.c users? > >>>> > >>>> You should not be instantiating drivers through Device Tree which are > >>>> not described there. If the correct representation of the H/W already > >>>> exists in Device Tree i.e. no SPI and UART IP really exists, use the > >>>> MFD core API to register them utilising the platform API instead. > >>>> > >>>> This should do it: > >>>> > >>>> diff --git a/drivers/mfd/at91-usart.c b/drivers/mfd/at91-usart.c > >>>> index 6a8351a4588e2..939bd2332a4f6 100644 > >>>> --- a/drivers/mfd/at91-usart.c > >>>> +++ b/drivers/mfd/at91-usart.c > >>>> @@ -17,12 +17,10 @@ > >>>> > >>>> static const struct mfd_cell at91_usart_spi_subdev = { > >>>> .name = "at91_usart_spi", > >>>> - .of_compatible = "microchip,at91sam9g45-usart-spi", > >>>> }; > >>>> > >>>> static const struct mfd_cell at91_usart_serial_subdev = { > >>>> .name = "atmel_usart_serial", > >>>> - .of_compatible = "atmel,at91rm9200-usart-serial", > >>>> }; > >>>> > >>>> static int at91_usart_mode_probe(struct platform_device *pdev) > >>> > >>> [snip] > >>> > >>> Hi Lee, thank you for looking through our usart driver and for sharing > >>> your thoughts. Removing the usage of compatible string means that for > >>> similar serial/SPI IPs we would need to create new platform drivers. > >> > >> Why would you need to do that? > > > > In the case we will have to support another similar IP, but with a > > different set of features. Not a new platform driver from scratch, but > > at least a new struct platform_driver for each variant. > > I guess we could use struct mfd_cell.platform_data to select the > features for the serial/SPI. This platform data can be per compatible of > our MFD driver. I will send a patch with the changes you suggested. Yes, that is what platform data is for. > Thank you! NP. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog