From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71504C388F7 for ; Tue, 3 Nov 2020 08:45:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF235223BF for ; Tue, 3 Nov 2020 08:45:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF235223BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 499706E09F; Tue, 3 Nov 2020 08:45:48 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id A90026E09F for ; Tue, 3 Nov 2020 08:45:47 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 44B9D1F45357; Tue, 3 Nov 2020 08:45:46 +0000 (GMT) Date: Tue, 3 Nov 2020 09:45:43 +0100 From: Boris Brezillon To: Steven Price Subject: Re: [PATCH] drm/panfrost: Fix a deadlock between the shrinker and madvise path Message-ID: <20201103094543.69e5fd45@collabora.com> In-Reply-To: <12019a24-239e-6d51-316c-b5438e5af892@arm.com> References: <20201101174016.839110-1-boris.brezillon@collabora.com> <12019a24-239e-6d51-316c-b5438e5af892@arm.com> Organization: Collabora X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Christian Hewitt , stable@vger.kernel.org, Rob Herring , Alyssa Rosenzweig , Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 2 Nov 2020 08:42:49 +0000 Steven Price wrote: > On 01/11/2020 17:40, Boris Brezillon wrote: > > panfrost_ioctl_madvise() and panfrost_gem_purge() acquire the mappings > > and shmem locks in different orders, thus leading to a potential > > the mappings lock first. > > > > Fixes: bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept") > > Cc: > > Cc: Christian Hewitt > > Reported-by: Christian Hewitt > > Signed-off-by: Boris Brezillon > > Reviewed-by: Steven Price Queued to drm-misc-fixes. Thanks, Boris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E1E1C388F2 for ; Tue, 3 Nov 2020 08:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC51D223BF for ; Tue, 3 Nov 2020 08:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726109AbgKCIpr (ORCPT ); Tue, 3 Nov 2020 03:45:47 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:45552 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbgKCIpr (ORCPT ); Tue, 3 Nov 2020 03:45:47 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 44B9D1F45357; Tue, 3 Nov 2020 08:45:46 +0000 (GMT) Date: Tue, 3 Nov 2020 09:45:43 +0100 From: Boris Brezillon To: Steven Price Cc: Rob Herring , Alyssa Rosenzweig , Robin Murphy , dri-devel@lists.freedesktop.org, stable@vger.kernel.org, Christian Hewitt Subject: Re: [PATCH] drm/panfrost: Fix a deadlock between the shrinker and madvise path Message-ID: <20201103094543.69e5fd45@collabora.com> In-Reply-To: <12019a24-239e-6d51-316c-b5438e5af892@arm.com> References: <20201101174016.839110-1-boris.brezillon@collabora.com> <12019a24-239e-6d51-316c-b5438e5af892@arm.com> Organization: Collabora X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 2 Nov 2020 08:42:49 +0000 Steven Price wrote: > On 01/11/2020 17:40, Boris Brezillon wrote: > > panfrost_ioctl_madvise() and panfrost_gem_purge() acquire the mappings > > and shmem locks in different orders, thus leading to a potential > > the mappings lock first. > > > > Fixes: bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept") > > Cc: > > Cc: Christian Hewitt > > Reported-by: Christian Hewitt > > Signed-off-by: Boris Brezillon > > Reviewed-by: Steven Price Queued to drm-misc-fixes. Thanks, Boris