From: Greg KH <gregkh@linuxfoundation.org>
To: Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
oliver@neukum.org
Subject: Re: [PATCH net-next v3 1/2] include/linux/usb: new header file for the vendor ID of USB devices
Date: Tue, 3 Nov 2020 10:55:21 +0100 [thread overview]
Message-ID: <20201103095521.GA81899@kroah.com> (raw)
In-Reply-To: <1394712342-15778-390-Taiwan-albertk@realtek.com>
On Tue, Nov 03, 2020 at 05:46:37PM +0800, Hayes Wang wrote:
> diff --git a/include/linux/usb/usb_vendor_id.h b/include/linux/usb/usb_vendor_id.h
> new file mode 100644
> index 000000000000..23b6e6849515
> --- /dev/null
> +++ b/include/linux/usb/usb_vendor_id.h
> @@ -0,0 +1,51 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +
<snip>
No, this is not ok, sorry. Please see the top of the pci_ids.h file why
we do not do this.
There is nothing wrong with putting the individual ids in the different
drivers, we don't want one single huge file that is a pain for merges
and builds. We learn from our past mistakes, please do not fail to
learn from history :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-11-03 9:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 12:33 [PATCH] net/usb/r8153_ecm: support ECM mode for RTL8153 Hayes Wang
2020-10-29 15:04 ` kernel test robot
2020-10-29 15:04 ` kernel test robot
2020-10-30 3:23 ` [PATCH net-next v2] " Hayes Wang
2020-10-31 23:08 ` Jakub Kicinski
2020-11-02 7:20 ` Hayes Wang
2020-11-02 19:47 ` Jakub Kicinski
2020-11-03 9:32 ` Greg Kroah-Hartman
2020-11-03 9:51 ` Hayes Wang
2020-11-03 16:15 ` Jakub Kicinski
2020-11-04 1:39 ` Hayes Wang
2020-11-04 1:44 ` Jakub Kicinski
2020-11-03 9:46 ` [PATCH net-next v3 0/2] drivers/net/usb: " Hayes Wang
2020-11-03 9:46 ` [PATCH net-next v3 1/2] include/linux/usb: new header file for the vendor ID of USB devices Hayes Wang
2020-11-03 9:55 ` Greg KH [this message]
2020-11-03 9:46 ` [PATCH net-next v3 2/2] net/usb/r8153_ecm: support ECM mode for RTL8153 Hayes Wang
2020-11-04 2:19 ` [PATCH net-next v2 RESEND] " Hayes Wang
2020-11-06 1:00 ` Jakub Kicinski
2020-11-13 15:29 ` Marek Szyprowski
2020-11-16 6:52 ` [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver Hayes Wang
2020-11-16 9:18 ` Marek Szyprowski
2020-11-16 17:02 ` Jakub Kicinski
2020-11-17 1:50 ` Hayes Wang
2020-11-17 16:11 ` Jakub Kicinski
2020-11-18 1:21 ` Hayes Wang
2020-11-18 6:43 ` [PATCH net-next v2] " Hayes Wang
2020-11-18 8:18 ` Marek Szyprowski
2020-11-19 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103095521.GA81899@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.