From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A326C388F9 for ; Tue, 3 Nov 2020 15:31:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E36220735 for ; Tue, 3 Nov 2020 15:31:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728263AbgKCPbU (ORCPT ); Tue, 3 Nov 2020 10:31:20 -0500 Received: from verein.lst.de ([213.95.11.211]:37958 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728048AbgKCPbU (ORCPT ); Tue, 3 Nov 2020 10:31:20 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id C520D6736F; Tue, 3 Nov 2020 16:31:18 +0100 (CET) Date: Tue, 3 Nov 2020 16:31:18 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kent.overstreet@gmail.com Subject: Re: [PATCH 11/17] mm/filemap: Add filemap_range_uptodate Message-ID: <20201103153118.GC10928@lst.de> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-12-willy@infradead.org> <20201103074944.GK8389@lst.de> <20201103151847.GZ27442@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103151847.GZ27442@casper.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Nov 03, 2020 at 03:18:47PM +0000, Matthew Wilcox wrote: > I have a simplification in mind that gets rid of the awkward 'first' > parameter. In filemap_get_pages(), do: > > if ((iocb->ki_flags & IOCB_WAITQ) && (pagevec_count(pvec) > 1)) > iocb->ki_flags |= IOCB_NOWAIT; > > before calling filemap_update_page(). That matches what Kent did in > filemap_read(): Yes, that makes a lot of sense. No need for the second pair of inner braces, though :)