From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 659B1C2D0A3 for ; Tue, 3 Nov 2020 16:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A8D8206DF for ; Tue, 3 Nov 2020 16:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604421376; bh=uJ3h+4iizqbAisoa/vB6xgtZMiJxmXRUMMP/9MaIgvo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZLVVegOoh96woO3Q1oCJiPMkw9zKpjz2lsdThHwJujjB3q1qrTj1FjwSEHMmJrVKS XzRvQMm1+gGO4PF9wT0jBSAOimYt3ZhUI6RAdMKj1Oyp8h9sa1Cynf+UtlOb8rh+JF Xgjv4yKadE/q6HLL0GKc5PnpA9rmAYPj/R1PQzcI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbgKCQgP convert rfc822-to-8bit (ORCPT ); Tue, 3 Nov 2020 11:36:15 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33101 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726212AbgKCQgP (ORCPT ); Tue, 3 Nov 2020 11:36:15 -0500 Received: by mail-wm1-f65.google.com with SMTP id p19so263894wmg.0; Tue, 03 Nov 2020 08:36:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cTjlYON13Zu56G6DRMOT0+CuDlotYCOu5ATCgZ1qAYA=; b=pTkrNbGL0ECF5PDUdMo+uYvp9WqonpZVkhnrK6nqBIhD/lJO8I56pmropuDU5lSBvs YkIrRnRrSe8aYm1tDQdjzcIiFSV4aYJgvX0fYA8741StmpqcmbMd+zfJlcl4AHP9M7uk ts2Zj8Ug9+RgzTxSlTOJEcC5ulfJP3ohnb6XgChFZP6gVA9tqSX7+qm+e91+4zZDN2kg 4WHSXHUUuvfasPIAqTZEqV4P2mHooTEqZ9X2EuFdAj8Nqv3iMxEvZADuKI2hWhVg6Qnr qb1M6rO9bYj3zJbfWIAGn/vFhWOpRreFbXRBLwngNzh4/lv8B6vdm2AUcBWhjclGpPOk P1Xw== X-Gm-Message-State: AOAM531LK2e61s4sfIe9oC8Run8QZV8J1xAW6Jxfx5Qfh0RUAqB9mNE+ dPii6U5p8UlBnpFrCFdWboI= X-Google-Smtp-Source: ABdhPJxHzxo5YQixVSJNJEaG6+VK30+X9uB9IVlFZG8qSVKAUVEINpbu5yYjVrgUDBesX+tzGFzP3A== X-Received: by 2002:a7b:c24b:: with SMTP id b11mr593534wmj.109.1604421373200; Tue, 03 Nov 2020 08:36:13 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t199sm3530470wmt.46.2020.11.03.08.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 08:36:12 -0800 (PST) Date: Tue, 3 Nov 2020 17:36:10 +0100 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Rob Herring , Kukjin Kim , Anand Moon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkiewicz?= , Marek Szyprowski Subject: Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3 Message-ID: <20201103163610.GA14739@kozik-lap> References: <20201103124618.21358-1-l.stelmach@samsung.com> <20201103124618.21358-2-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20201103124618.21358-2-l.stelmach@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote: > Create ethernet alias Your commit msg should explain why. > and assign appropriate compatible properties. Then what was before? Indeed they do not look like anything reasonable... old VID do not appear on any of Odroid boards. > > Signed-off-by: Łukasz Stelmach > --- Best regards, Krzysztof > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts > index d0f6ac5fa79d..2a4153484664 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts > @@ -15,6 +15,10 @@ > / { > model = "Hardkernel Odroid XU3"; > compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5"; > + > + aliases { > + ethernet = ðernet; > + }; > }; > > &i2c_0 { > @@ -76,13 +80,13 @@ &usbhost2 { > #size-cells = <0>; > > hub@1 { > - compatible = "usb8087,0024"; > + compatible = "usb0424,9514"; > reg = <1>; > #address-cells = <1>; > #size-cells = <0>; > > ethernet: usbether@1 { > - compatible = "usb0c45,6310"; > + compatible = "usb0424,ec00"; > reg = <1>; > local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */ > }; > -- > 2.26.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1313DC2D0A3 for ; Tue, 3 Nov 2020 16:37:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A88902072C for ; Tue, 3 Nov 2020 16:37:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yWpAeeSO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A88902072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xLRFGFssmUi3nkwlrxDgWSvMmyjDS4Uw3zYSB8VlATo=; b=yWpAeeSOU6a4xTRtYNWkQBD0F KAEIPO2coeWHsncnGATFxdUHbrsyAzkEi0TqIzCF1ZuOlmySMAjVektCvtFYFuzLTi06lP2ztI8dZ E0x+Rt8K3WHQni5HyGSTlvnxjhniIoPqFVK4CXor0PW/tnH411xV1GuTr8uuafHo6kEnBnGrUiZqR 9hAEerY2G2W754az9ZVIl4hax6zS7A5ioJ1YC3JFCxZmojvgZ0s3ycZYUEzVyGl54CYWg5OsSX134 ygDfO89w3A19Lg/U+hUZ/OpCDzhNHKVphvk0mKz0jJiiFX9K72IFhAqOE3h5RbkZD1f/yJkvz3xtM R2+GrZwLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZzIC-0004hg-1a; Tue, 03 Nov 2020 16:36:20 +0000 Received: from mail-wm1-f65.google.com ([209.85.128.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZzI8-0004gM-9i for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 16:36:18 +0000 Received: by mail-wm1-f65.google.com with SMTP id c16so13403009wmd.2 for ; Tue, 03 Nov 2020 08:36:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cTjlYON13Zu56G6DRMOT0+CuDlotYCOu5ATCgZ1qAYA=; b=AbfeHcry76m2ZuaNH3mudjOPJQZgv+mh56yKpnw6KVx8w99mbytsQH0vemvQpi6dA2 s5zLSLC3Uc8sd+c5ZRgH0Z78XkGS3NXJgoDaM88ZQ4VuX5nMKQGIsdAe9+euyY3Bgw9t kvzLiuACaoTJT/LSI/hmmuZIiDdfTVGrKGwlgk+xRLgMOPKAwrDcBnvy24ZdrsNyF1uD DawNATpx9wGKUMFlnZfEvPOtRY4s9UrY+d4MG3wXpZt6W8KuOkZF38zMf1uauPR24Jmv UH2ruwIjvIWtoACUQbd2kGtKtevzUxa6UYqZ20SV2ZJajh1tvu8cnGZHTHiOXERDe6K/ sgSg== X-Gm-Message-State: AOAM533ofCQi5REUB1ZtiiN7Tl1E7eeRLkEsyZxYaXfA+Y15kTI+3dSx RRDX5JlV1UZMJs3tKlfTq/M= X-Google-Smtp-Source: ABdhPJxHzxo5YQixVSJNJEaG6+VK30+X9uB9IVlFZG8qSVKAUVEINpbu5yYjVrgUDBesX+tzGFzP3A== X-Received: by 2002:a7b:c24b:: with SMTP id b11mr593534wmj.109.1604421373200; Tue, 03 Nov 2020 08:36:13 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t199sm3530470wmt.46.2020.11.03.08.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 08:36:12 -0800 (PST) Date: Tue, 3 Nov 2020 17:36:10 +0100 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3 Message-ID: <20201103163610.GA14739@kozik-lap> References: <20201103124618.21358-1-l.stelmach@samsung.com> <20201103124618.21358-2-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103124618.21358-2-l.stelmach@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_113616_385396_4BBBAC74 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkiewicz?= , Anand Moon , linux-kernel@vger.kernel.org, Rob Herring , Kukjin Kim , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBOb3YgMDMsIDIwMjAgYXQgMDE6NDY6MTRQTSArMDEwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBDcmVhdGUgZXRoZXJuZXQgYWxpYXMgCgpZb3VyIGNvbW1pdCBtc2cgc2hvdWxk IGV4cGxhaW4gd2h5LgoKCj4gYW5kIGFzc2lnbiBhcHByb3ByaWF0ZSBjb21wYXRpYmxlIHByb3Bl cnRpZXMuCgpUaGVuIHdoYXQgd2FzIGJlZm9yZT8gSW5kZWVkIHRoZXkgZG8gbm90IGxvb2sgbGlr ZSBhbnl0aGluZwpyZWFzb25hYmxlLi4uIG9sZCBWSUQgZG8gbm90IGFwcGVhciBvbiBhbnkgb2Yg T2Ryb2lkIGJvYXJkcy4KCj4gCj4gU2lnbmVkLW9mZi1ieTogxYF1a2FzeiBTdGVsbWFjaCA8bC5z dGVsbWFjaEBzYW1zdW5nLmNvbT4KPiAtLS0KCkJlc3QgcmVnYXJkcywKS3J6eXN6dG9mCgo+ICBh cmNoL2FybS9ib290L2R0cy9leHlub3M1NDIyLW9kcm9pZHh1My5kdHMgfCA4ICsrKysrKy0tCj4g IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2V4eW5vczU0MjItb2Ryb2lkeHUzLmR0cyBiL2Fy Y2gvYXJtL2Jvb3QvZHRzL2V4eW5vczU0MjItb2Ryb2lkeHUzLmR0cwo+IGluZGV4IGQwZjZhYzVm YTc5ZC4uMmE0MTUzNDg0NjY0IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2V4eW5v czU0MjItb2Ryb2lkeHUzLmR0cwo+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL2V4eW5vczU0MjIt b2Ryb2lkeHUzLmR0cwo+IEBAIC0xNSw2ICsxNSwxMCBAQAo+ICAvIHsKPiAgCW1vZGVsID0gIkhh cmRrZXJuZWwgT2Ryb2lkIFhVMyI7Cj4gIAljb21wYXRpYmxlID0gImhhcmRrZXJuZWwsb2Ryb2lk LXh1MyIsICJzYW1zdW5nLGV4eW5vczU4MDAiLCAic2Ftc3VuZyxleHlub3M1IjsKPiArCj4gKwlh bGlhc2VzIHsKPiArCQlldGhlcm5ldCA9ICZldGhlcm5ldDsKPiArCX07Cj4gIH07Cj4gIAo+ICAm aTJjXzAgewo+IEBAIC03NiwxMyArODAsMTMgQEAgJnVzYmhvc3QyIHsKPiAgCSNzaXplLWNlbGxz ID0gPDA+Owo+ICAKPiAgCWh1YkAxIHsKPiAtCQljb21wYXRpYmxlID0gInVzYjgwODcsMDAyNCI7 Cj4gKwkJY29tcGF0aWJsZSA9ICJ1c2IwNDI0LDk1MTQiOwo+ICAJCXJlZyA9IDwxPjsKPiAgCQkj YWRkcmVzcy1jZWxscyA9IDwxPjsKPiAgCQkjc2l6ZS1jZWxscyA9IDwwPjsKPiAgCj4gIAkJZXRo ZXJuZXQ6IHVzYmV0aGVyQDEgewo+IC0JCQljb21wYXRpYmxlID0gInVzYjBjNDUsNjMxMCI7Cj4g KwkJCWNvbXBhdGlibGUgPSAidXNiMDQyNCxlYzAwIjsKPiAgCQkJcmVnID0gPDE+Owo+ICAJCQls b2NhbC1tYWMtYWRkcmVzcyA9IFswMCAwMCAwMCAwMCAwMCAwMF07IC8qIEZpbGxlZCBpbiBieSBh IGJvb3Rsb2FkZXIgKi8KPiAgCQl9Owo+IC0tIAo+IDIuMjYuMgo+IAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=