All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 2/2] package/abootimg: use util-linux-libs
Date: Tue, 3 Nov 2020 22:14:12 +0100	[thread overview]
Message-ID: <20201103211412.GL2887157@scaer> (raw)
In-Reply-To: <20201103205745.123950-2-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2020-11-03 21:57 +0100, Fabrice Fontaine spake thusly:
> abootimg only needs libblkid from util-linux-libs
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
>  - Select util-linux-libs instead of util-linux
> 
>  package/abootimg/Config.in   | 2 +-
>  package/abootimg/abootimg.mk | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/abootimg/Config.in b/package/abootimg/Config.in
> index 30e5bd1fb0..8aa4cb414c 100644
> --- a/package/abootimg/Config.in
> +++ b/package/abootimg/Config.in
> @@ -1,7 +1,7 @@
>  config BR2_PACKAGE_ABOOTIMG
>  	bool "abootimg"
>  	depends on BR2_USE_MMU	# libblkid
> -	select BR2_PACKAGE_UTIL_LINUX
> +	select BR2_PACKAGE_UTIL_LINUX_LIBS
>  	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID

BR2_PACKAGE_UTIL_LINUX_LIBBLKID is an option of util-linux, so you can't
drop the "select BR2_PACKAGE_UTIL_LINUX"

That's again probably my fault, because I was maybe not exhaustive
enough on my previous reply in the libglib2 thread.

However, please see what I replied to the v1 of this series.

Still, it is not trivial, so we colectively need to think about it...

Regards,
Yann E. MORIN.

>  	help
>  	  Tool to manipulate Android Boot Images, either on files
> diff --git a/package/abootimg/abootimg.mk b/package/abootimg/abootimg.mk
> index e906546948..d139d58ceb 100644
> --- a/package/abootimg/abootimg.mk
> +++ b/package/abootimg/abootimg.mk
> @@ -9,8 +9,8 @@ ABOOTIMG_SITE = $(call github,ggrandou,abootimg,$(ABOOTIMG_VERSION))
>  ABOOTIMG_LICENSE = GPL-2.0+
>  ABOOTIMG_LICENSE_FILES = LICENSE
>  
> -# depends on libblkid from util-linux
> -ABOOTIMG_DEPENDENCIES = util-linux
> +# depends on libblkid from util-linux-libs
> +ABOOTIMG_DEPENDENCIES = util-linux-libs

>  define ABOOTIMG_BUILD_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
> -- 
> 2.28.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-11-03 21:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 20:57 [Buildroot] [PATCH v2, 1/2] package/util-linux: select BR2_PACKAGE_UTIL_LINUX_LIBS Fabrice Fontaine
2020-11-03 20:57 ` [Buildroot] [PATCH v2,2/2] package/abootimg: use util-linux-libs Fabrice Fontaine
2020-11-03 21:14   ` Yann E. MORIN [this message]
2020-12-01 21:19   ` [Buildroot] [PATCH v2, 2/2] " Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103211412.GL2887157@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.