Re: [RESEND 19/19] scsi: hpsa: Strip out a bunch of set but unused variables

[Lee Jones <lee.jones@linaro.org>]

[-- Attachment #1: Type: text/plain, Size: 2511 bytes --]

On Wed, 04 Nov 2020, kernel test robot wrote:

> Hi Lee,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on mkp-scsi/for-next]
> [also build test WARNING on scsi/for-next linus/master v5.10-rc2 next-20201103]
> [cannot apply to linux/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Lee-Jones/Rid-W-1-warnings-in-SCSI/20201102-222943
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
> config: s390-randconfig-r015-20201103 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1fcd5d5655e29f85e12b402e32974f207cfedf32)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install s390 cross compiling tool for clang build
>         # apt-get install binutils-s390x-linux-gnu
>         # https://github.com/0day-ci/linux/commit/072f10ed00f6c539280c1143a76e724bd7618c22
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Lee-Jones/Rid-W-1-warnings-in-SCSI/20201102-222943
>         git checkout 072f10ed00f6c539280c1143a76e724bd7618c22
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390 

[...]

>   8706		/* configure PCI DMA stuff */
>   8707		rc = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
>   8708		if (rc != 0)

Ah, missing brace.

I wonder why my own compiler didn't complain.

Will fix.

>   8709			rc = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> > 8710			if (rc != 0) {
>   8711				dev_err(&pdev->dev, "no suitable DMA available\n");
>   8712				goto clean3;	/* shost, pci, lu, aer/h */
>   8713			}
>   8714		}
>   8715	
>   8716		/* make sure the board interrupts are off */
>   8717		h->access.set_intr_mask(h, HPSA_INTR_OFF);
>   8718	
> > 8719		rc = hpsa_request_irqs(h, do_hpsa_intr_msi, do_hpsa_intr_intx);
>   8720		if (rc)
>   8721			goto clean3;	/* shost, pci, lu, aer/h */

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog